• Jon Olav Hauglid's avatar
    Bug #50821 Deadlock between LOCK TABLES and ALTER TABLE · 34de83e1
    Jon Olav Hauglid authored
    This was a deadlock between ALTER TABLE and another DML statement
    (or LOCK TABLES ... READ). ALTER TABLE would wait trying to upgrade
    its lock to MDL_EXCLUSIVE and the DML statement would wait trying
    to acquire a TL_READ_NO_INSERT table level lock.
    
    This could happen if one connection first acquired a MDL_SHARED_READ
    lock on a table. In another connection ALTER TABLE is then started.
    ALTER TABLE eventually blocks trying to upgrade to MDL_EXCLUSIVE,
    but while holding a TL_WRITE_ALLOW_READ table level lock.
    
    If the first connection then tries to acquire TL_READ_NO_INSERT,
    it will block and we have a deadlock since neither connection can
    proceed.
    
    This patch fixes the problem by allowing TL_READ_NO_INSERT 
    locks to be granted if another connection holds TL_WRITE_ALLOW_READ
    on the same table. This will allow the DML statement to proceed
    such that it eventually can release its MDL lock which in turn
    makes ALTER TABLE able to proceed.
    
    Note that TL_READ_NO_INSERT was already partially compatible with
    TL_WRITE_ALLOW_READ as the latter would be granted if the former
    lock was held. This patch just makes the opposite true as well.
    
    Also note that since ALTER TABLE takes an upgradable MDL lock,
    there will be no starvation of ALTER TABLE statements by
    statements acquiring TL_READ or TL_READ_NO_INSERT.
    
    Test case added to lock_sync.test.
    34de83e1
thr_lock.c 57.1 KB