• unknown's avatar
    Fix for Windows-specific bugs: · 4a1763e4
    unknown authored
    - one which led REDO_INSERT_ROW_BLOBS to fail to apply
    - one excess close ("-1 file left open")
    Don't need maria-path option / environment variable.
    Fixes for ma_test_all-t to run under Windows.
    Port of ma_test_recovery to Perl, written by Jani.
    
    
    storage/maria/unittest/ma_test_recovery.expected:
      Rename: storage/maria/ma_test_recovery.expected -> storage/maria/unittest/ma_test_recovery.expected
    mysys/my_pread.c:
      Fix for Windows-specific bug (maria_read_log -a failed during
      ma_test_all-t): Windows does not have pread() so the branch setting
      HA_ERR_FILE_TOO_SHORT was not compiled in, broke applying of
      REDO_INSERT_ROW_BLOBS. After fixing that, it appeared that in my
      Windows machine, errno is not changed in case of EOF; as we read it
      we have to reset it at start.
      The changed to readbytes!=-1 is to detect EOF
    mysys/my_read.c:
      The change to readbytes!=-1 is to detect EOF
    storage/maria/ma_loghandler.c:
      Fix for Windows-specific bug: as we don't open the directory
      we should not close it.
    storage/maria/ma_page.c:
      This is C, cannot declare variable after instruction.
    storage/maria/ma_test_recovery:
      ma_test_recovery.expected moved
    storage/maria/unittest/ma_test_all-t:
      Can now safely guess maria_path so don't need the command-line option
      or environment variable. Port to Windows (.exe, different locations
      of executables); can guess suffix, don't need --suffix.
    storage/maria/unittest/ma_test_recovery.pl:
      Perl version of ma_test_recovery, written by Jani. Will deprecate the
      shell version.
    4a1763e4
my_pread.c 6.16 KB