• anel's avatar
    MDEV-28344:sys.ps_setup_save and dependent procedures fail with ER_ILLEGAL_HA_CREATE_OPTION · 56fd0d7b
    anel authored
    - The problem:
    ==============
    - Commit f7216fa6 created the check function for
      default temporary storage engine and in case the SE doesn't support temporary tables
      the error `ER_ILLEGAL_HA_CREATE_OPTION` is raised.
      Before that commit in such cases temporary tables were created by silently substituting
      default SE (RocksDB, Connect, PerfSchema) with MyISAM.
    - The test `pr_diagnostics.test` was modified in that commit with raising the error,
      since I didn't check the root cause of test itself.
    
    - The solution:
    ===============
    - This commit update the root case: procedure `ps_setup_save()` that uses temporary
      tables created from performance schema tables definition using `LIKE`, what is not supported.
      The suggested fix is to use InnoDB table by using `AS SELECT`.
    - Note that test `pr_diagnostics` will raise this error for `medium/full` third argument,
      but not for `current` value of third argument.
    - Additionally this patch updates the test case of commit f7216fa6, by adding missing relation
      between temporary tables and Performance schema in `perfschema.misc` test.
    
    - Reviewed by: <wlad@mariadb.com>
    56fd0d7b
pr_diagnostics.test 1.29 KB