• unknown's avatar
    changes to IM that came from Petr and JimW's review. · 5d8222cd
    unknown authored
    
    server-tools/instance-manager/IMService.cpp:
      make sure HandleServiceOptions returns 0 on success and 1 on failure
    server-tools/instance-manager/mysqlmanager.cc:
      default return value is 1.
      simplify some code bits by just jumping to err on error.
      move options.cleanup inside the err block.  In this case, the err block
      is more than just an error block.  It is the terminating block
      for both error and success.  You set return_value to 0 for success
      or leave it as 1 for failure.  This simplies this function a bit.
    server-tools/instance-manager/options.cc:
      remove the malloc for default password filename on Windows and replace
      with statically allocated memory.
      
      default Options:saved_argv to NULL so that we will know if we need
      to free it in cleanup()
      
      setup the default config file location for Windows inside the
      setup_windows_defaults function and remove this code from load()
      
      rework setup_windows_defaults so that it properly returns 0 on success
      and 1 on error and so it fills in the default location for the
      log file, password file, and config file.
    5d8222cd
mysqlmanager.cc 9.73 KB