• unknown's avatar
    Cleanups during review · 68b4d7b7
    unknown authored
    Changed defaults option --instance to --defaults-group-suffix
    Changed option handling to allow --defaults-file, --defaults-extra-file and --defaults-group-suffix to be given in any order
    Changed MYSQL_INSTANCE to MYSQL_GROUP_SUFFIX
    mysql_print_defaults now understands --defaults-group-suffix
    Remove usage of my_tempnam() (not safe function)
    if( -> if ( and while( to while (
    
    
    BitKeeper/deleted/.del-my_tempnam.c~a8562f15dad3012f:
      Delete: mysys/my_tempnam.c
    VC++Files/client/mysqlclient.dsp:
      Remove not used file my_tempnam.c
    VC++Files/client/mysqlclient_ia64.dsp:
      Remove not used file my_tempnam.c
    VC++Files/libmysql/libmysql.dsp:
      Remove not used file my_tempnam.c
    VC++Files/libmysql/libmysql_ia64.dsp:
      Remove not used file my_tempnam.c
    VC++Files/mysys/mysys.dsp:
      Remove not used file my_tempnam.c
    VC++Files/mysys/mysys_ia64.dsp:
      Remove not used file my_tempnam.c
    client/mysql.cc:
      Change to use get_defaults_options()
      Remove compiler warnings
    client/mysqldump.c:
      Indentation fixes
      Use quoted table name for 'primary_key_fields'
    extra/my_print_defaults.c:
      Add support for --defaults-group-suffix
      change to use get_default_options()
    extra/replace.c:
      Replace my_tempnam() with create_tmp_file() to allow us to remove my_tempnam.c
    include/config-win.h:
      Added DEFAULT_GROUP_SUFFIX_ENV
    include/my_sys.h:
      Change defaults_instance -> defaults_group_suffix
      Change get_defaults_files -> get_defaults_options
    libmysql/Makefile.shared:
      Added DEFAULT_GROUP_SUFFIX_ENV
    mysys/Makefile.am:
      Added DEFAULT_GROUP_SUFFIX_ENV
      Remove my_tempnam.c
    mysys/default.c:
      Changed --instance to --defaults-group-suffix
      Changed MYSQL_INSTANCE to MYSQL_GROUP_SUFFIX and moved the name to Makefile.am
      (mysys shouldn't by MySQL independent)
      Changed option handling to allow --defaults-file, --defaults-extra-file and --defaults-group-suffix to be given in any order
    mysys/default_modify.c:
      Optimized code to use allocated space more efficently
      Reduce code size
      Ensure that realloc() works independent of argument size
    mysys/my_bitmap.c:
      Added missing return
    sql/ha_innodb.cc:
      Change if( -> if (
    sql/ha_ndbcluster.cc:
      Change while( -> while (
    sql/item_cmpfunc.cc:
      Break loop early (simple optimization)
    sql/item_strfunc.cc:
      Change if( -> if (
    sql/log.cc:
      Fixed comment
    sql/mysqld.cc:
      Change if( -> if (
    sql/opt_range.cc:
      while( -> while (
      if( -> if (
    sql/parse_file.cc:
      Change if( -> if (
    sql/sql_cache.cc:
      while( -> while (
    sql/sql_parse.cc:
      Change if( -> if (
    sql/sql_prepare.cc:
      Added comment
    sql/sql_select.cc:
      while( -> while (
      Removed index variable by incrementing pointer
    sql/sql_show.cc:
      Change if( -> if (
    sql/sql_yacc.yy:
      Change if( -> if (
    tests/mysql_client_test.c:
      Added cast to first argument to bzero()
    68b4d7b7
my_sys.h 34.3 KB