• Monty's avatar
    Change replication to use uchar for all buffers instead of char · 85d6278f
    Monty authored
    This change is to get rid of randomly failing tests, especially those
    that reads random position of the binary log. From looking at the logs
    it's clear that some failures is because of a read char (with value >= 128)
    is converted to a big long value. Using uchar everywhere makes this much
    less likely to happen.
    Another benefit is that a lot of cast of char to uchar could be removed.
    
    Other things:
    - Removed some extra space before '=' and '+=' in assignments
    - Fixed indentations and lines > 80 characters
    - Replace '16' with 'element_size' (from class definition) in
      Gtid_list_log_event()
    85d6278f
sql_binlog.cc 11.7 KB