• bar@mysql.com's avatar
    1. Item now uses my_charset_bin by default, · 8cfe7296
    bar@mysql.com authored
    not default_charset_into. It fixes the
    problem that in some cases numbers where
    treated as CHAR(N), not as BINARY(N), e.g.
    wrong 'charsetnr' when sent to the client side.
    2. IFNULL didn't aggregate argument charsets
    and collations, so IFNULL(1,'a') produced
    a CHAR(N). Now produces a BINARY(N).
    3. SELECT PROCEDURE ANALIZE now returns
    BINARY columns, which is much better than it worked
    previously: CHAR with the default character set.
    But in the future it's worth to fix the fields
    'Field_name' and 'Optimal_fieldtype' to use UTF8,
    and 'Min_value' and 'Max_value' to inherit their charsets
    from the original items. But it is not important,
    and BINARY(N) is OK for now.
    4. Tests were fixed accordingly. No new tests were
    made, as the old onces cover everything.
    8cfe7296
item_cmpfunc.cc 63.6 KB