• Marko Mäkelä's avatar
    MDEV-11233 CREATE FULLTEXT INDEX with a token longer than 127 bytes · 9199d727
    Marko Mäkelä authored
    crashes server
    
    This bug is the result of merging the Oracle MySQL follow-up fix
    BUG#22963169 MYSQL CRASHES ON CREATE FULLTEXT INDEX
    without merging the base bug fix:
    Bug#79475 Insert a token of 84 4-bytes chars into fts index causes
    server crash.
    
    Unlike the above mentioned fixes in MySQL, our fix will not change
    the storage format of fulltext indexes in InnoDB or XtraDB
    when a character encoding with mbmaxlen=2 or mbmaxlen=3
    and the length of a word is between 128 and 84*mbmaxlen bytes.
    The Oracle fix would allocate 2 length bytes for these cases.
    
    Compatibility with other MySQL and MariaDB releases is ensured by
    persisting the used maximum length in the SYS_COLUMNS table in the
    InnoDB data dictionary.
    
    This fix also removes some unnecessary strcmp() calls when checking
    for the legacy default collation my_charset_latin1
    (my_charset_latin1.name=="latin1_swedish_ci").
    
    fts_create_one_index_table(): Store the actual length in bytes.
    This metadata will be written to the SYS_COLUMNS table.
    
    fts_zip_initialize(): Initialize only the first byte of the buffer.
    Actually the code should not even care about this first byte, because
    the length is set as 0.
    
    FTX_MAX_WORD_LEN: Define as HA_FT_MAXCHARLEN * 4 aka 336 bytes,
    not as 254 bytes.
    
    row_merge_create_fts_sort_index(): Set the actual maximum length of the
    column in bytes, similar to fts_create_one_index_table().
    
    row_merge_fts_doc_tokenize(): Remove the redundant parameter word_dtype.
    Use the actual maximum length of the column. Calculate the extra_size
    in the same way as row_merge_buf_encode() does.
    9199d727
fts0fts.h 32.3 KB