• Sergey Vojtovich's avatar
    Move XID_state::xa_state handing inside xa.cc · a168cfb3
    Sergey Vojtovich authored
    Let xid_cache_insert()/xid_cache_delete() handle xa_state.
    
    Let session tracker use is_explicit_XA() rather than xa_state != XA_NOTR.
    
    Fixed open_tables() to refuse data access in XA_ROLLBACK_ONLY state.
    
    Removed dead code from THD::cleanup(). It was supposed to be a reminder,
    but it got messed up over time.
    
    spider_internal_start_trx() is called either with XA_NOTR or XA_ACTIVE,
    which is guarded by server callers. Thus is_explicit_XA() is acceptable
    replacement for XA_ACTIVE check (which was likely wrong anyway).
    
    Setting xa_state to XA_PREPARED in spider_internal_xa_prepare() isn't
    meaningful, as this value is never accessed later. It can't be accessed
    by current thread and it can't be recovered either. It can only be
    accessed by spider internally, which never happens.
    
    Make spider_xa_lock()/spider_xa_unlock() static.
    
    Part of MDEV-7974 - backport fix for mysql bug#12161 (XA and binlog)
    a168cfb3
xa.cc 21.4 KB