• Marko Mäkelä's avatar
    MDEV-28689, MDEV-28690: Remove ctrl_mutex · b817afaa
    Marko Mäkelä authored
    This reverts the revert 4f62dfe6
    and fixes the hang that was introduced when ctrl_mutex was removed.
    
    The test mariabackup.compress_qpress covers this code, but the
    test is skipped if a stand-alone qpress executable is not available.
    It is not available in many software repositories, possibly because
    the code base has not been updated since 2010.
    
    This was tested with an executable that was compile from the source
    code at http://www.quicklz.com/qpress-11-source.zip (after adding
    a missing #include <unistd.h> for the definition of isatty()).
    
    Compared to the grandparent commit (before the revert), the changes
    are as follows:
    
    comp_thread_ctxt_t::done_cond: A separate condition for completed
    compression, signaling that thd->to_len has been updated.
    
    compress_write(): Replace some threads[i] with thd.
    Reset thd->to_len = 0 after consuming the compressed data.
    
    compress_worker_thread_func(): After consuming the uncompressed
    data, set thd->data_avail = FALSE. After compressing, signal
    thd->done_cond.
    b817afaa
ds_compress.cc 10.1 KB