• Michael Widenius's avatar
    Fixed compiler warnings found by gcc 4.3.2 · bd4e6551
    Michael Widenius authored
    - Added braces around expressions with &&, ||, & and |
    - Added empty line before ; for empty while and for loops
    - Added () around if with assignments
    - Removed const before function returning simple type
    
    Changed BUILD scripts to not build with NDB 
    
    
    BUILD/SETUP.sh:
      By default, don't build ndb with --max in Maria tree.
      NDB is not kept up to date anyway in 5.1
    client/mysql.cc:
      Added braces around && to get rid of compiler warnings
    sql/event_db_repository.cc:
      Added braces around && to get rid of compiler warnings
    sql/events.cc:
      Added braces around && to get rid of compiler warnings
    sql/field.cc:
      Added braces around && to get rid of compiler warnings
      Fixed for loops
    sql/field.h:
      Added braces around & to get rid of compiler warnings
    sql/field_conv.cc:
      Added braces around && to get rid of compiler warnings
      Fixed bug when copying between DATETIME fields and strict dates are used
      Removed not needeed else
    sql/gstream.cc:
      Added braces around && to get rid of compiler warnings
    sql/ha_ndbcluster.cc:
      Added braces around && to get rid of compiler warnings
      Added {} to get rid of compiler warnings
    sql/handler.cc:
      Added braces around && to get rid of compiler warnings
    sql/item.cc:
      Added braces around && to get rid of compiler warnings
    sql/item_cmpfunc.cc:
      Added braces around && to get rid of compiler warnings
      Removed some not needed space
    sql/item_func.cc:
      Added braces around && to get rid of compiler warnings
    sql/item_strfunc.cc:
      Added braces around && to get rid of compiler warnings
    sql/item_subselect.cc:
      Added braces around && to get rid of compiler warnings
    sql/item_sum.cc:
      Added braces around && to get rid of compiler warnings
    sql/item_timefunc.cc:
      Added braces around && to get rid of compiler warnings
    sql/item_xmlfunc.cc:
      Added empty line before ; for empty while and for loops
    sql/log.cc:
      Added braces around && to get rid of compiler warnings
    sql/log_event.cc:
      Added braces around && to get rid of compiler warnings
      Removed not needed else
    sql/log_event_old.cc:
      Added braces around && to get rid of compiler warnings
    sql/opt_range.cc:
      Added braces around && to get rid of compiler warnings
    sql/opt_sum.cc:
      Added braces around && to get rid of compiler warnings
    sql/set_var.cc:
      Added empty line before ; for empty while and for loops
      Added () around if with assignments
    sql/slave.cc:
      Added braces around && to get rid of compiler warnings
      Added empty line before ; for empty while and for loops
    sql/spatial.h:
      Added braces around && to get rid of compiler warnings
    sql/sql_acl.cc:
      Added braces around && to get rid of compiler warnings
    sql/sql_analyse.cc:
      Added empty line before ; for empty while and for loops
    sql/sql_base.cc:
      Added braces around && to get rid of compiler warnings
    sql/sql_connect.cc:
      Added braces around && to get rid of compiler warnings
    sql/sql_db.cc:
      Added braces around && to get rid of compiler warnings
    sql/sql_delete.cc:
      Added braces around && to get rid of compiler warnings
    sql/sql_help.cc:
      Added empty line before ; for empty while and for loops
    sql/sql_insert.cc:
      Added braces around && to get rid of compiler warnings
      Added () around if with assignments
    sql/sql_lex.cc:
      Cast char array references to uchar; Fixed wrong array referencing when using characters > ASCII 128 in SQL statments
      Added empty line before ; for empty while and for loops
      Trivial indent fixes
      Added braces around && to get rid of compiler warnings
    sql/sql_load.cc:
      Added braces around && to get rid of compiler warnings
    sql/sql_parse.cc:
      Added braces around && to get rid of compiler warnings
    sql/sql_partition.cc:
      Added braces around && to get rid of compiler warnings
    sql/sql_plugin.cc:
      Fixed bug in detecing if option variable should be readonly
      Added empty line before ; for empty while and for loops
    sql/sql_prepare.cc:
      Added braces around && to get rid of compiler warnings
    sql/sql_select.cc:
      Added braces around && to get rid of compiler warnings
      Added () around if with assignments
      Added empty line before ; for empty while and for loops
    sql/sql_show.cc:
      Added braces around && to get rid of compiler warnings
    sql/sql_table.cc:
      Added braces around && to get rid of compiler warnings
    sql/sql_trigger.cc:
      Added braces around && to get rid of compiler warnings
    sql/sql_update.cc:
      Added braces around && to get rid of compiler warnings
    sql/sql_yacc.yy:
      Added braces around && to get rid of compiler warnings
    sql/table.cc:
      Added braces around && to get rid of compiler warnings
    sql/table.h:
      Added braces around && to get rid of compiler warnings
    sql/time.cc:
      Added braces around && to get rid of compiler warnings
    sql/tztime.cc:
      Added braces around && to get rid of compiler warnings
    sql/uniques.cc:
      Added braces around && to get rid of compiler warnings
    storage/federated/ha_federated.cc:
      Fixed bug in testing of variable to ha_info() (Not critical)
    storage/heap/ha_heap.cc:
      Added braces around && to get rid of compiler warnings
    storage/maria/ha_maria.cc:
      Fixed bug: Mark that maria_log_dir_path is readonly
      Added braces around && to get rid of compiler warnings
    storage/ndb/include/ndbapi/NdbEventOperation.hpp:
      Removed const before function returning simple type
    storage/ndb/include/ndbapi/NdbOperation.hpp:
      Removed const before function returning simple type
    storage/ndb/src/ndbapi/Ndb.cpp:
      Added empty line before ; for empty while and for loops
    storage/ndb/src/ndbapi/NdbEventOperation.cpp:
      Removed const before function returning simple type
    storage/ndb/src/ndbapi/NdbEventOperationImpl.cpp:
      Removed const before function returning simple type
    storage/ndb/src/ndbapi/NdbEventOperationImpl.hpp:
      Removed const before function returning simple type
    storage/ndb/src/ndbapi/NdbRecAttr.cpp:
      Added empty line before ; for empty while and for loops
    storage/ndb/src/ndbapi/TransporterFacade.hpp:
      Added braces around && to get rid of compiler warnings
    bd4e6551
sql_insert.cc 125 KB