• Alexander Barkov's avatar
    MDEV-14467 Item_param: replace {INT|DECIMAL|REAL|STRING|TIME}_VALUE with Type_handler · e01d33d7
    Alexander Barkov authored
    1. Removing data type specific constants from enum_item_param_state,
       adding SHORT_DATA_VALUE instead.
    2. Replacing tests for Item_param::state for the removed constants to
       tests for Type_handler::cmp_type() against {INT|REAL|TIME|DECIAML}_RESULT.
       Deriving Item_param::PValue from Type_handler_hybrid_field_type,
       to store the data type handler of the current value of the parameter.
    
    3. Moving Item_param::decimal_value and Item_param::str_value_ptr
       to Item_param::PValue. Adding Item_param::PValue::m_string
       and changing Item_param to use it to store string values,
       instead of Item::str_value. The intent is to replace Item_param::value
       to a st_value based implementation in the future, to avoid duplicate code.
       Adding a sub-class Item::PValue_simple, to implement
       Item_param::PValue::swap() easier.
       Remaming Item_basic_value::fix_charset_and_length_from_str_value()
       to fix_charset_and_length() and adding the "CHARSET_INFO" pointer
       parameter, instead of getting it directly from item->str_value.charset().
       Changing Item_param to pass value.m_string.charset() instead
       of str_value.charset().
       Adding a String argument to the overloaded
       fix_charset_and_length_from_str_value() and changing Item_param
       to pass value.m_string instead of str_value.
    
    4. Replacing the case in Item_param::save_in_field() to a call
       for Type_handler::Item_save_in_field().
    
    5. Adding new methods into Item_param::PValue:
       val_real(), val_int(), val_decimal(), val_str().
       Changing the corresponding Item_param methods
       to use these new Item_param::PValue methods
       internally. Adding a helper method
       Item_param::can_return_value() and removing
       duplicate code in Item_param::val_xxx().
    
    6. Removing value.set_handler() from Item_param::set_conversion()
       and Type_handler_xxx::Item_param_set_from_value().
       It's now done inside Item_param::set_param_func(),
       Item_param::set_value() and Item_param::set_limit_clause_param().
    
    7. Changing Type_handler_int_result::Item_param_set_from_value()
       to set max_length using attr->max_length instead of
       MY_INT64_NUM_DECIMAL_DIGITS, to preserve the data type
       of the assigned expression more precisely.
    
    8. Adding Type_handler_hybrid_field_type::swap(),
       using it in Item_param::PValue::swap().
    
    9. Moving the data-type specific code from
       Item_param::query_val_str(), Item_param::eq(),
       Item_param::clone_item() to
       Item_param::value_query_type_str(),
       Item_param::value_eq(), Item_param::value_clone_item(),
       to split the "state" dependent code and
       the data type dependent code.
       Later we'll split the data type related code further
       and add new methods in Type_handler. This will be done
       after we replace Item_param::PValue to st_value.
    
    10. Adding asserts into set_int(), set_double(), set_decimal(),
       set_time(), set_str(), set_longdata() to make sure that
       the value set to Item_param corresponds to the previously
       set data type handler.
    
    11. Adding tests into t/ps.test and suite/binlog/t/binlog_stm_ps.test,
       to cover Item_param::print() and Item_param::append_for_log()
       for LIMIT clause parameters.
       Note, the patch does not change the behavior covered by the new
       tests. Adding for better code coverage.
    
    12. Adding tests for more precise integer data type in queries like this:
        EXECUTE IMMEDIATE
         'CREATE OR REPLACE TABLE t1 AS SELECT 999999999 AS a,? AS b'
          USING 999999999;
        The explicit integer literal and the same integer literal
        passed as a PS parameter now produce columns of the same data type.
        Re-recording old results in ps.result, gis.result, func_hybrid_type.result
        accordingly.
    e01d33d7
gis.result 175 KB