• unknown's avatar
    Fix for server bug experienced in Maria (wrong "Truncated incorrect <var_name> · e2103aaf
    unknown authored
    value" error even though the value was correct): a C function in my_getopt.c
    was taking bool* in parameter and was called from C++ sql_plugin.cc,
    but on some Mac OS X sizeof(bool) is 1 in C and 4 in C++, giving funny
    mismatches. Fixed, all other occurences of bool in C are removed, future
    ones are blocked by a "C-bool-catcher" in my_global.h (use my_bool).
    
    
    client/mysqldump.c:
      my_bool for C
    client/mysqltest.c:
      my_bool for C
    extra/replace.c:
      my_bool for C
    include/my_getopt.h:
      my_bool for C
    include/my_global.h:
      Prevent people from using bool in C, it causes real bugs.
    include/my_sys.h:
      my_bool for C
    include/my_time.h:
      my_bool for C
    include/thr_lock.h:
      my_bool for C
    libmysql/libmysql.c:
      my_bool for C
    mysys/charset.c:
      my_bool for C
    mysys/my_getopt.c:
      my_bool for C
    mysys/queues.c:
      my_bool for C
    mysys/thr_lock.c:
      my_bool for C
    regex/reginit.c:
      my_bool for C
    sql/set_var.cc:
      C functions use my_bool so we must use my_bool too.
    sql/sql_plugin.cc:
      C functions use my_bool so we must use my_bool too.
      This fixes a real observed bug of Maria, because on some Mac OS X,
      sizeof(bool) is 1 in C and 4 in C++, so the bool* does wrong.
      Removing useless line.
    storage/heap/hp_update.c:
      my_bool for C
    storage/myisam/mi_check.c:
      my_bool for C
    storage/myisam/mi_dynrec.c:
      my_bool for C
    storage/myisam/mi_search.c:
      my_bool for C
    storage/myisam/mi_update.c:
      my_bool for C
    storage/myisam/mi_write.c:
      my_bool for C
    storage/myisam/myisamdef.h:
      my_bool for C
    storage/myisam/myisamlog.c:
      my_bool for C
    storage/myisam/myisampack.c:
      my_bool for C
    tests/mysql_client_test.c:
      my_bool for C
    unittest/mysys/bitmap-t.c:
      my_bool for C
    vio/viosslfactories.c:
      my_bool for C
    e2103aaf
my_getopt.c 34.7 KB