• Davi Arnaut's avatar
    Bug#42054: SELECT CURDATE() is returning bad value · eb589393
    Davi Arnaut authored
    The problem from a user point of view was that on Solaris the
    time related functions (e.g. NOW(), SYSDATE(), etc) would always
    return a fixed time.
    
    This bug was happening due to a logic in the time retrieving
    wrapper function which would only call the time() function every
    half second. This interval between calls would be calculated
    using the gethrtime() and the logic relied on the fact that time
    returned by it is monotonic.
    
    Unfortunately, due to bugs in the gethrtime() implementation,
    there are some cases where the time returned by it can drift
    (See Solaris bug id 6600939), potentially causing the interval
    calculation logic to fail.
    
    Since newer versions of Solaris (10+) have alleviated the
    performance degradation associated with time(2), the solution is
    to simply directly rely on time() at each invocation.
    
    This simplification has an upside that it allows us to eliminate
    a lock which was used to control access to the variables used
    to track the half second interval, thus improving the overall
    scalability of timekeeping related functions (e.g. NOW()).
    
    Benchmarks runs have shown no significant degradation associated
    with this change. With this, there are actually improvements in
    performance for cases involving many connections.
    
    In summary, the changes introduced by this patch are:
    
    a) my_time() and my_micro_time_and_time() no longer use gethrtime().
       Instead, time() and gettimeofdate() are used correspondingly.
    
    b) my_micro_time() is changed to not use gethrtime() so as to
       have the same time source as my_micro_time_and_time().
       There shouldn't be any performance impact from this change
       since this function is used only a few times during statement
       execution and, on Solaris, gettimeofday() shows acceptable
       performance.
    
    mysys/my_getsystime.c:
      Use time() even if gethrtime() is available. Remove logic which
      relied on gethrtime() to only call time() every half second.
      Since gethrtime() is not used anymore, also remove it from
      my_micro_time() to keep a common time source.
      
      Also, function comments are cleaned up (fixed typos and wrong
      information) and converted to doxygen.
    mysys/my_thr_init.c:
      Remove mutex which is no longer used.
    mysys/mysys_priv.h:
      Remove mutex which is no longer used.
    eb589393
mysys_priv.h 3.9 KB