• Marko Mäkelä's avatar
    MDEV-21907: InnoDB: Enable -Wconversion on clang and GCC · f2245252
    Marko Mäkelä authored
    The -Wconversion in GCC seems to be stricter than in clang.
    GCC at least since version 4.4.7 issues truncation warnings for
    assignments to bitfields, while clang 10 appears to only issue
    warnings when the sizes in bytes rounded to the nearest integer
    powers of 2 are different.
    
    Before GCC 10.0.0, -Wconversion required more casts and would not
    allow some operations, such as x<<=1 or x+=1 on a data type that
    is narrower than int.
    
    GCC 5 (but not GCC 4, GCC 6, or any later version) is complaining
    about x|=y even when x and y are compatible types that are narrower
    than int.  Hence, we must rewrite some x|=y as
    x=static_cast<byte>(x|y) or similar, or we must disable -Wconversion.
    
    In GCC 6 and later, the warning for assigning wider to bitfields
    that are narrower than 8, 16, or 32 bits can be suppressed by
    applying a bitwise & with the exact bitmask of the bitfield.
    For older GCC, we must disable -Wconversion for GCC 4 or 5 in such
    cases.
    
    The bitwise negation operator appears to promote short integers
    to a wider type, and hence we must add explicit truncation casts
    around them. Microsoft Visual C does not allow a static_cast to
    truncate a constant, such as static_cast<byte>(1) truncating int.
    Hence, we will use the constructor-style cast byte(~1) for such cases.
    
    This has been tested at least with GCC 4.8.5, 5.4.0, 7.4.0, 9.2.1, 10.0.0,
    clang 9.0.1, 10.0.0, and MSVC 14.22.27905 (Microsoft Visual Studio 2019)
    on 64-bit and 32-bit targets (IA-32, AMD64, POWER 8, POWER 9, ARMv8).
    f2245252
btr0sea.cc 53.7 KB