Commit 09c5c335 authored by Marko Mäkelä's avatar Marko Mäkelä

Follow-up to MDEV-13690: Remove unused globals

buf_flush_batch(), buf_flush_stats(): Declare static.

buf_flush_common(): Remove (unused function).
parent 6ec3de5d
...@@ -1870,6 +1870,7 @@ not guaranteed that the actual number is that big, though) ...@@ -1870,6 +1870,7 @@ not guaranteed that the actual number is that big, though)
@param[in] lsn_limit in the case of BUF_FLUSH_LIST all blocks whose @param[in] lsn_limit in the case of BUF_FLUSH_LIST all blocks whose
oldest_modification is smaller than this should be flushed (if their number oldest_modification is smaller than this should be flushed (if their number
does not exceed min_n), otherwise ignored */ does not exceed min_n), otherwise ignored */
static
void void
buf_flush_batch( buf_flush_batch(
buf_pool_t* buf_pool, buf_pool_t* buf_pool,
...@@ -1909,6 +1910,7 @@ Gather the aggregated stats for both flush list and LRU list flushing. ...@@ -1909,6 +1910,7 @@ Gather the aggregated stats for both flush list and LRU list flushing.
@param page_count_flush number of pages flushed from the end of the flush_list @param page_count_flush number of pages flushed from the end of the flush_list
@param page_count_LRU number of pages flushed from the end of the LRU list @param page_count_LRU number of pages flushed from the end of the LRU list
*/ */
static
void void
buf_flush_stats( buf_flush_stats(
/*============*/ /*============*/
...@@ -1925,6 +1927,7 @@ buf_flush_stats( ...@@ -1925,6 +1927,7 @@ buf_flush_stats(
/******************************************************************//** /******************************************************************//**
Start a buffer flush batch for LRU or flush list */ Start a buffer flush batch for LRU or flush list */
static
ibool ibool
buf_flush_start( buf_flush_start(
/*============*/ /*============*/
...@@ -1955,23 +1958,9 @@ buf_flush_start( ...@@ -1955,23 +1958,9 @@ buf_flush_start(
return(TRUE); return(TRUE);
} }
/******************************************************************//**
Gather the aggregated stats for both flush list and LRU list flushing */
void
buf_flush_common(
/*=============*/
buf_flush_t flush_type, /*!< in: type of flush */
ulint page_count) /*!< in: number of pages flushed */
{
buf_dblwr_flush_buffered_writes();
ut_a(flush_type == BUF_FLUSH_LRU || flush_type == BUF_FLUSH_LIST);
srv_stats.buf_pool_flushed.add(page_count);
}
/******************************************************************//** /******************************************************************//**
End a buffer flush batch for LRU or flush list */ End a buffer flush batch for LRU or flush list */
static
void void
buf_flush_end( buf_flush_end(
/*==========*/ /*==========*/
......
/***************************************************************************** /*****************************************************************************
Copyright (c) 1995, 2016, Oracle and/or its affiliates. All Rights Reserved. Copyright (c) 1995, 2016, Oracle and/or its affiliates. All Rights Reserved.
Copyright (c) 2014, 2017, MariaDB Corporation. Copyright (c) 2014, 2018, MariaDB Corporation.
This program is free software; you can redistribute it and/or modify it under This program is free software; you can redistribute it and/or modify it under
the terms of the GNU General Public License as published by the Free Software the terms of the GNU General Public License as published by the Free Software
...@@ -424,57 +424,6 @@ class FlushObserver { ...@@ -424,57 +424,6 @@ class FlushObserver {
bool m_interrupted; bool m_interrupted;
}; };
/******************************************************************//**
Start a buffer flush batch for LRU or flush list */
ibool
buf_flush_start(
/*============*/
buf_pool_t* buf_pool, /*!< buffer pool instance */
buf_flush_t flush_type); /*!< in: BUF_FLUSH_LRU
or BUF_FLUSH_LIST */
/******************************************************************//**
End a buffer flush batch for LRU or flush list */
void
buf_flush_end(
/*==========*/
buf_pool_t* buf_pool, /*!< buffer pool instance */
buf_flush_t flush_type); /*!< in: BUF_FLUSH_LRU
or BUF_FLUSH_LIST */
/******************************************************************//**
Gather the aggregated stats for both flush list and LRU list flushing */
void
buf_flush_common(
/*=============*/
buf_flush_t flush_type, /*!< in: type of flush */
ulint page_count); /*!< in: number of pages flushed */
/*******************************************************************//**
This utility flushes dirty blocks from the end of the LRU list or flush_list.
NOTE 1: in the case of an LRU flush the calling thread may own latches to
pages: to avoid deadlocks, this function must be written so that it cannot
end up waiting for these latches! NOTE 2: in the case of a flush list flush,
the calling thread is not allowed to own any latches on pages! */
__attribute__((nonnull))
void
buf_flush_batch(
/*============*/
buf_pool_t* buf_pool, /*!< in: buffer pool instance */
buf_flush_t flush_type, /*!< in: BUF_FLUSH_LRU or
BUF_FLUSH_LIST; if BUF_FLUSH_LIST,
then the caller must not own any
latches on pages */
ulint min_n, /*!< in: wished minimum mumber of blocks
flushed (it is not guaranteed that the
actual number is that big, though) */
lsn_t lsn_limit, /*!< in: in the case of BUF_FLUSH_LIST
all blocks whose oldest_modification is
smaller than this should be flushed
(if their number does not exceed
min_n), otherwise ignored */
flush_counters_t* n); /*!< out: flushed/evicted page
counts */
#include "buf0flu.ic" #include "buf0flu.ic"
#endif #endif
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment