Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
M
MariaDB
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
nexedi
MariaDB
Commits
18e6090c
Commit
18e6090c
authored
May 11, 2007
by
unknown
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Bug#25818 No return of NDB share object in failures in open method
- make sure resources are release properly on error
parent
28d9a827
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
18 additions
and
9 deletions
+18
-9
sql/ha_ndbcluster.cc
sql/ha_ndbcluster.cc
+18
-9
No files found.
sql/ha_ndbcluster.cc
View file @
18e6090c
...
@@ -5011,27 +5011,36 @@ int ha_ndbcluster::open(const char *name, int mode, uint test_if_locked)
...
@@ -5011,27 +5011,36 @@ int ha_ndbcluster::open(const char *name, int mode, uint test_if_locked)
set_dbname
(
name
);
set_dbname
(
name
);
set_tabname
(
name
);
set_tabname
(
name
);
if
(
check_ndb_connection
())
{
if
((
res
=
check_ndb_connection
())
||
free_share
(
m_share
);
m_share
=
0
;
(
res
=
get_metadata
(
name
)))
DBUG_RETURN
(
HA_ERR_NO_CONNECTION
);
{
free_share
(
m_share
);
m_share
=
0
;
DBUG_RETURN
(
res
);
}
}
while
(
1
)
res
=
get_metadata
(
name
);
if
(
!
res
)
{
{
Ndb
*
ndb
=
get_ndb
();
Ndb
*
ndb
=
get_ndb
();
if
(
ndb
->
setDatabaseName
(
m_dbname
))
if
(
ndb
->
setDatabaseName
(
m_dbname
))
{
{
ERR_RETURN
(
ndb
->
getNdbError
());
res
=
ndb_to_mysql_error
(
&
ndb
->
getNdbError
());
break
;
}
}
struct
Ndb_statistics
stat
;
struct
Ndb_statistics
stat
;
res
=
ndb_get_table_statistics
(
NULL
,
false
,
ndb
,
m_tabname
,
&
stat
);
res
=
ndb_get_table_statistics
(
NULL
,
false
,
ndb
,
m_tabname
,
&
stat
);
records
=
stat
.
row_count
;
records
=
stat
.
row_count
;
if
(
!
res
)
if
(
!
res
)
res
=
info
(
HA_STATUS_CONST
);
res
=
info
(
HA_STATUS_CONST
);
break
;
}
}
if
(
res
)
DBUG_RETURN
(
res
);
{
free_share
(
m_share
);
m_share
=
0
;
release_metadata
();
DBUG_RETURN
(
res
);
}
DBUG_RETURN
(
0
);
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment