Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
M
MariaDB
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
nexedi
MariaDB
Commits
350903e9
Commit
350903e9
authored
Mar 16, 2016
by
Vicențiu Ciorbaru
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove no longer needed TODO.
parent
333ac13b
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
0 additions
and
7 deletions
+0
-7
sql/sql_window.cc
sql/sql_window.cc
+0
-7
No files found.
sql/sql_window.cc
View file @
350903e9
...
...
@@ -1261,13 +1261,6 @@ bool compute_window_func_with_frames(Item_window_func *item_win,
*/
tbl
->
file
->
ha_rnd_pos
(
tbl
->
record
[
0
],
rowid_buf
);
store_record
(
tbl
,
record
[
1
]);
// TODO-cvicentiu
// Save in field does not make use of the null value for the sum function.
// If we do however set the null value to be the same as the one that
// the current sum function has, via say
// item_win->null_value = sum_func->null_value; we get an assertion failure
// during the sending of data within Item::send, in the case of DECIMAL_RESULT.
// How do we force saving of NULL values in the table?
item_win
->
save_in_field
(
item_win
->
result_field
,
true
);
err
=
tbl
->
file
->
ha_update_row
(
tbl
->
record
[
1
],
tbl
->
record
[
0
]);
if
(
err
&&
err
!=
HA_ERR_RECORD_IS_THE_SAME
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment