Skip to content

M
MariaDB
Commit 352d27ce authored by Jan Lindström's avatar Jan Lindström
Browse files
Options

MDEV-13557: Startup failure, unable to decrypt ibdata1 

Fixes also MDEV-13488: InnoDB writes CRYPT_INFO even though
encryption is not enabled.

Problem was that we created encryption metadata (crypt_data) for
system tablespace even when no encryption was enabled and too early.
System tablespace can be encrypted only using key rotation.

Test innodb-key-rotation-disable, innodb_encryption, innodb_lotoftables
require adjustment because INFORMATION_SCHEMA INNODB_TABLESPACES_ENCRYPTION
contain row only if tablespace really has encryption metadata.

fil_crypt_set_thread_cnt: Send message to background encryption threads
if they exits when they are ready. This is required to find tablespaces
requiring key rotation if no other changes happen.

fil_crypt_find_space_to_rotate: Decrease the amount of time waiting
when nothing happens to better enable key rotation on startup.

fsp_header_init: Write encryption metadata to page 0 only if tablespace is
encrypted or encryption is disabled by table option.

i_s_dict_fill_tablespaces_encryption : Skip tablespaces that do not
contain encryption metadata. This is required to avoid too early
wait condition trigger in encrypted -> unencrypted state transfer.

open_or_create_data_files: Do not create encryption metadata
by default to system tablespace.
parent dda40b93
Expand all Hide whitespace changes
Inline Side-by-side
Showing with 1327 additions and 345 deletions
mysql-test/suite/encryption/r/innodb-first-page-read.result
View file @ 352d27ce
SET GLOBAL innodb_file_format = `Barracuda`; SET GLOBAL innodb_file_format = `Barracuda`;
SET GLOBAL innodb_file_per_table = ON; SET GLOBAL innodb_file_per_table = ON;
FLUSH STATUS;
create database innodb_test; create database innodb_test;
use innodb_test; use innodb_test;
create table innodb_normal(c1 bigint not null, b char(200)) engine=innodb; create table innodb_normal(c1 bigint not null, b char(200)) engine=innodb;
...@@ -50,40 +51,48 @@ insert into innodb_datadir1 select * from innodb_normal; ...@@ -50,40 +51,48 @@ insert into innodb_datadir1 select * from innodb_normal;
insert into innodb_datadir2 select * from innodb_normal; insert into innodb_datadir2 select * from innodb_normal;
insert into innodb_datadir3 select * from innodb_normal; insert into innodb_datadir3 select * from innodb_normal;
commit; commit;
FLUSH STATUS;
# Restart server and see how many page 0's are read # Restart server and see how many page 0's are read
# result should be less than actual number of tables # result should actual number of tables except remote tables could be read twice
# i.e. < 23 + 3 = 26 # i.e. < 23 + 3*2 = 29
show status like 'innodb_pages0_read%'; SELECT VARIABLE_VALUE <= 29 FROM INFORMATION_SCHEMA.GLOBAL_STATUS WHERE VARIABLE_NAME = 'innodb_pages0_read';
Variable_name Value VARIABLE_VALUE <= 29
Innodb_pages0_read 19 1
use innodb_test; use innodb_test;
show status like 'innodb_pages0_read%'; SELECT VARIABLE_VALUE <= 29 FROM INFORMATION_SCHEMA.GLOBAL_STATUS WHERE VARIABLE_NAME = 'innodb_pages0_read';
Variable_name Value VARIABLE_VALUE <= 29
Innodb_pages0_read 19 1
use test; use test;
show status like 'innodb_pages0_read%'; SELECT VARIABLE_VALUE <= 29 FROM INFORMATION_SCHEMA.GLOBAL_STATUS WHERE VARIABLE_NAME = 'innodb_pages0_read';
Variable_name Value VARIABLE_VALUE <= 29
Innodb_pages0_read 19 1
set global innodb_encrypt_tables=OFF; set global innodb_encrypt_tables=OFF;
# wait until tables are decrypted # wait until tables are decrypted
show status like 'innodb_pages0_read%'; # result should be actual number of tables except remote tables could be read twice
Variable_name Value # i.e. < 23 + 3*2 = 29
Innodb_pages0_read 29 SELECT VARIABLE_VALUE <= 29 FROM INFORMATION_SCHEMA.GLOBAL_STATUS WHERE VARIABLE_NAME = 'innodb_pages0_read';
VARIABLE_VALUE <= 29
1
use innodb_test; use innodb_test;
show status like 'innodb_pages0_read%'; SELECT VARIABLE_VALUE <= 29 FROM INFORMATION_SCHEMA.GLOBAL_STATUS WHERE VARIABLE_NAME = 'innodb_pages0_read';
Variable_name Value VARIABLE_VALUE <= 29
Innodb_pages0_read 29 1
use test; use test;
SELECT VARIABLE_VALUE <= 29 FROM INFORMATION_SCHEMA.GLOBAL_STATUS WHERE VARIABLE_NAME = 'innodb_pages0_read';
VARIABLE_VALUE <= 29
1
FLUSH STATUS;
# restart and see number read page 0 # restart and see number read page 0
show status like 'innodb_pages0_read%'; SELECT VARIABLE_VALUE <= 29 FROM INFORMATION_SCHEMA.GLOBAL_STATUS WHERE VARIABLE_NAME = 'innodb_pages0_read';
Variable_name Value VARIABLE_VALUE <= 29
Innodb_pages0_read 19 1
use innodb_test; use innodb_test;
show status like 'innodb_pages0_read%'; SELECT VARIABLE_VALUE <= 29 FROM INFORMATION_SCHEMA.GLOBAL_STATUS WHERE VARIABLE_NAME = 'innodb_pages0_read';
Variable_name Value VARIABLE_VALUE <= 29
Innodb_pages0_read 19 1
use test; use test;
SELECT VARIABLE_VALUE <= 29 FROM INFORMATION_SCHEMA.GLOBAL_STATUS WHERE VARIABLE_NAME = 'innodb_pages0_read';
VARIABLE_VALUE <= 29
1
drop database innodb_test; drop database innodb_test;
show status like 'innodb_pages0_read%'; FLUSH STATUS;
Variable_name Value
Innodb_pages0_read 29
mysql-test/suite/encryption/r/innodb-key-rotation-disable.result
View file @ 352d27ce
...@@ -2,9 +2,6 @@ SELECT NAME FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_ ...@@ -2,9 +2,6 @@ SELECT NAME FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_
NAME NAME
SELECT NAME FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION = 0; SELECT NAME FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION = 0;
NAME NAME
mysql/innodb_table_stats
mysql/innodb_index_stats
./ibdata1
create database enctests; create database enctests;
use enctests; use enctests;
create table t1(a int not null primary key, b char(200)) engine=innodb; create table t1(a int not null primary key, b char(200)) engine=innodb;
......
mysql-test/suite/encryption/r/innodb_encryption.result
View file @ 352d27ce
...@@ -8,25 +8,22 @@ innodb_encrypt_tables ON ...@@ -8,25 +8,22 @@ innodb_encrypt_tables ON
innodb_encryption_rotate_key_age 15 innodb_encryption_rotate_key_age 15
innodb_encryption_rotation_iops 100 innodb_encryption_rotation_iops 100
innodb_encryption_threads 4 innodb_encryption_threads 4
DESCRIBE INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION; SET GLOBAL innodb_encrypt_tables = ON;
Field Type Null Key Default Extra # Wait max 10 min for key encryption threads to encrypt all spaces
SPACE int(11) unsigned NO 0 SELECT NAME FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION = 0;
NAME varchar(655) YES NULL NAME
ENCRYPTION_SCHEME int(11) unsigned NO 0 SELECT NAME FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION <> 0;
KEYSERVER_REQUESTS int(11) unsigned NO 0 NAME
MIN_KEY_VERSION int(11) unsigned NO 0 ./ibdata1
CURRENT_KEY_VERSION int(11) unsigned NO 0
KEY_ROTATION_PAGE_NUMBER bigint(21) unsigned YES NULL
KEY_ROTATION_MAX_PAGE_NUMBER bigint(21) unsigned YES NULL
CURRENT_KEY_ID int(11) unsigned NO 0
ROTATING_OR_FLUSHING int(1) unsigned NO 0
# Wait max 5 min for key encryption threads to encrypt one space
# Success!
# Wait max 10 min for key encryption threads to encrypt all space
# Success! # Success!
# Now turn off encryption and wait for threads to decrypt everything # Now turn off encryption and wait for threads to decrypt everything
SET GLOBAL innodb_encrypt_tables = off; SET GLOBAL innodb_encrypt_tables = off;
# Wait max 10 min for key encryption threads to decrypt all space # Wait max 10 min for key encryption threads to encrypt all spaces
SELECT NAME FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION = 0;
NAME
./ibdata1
SELECT NAME FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION <> 0;
NAME
# Success! # Success!
# Shutdown innodb_encryption_threads # Shutdown innodb_encryption_threads
SET GLOBAL innodb_encryption_threads=0; SET GLOBAL innodb_encryption_threads=0;
...@@ -34,16 +31,20 @@ SET GLOBAL innodb_encryption_threads=0; ...@@ -34,16 +31,20 @@ SET GLOBAL innodb_encryption_threads=0;
# since threads are off tables should remain unencrypted # since threads are off tables should remain unencrypted
SET GLOBAL innodb_encrypt_tables = on; SET GLOBAL innodb_encrypt_tables = on;
# Wait 15s to check that nothing gets encrypted # Wait 15s to check that nothing gets encrypted
SELECT NAME FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION = 0;
NAME
./ibdata1
SELECT NAME FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION <> 0;
NAME
# Success! # Success!
# Startup innodb_encryption_threads # Startup innodb_encryption_threads
SET GLOBAL innodb_encryption_threads=@start_global_value; SET GLOBAL innodb_encryption_threads=@start_global_value;
# Wait 1 min to check that it start encrypting again # Wait max 10 min for key encryption threads to encrypt all spaces
# Success! SELECT NAME FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION = 0;
# NAME
# Check that restart with encryption turned off works SELECT NAME FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION <> 0;
# even if spaces are encrypted NAME
# ./ibdata1
# First wait max 10 min for key encryption threads to encrypt all spaces
# Success! # Success!
# Restart mysqld --innodb_encrypt_tables=0 --innodb_encryption_threads=0 # Restart mysqld --innodb_encrypt_tables=0 --innodb_encryption_threads=0
SHOW VARIABLES LIKE 'innodb_encrypt%'; SHOW VARIABLES LIKE 'innodb_encrypt%';
...@@ -53,9 +54,8 @@ innodb_encrypt_tables OFF ...@@ -53,9 +54,8 @@ innodb_encrypt_tables OFF
innodb_encryption_rotate_key_age 15 innodb_encryption_rotate_key_age 15
innodb_encryption_rotation_iops 100 innodb_encryption_rotation_iops 100
innodb_encryption_threads 0 innodb_encryption_threads 0
SELECT COUNT(*) > 0 as should_be_1 SELECT NAME FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION <> 0;
FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION NAME
WHERE MIN_KEY_VERSION <> 0; ./ibdata1
should_be_1 SELECT NAME FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION = 0;
1 NAME
# Restart mysqld again...with default options
mysql-test/suite/encryption/t/innodb-first-page-read.test
View file @ 352d27ce
...@@ -7,6 +7,8 @@ SET GLOBAL innodb_file_format = `Barracuda`; ...@@ -7,6 +7,8 @@ SET GLOBAL innodb_file_format = `Barracuda`;
SET GLOBAL innodb_file_per_table = ON; SET GLOBAL innodb_file_per_table = ON;
--enable_warnings --enable_warnings
FLUSH STATUS;
create database innodb_test; create database innodb_test;
use innodb_test; use innodb_test;
create table innodb_normal(c1 bigint not null, b char(200)) engine=innodb; create table innodb_normal(c1 bigint not null, b char(200)) engine=innodb;
...@@ -63,16 +65,19 @@ insert into innodb_datadir2 select * from innodb_normal; ...@@ -63,16 +65,19 @@ insert into innodb_datadir2 select * from innodb_normal;
insert into innodb_datadir3 select * from innodb_normal; insert into innodb_datadir3 select * from innodb_normal;
commit; commit;
FLUSH STATUS;
--echo # Restart server and see how many page 0's are read --echo # Restart server and see how many page 0's are read
--source include/restart_mysqld.inc --source include/restart_mysqld.inc
--echo # result should be less than actual number of tables --echo # result should actual number of tables except remote tables could be read twice
--echo # i.e. < 23 + 3 = 26 --echo # i.e. < 23 + 3*2 = 29
show status like 'innodb_pages0_read%';
SELECT VARIABLE_VALUE <= 29 FROM INFORMATION_SCHEMA.GLOBAL_STATUS WHERE VARIABLE_NAME = 'innodb_pages0_read';
use innodb_test; use innodb_test;
show status like 'innodb_pages0_read%'; SELECT VARIABLE_VALUE <= 29 FROM INFORMATION_SCHEMA.GLOBAL_STATUS WHERE VARIABLE_NAME = 'innodb_pages0_read';
use test; use test;
show status like 'innodb_pages0_read%'; SELECT VARIABLE_VALUE <= 29 FROM INFORMATION_SCHEMA.GLOBAL_STATUS WHERE VARIABLE_NAME = 'innodb_pages0_read';
set global innodb_encrypt_tables=OFF; set global innodb_encrypt_tables=OFF;
...@@ -80,18 +85,25 @@ set global innodb_encrypt_tables=OFF; ...@@ -80,18 +85,25 @@ set global innodb_encrypt_tables=OFF;
--let $wait_condition=SELECT COUNT(*) = 0 FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION <> 0 --let $wait_condition=SELECT COUNT(*) = 0 FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION <> 0
--source include/wait_condition.inc --source include/wait_condition.inc
show status like 'innodb_pages0_read%'; --echo # result should be actual number of tables except remote tables could be read twice
--echo # i.e. < 23 + 3*2 = 29
SELECT VARIABLE_VALUE <= 29 FROM INFORMATION_SCHEMA.GLOBAL_STATUS WHERE VARIABLE_NAME = 'innodb_pages0_read';
use innodb_test; use innodb_test;
show status like 'innodb_pages0_read%'; SELECT VARIABLE_VALUE <= 29 FROM INFORMATION_SCHEMA.GLOBAL_STATUS WHERE VARIABLE_NAME = 'innodb_pages0_read';
use test; use test;
SELECT VARIABLE_VALUE <= 29 FROM INFORMATION_SCHEMA.GLOBAL_STATUS WHERE VARIABLE_NAME = 'innodb_pages0_read';
FLUSH STATUS;
--echo # restart and see number read page 0 --echo # restart and see number read page 0
-- source include/restart_mysqld.inc -- source include/restart_mysqld.inc
show status like 'innodb_pages0_read%'; SELECT VARIABLE_VALUE <= 29 FROM INFORMATION_SCHEMA.GLOBAL_STATUS WHERE VARIABLE_NAME = 'innodb_pages0_read';
use innodb_test; use innodb_test;
show status like 'innodb_pages0_read%'; SELECT VARIABLE_VALUE <= 29 FROM INFORMATION_SCHEMA.GLOBAL_STATUS WHERE VARIABLE_NAME = 'innodb_pages0_read';
use test; use test;
SELECT VARIABLE_VALUE <= 29 FROM INFORMATION_SCHEMA.GLOBAL_STATUS WHERE VARIABLE_NAME = 'innodb_pages0_read';
drop database innodb_test; drop database innodb_test;
show status like 'innodb_pages0_read%'; FLUSH STATUS;
mysql-test/suite/encryption/t/innodb_encryption.test
View file @ 352d27ce
...@@ -15,78 +15,29 @@ SET @start_global_value = @@global.innodb_encryption_threads; ...@@ -15,78 +15,29 @@ SET @start_global_value = @@global.innodb_encryption_threads;
SHOW VARIABLES LIKE 'innodb_encrypt%'; SHOW VARIABLES LIKE 'innodb_encrypt%';
DESCRIBE INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION; SET GLOBAL innodb_encrypt_tables = ON;
--echo # Wait max 5 min for key encryption threads to encrypt one space --echo # Wait max 10 min for key encryption threads to encrypt all spaces
let $cnt=300; --let $wait_timeout= 600
while ($cnt) --let $wait_condition=SELECT COUNT(*) >= 1 FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION <> 0;
{ --source include/wait_condition.inc
let $success=`SELECT COUNT(*) > 0 FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION > 0`;
if ($success) SELECT NAME FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION = 0;
{ SELECT NAME FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION <> 0;
let $cnt=0;
}
if (!$success)
{
real_sleep 1;
dec $cnt;
}
}
if (!$success)
{
SELECT * FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION;
SHOW STATUS LIKE 'innodb_encryption%';
-- die Timeout waiting for encryption threads
}
--echo # Success!
--echo # Wait max 10 min for key encryption threads to encrypt all space
let $cnt=600;
while ($cnt)
{
let $success=`SELECT COUNT(*) = 0 FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION = 0`;
if ($success)
{
let $cnt=0;
}
if (!$success)
{
real_sleep 1;
dec $cnt;
}
}
if (!$success)
{
SELECT * FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION;
SHOW STATUS LIKE 'innodb_encryption%';
-- die Timeout waiting for encryption threads
}
--echo # Success! --echo # Success!
--echo # Now turn off encryption and wait for threads to decrypt everything --echo # Now turn off encryption and wait for threads to decrypt everything
SET GLOBAL innodb_encrypt_tables = off; SET GLOBAL innodb_encrypt_tables = off;
--echo # Wait max 10 min for key encryption threads to decrypt all space --echo # Wait max 10 min for key encryption threads to encrypt all spaces
let $cnt=600; --let $wait_timeout= 600
while ($cnt) --let $wait_condition=SELECT COUNT(*) = 0 FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION <> 0;
{ --source include/wait_condition.inc
let $success=`SELECT COUNT(*) = 0 FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION <> 0`;
if ($success) SELECT NAME FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION = 0;
{ SELECT NAME FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION <> 0;
let $cnt=0;
}
if (!$success)
{
real_sleep 1;
dec $cnt;
}
}
if (!$success)
{
SELECT * FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION;
SHOW STATUS LIKE 'innodb_encryption%';
-- die Timeout waiting for encryption threads
}
--echo # Success! --echo # Success!
--echo # Shutdown innodb_encryption_threads --echo # Shutdown innodb_encryption_threads
...@@ -97,84 +48,32 @@ SET GLOBAL innodb_encryption_threads=0; ...@@ -97,84 +48,32 @@ SET GLOBAL innodb_encryption_threads=0;
SET GLOBAL innodb_encrypt_tables = on; SET GLOBAL innodb_encrypt_tables = on;
--echo # Wait 15s to check that nothing gets encrypted --echo # Wait 15s to check that nothing gets encrypted
let $cnt=15; --let $wait_timeout= 15
while ($cnt) --let $wait_condition=SELECT COUNT(*) = 0 FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION <> 0;
{ --source include/wait_condition.inc
let $success=`SELECT COUNT(*) = 0 FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION <> 0`;
if ($success) SELECT NAME FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION = 0;
{ SELECT NAME FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION <> 0;
real_sleep 1;
dec $cnt;
}
if (!$success)
{
SELECT * FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION <> 0;
-- die Failure, tablespace getting encrypted even if innodb_encryption_threads=0
}
}
--echo # Success! --echo # Success!
--echo # Startup innodb_encryption_threads --echo # Startup innodb_encryption_threads
SET GLOBAL innodb_encryption_threads=@start_global_value; SET GLOBAL innodb_encryption_threads=@start_global_value;
--echo # Wait 1 min to check that it start encrypting again --echo # Wait max 10 min for key encryption threads to encrypt all spaces
let $cnt=60; --let $wait_timeout= 600
while ($cnt) --let $wait_condition=SELECT COUNT(*) >=1 FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION <> 0;
{ --source include/wait_condition.inc
let $success=`SELECT COUNT(*) > 0 FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION <> 0 OR KEY_ROTATION_PAGE_NUMBER IS NOT NULL`;
if ($success) SELECT NAME FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION = 0;
{ SELECT NAME FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION <> 0;
let $cnt=0;
}
if (!$success)
{
real_sleep 1;
dec $cnt;
}
}
if (!$success)
{
SELECT * FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION;
SHOW STATUS LIKE 'innodb_encryption%';
-- die Timeout waiting for encryption threads
}
--echo # Success!
--echo #
--echo # Check that restart with encryption turned off works
--echo # even if spaces are encrypted
--echo #
--echo # First wait max 10 min for key encryption threads to encrypt all spaces
let $cnt=600;
while ($cnt)
{
let $success=`SELECT COUNT(*) = 0 FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION = 0`;
if ($success)
{
let $cnt=0;
}
if (!$success)
{
real_sleep 1;
dec $cnt;
}
}
if (!$success)
{
SELECT * FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION;
SHOW STATUS LIKE 'innodb_encryption%';
-- die Timeout waiting for encryption threads
}
--echo # Success! --echo # Success!
--echo # Restart mysqld --innodb_encrypt_tables=0 --innodb_encryption_threads=0 --echo # Restart mysqld --innodb_encrypt_tables=0 --innodb_encryption_threads=0
-- let $restart_parameters=--innodb_encrypt_tables=0 --innodb_encryption_threads=0 -- let $restart_parameters=--innodb_encrypt_tables=0 --innodb_encryption_threads=0
-- source include/restart_mysqld.inc -- source include/restart_mysqld.inc
SHOW VARIABLES LIKE 'innodb_encrypt%'; SHOW VARIABLES LIKE 'innodb_encrypt%';
SELECT COUNT(*) > 0 as should_be_1
FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION
WHERE MIN_KEY_VERSION <> 0;
--echo # Restart mysqld again...with default options SELECT NAME FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION <> 0;
-- let $restart_parameters= SELECT NAME FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION = 0;
-- source include/restart_mysqld.inc
mysql-test/suite/encryption/t/innodb_lotoftables.test
View file @ 352d27ce
...@@ -53,9 +53,8 @@ show status like 'innodb_pages0_read%'; ...@@ -53,9 +53,8 @@ show status like 'innodb_pages0_read%';
# #
# Verify # Verify
# #
--echo # should be 100 --echo # should be empty
SELECT NAME FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE NAME LIKE 'innodb_encrypted%';
SELECT COUNT(*) FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE NAME LIKE 'innodb_encrypted%';
# #
# This will create 100 tables that are encrypted always # This will create 100 tables that are encrypted always
...@@ -89,10 +88,10 @@ show status like 'innodb_pages0_read%'; ...@@ -89,10 +88,10 @@ show status like 'innodb_pages0_read%';
# #
# Verify # Verify
# #
--echo # should be 100 --echo # should contain 100 tables
SELECT COUNT(*) FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION <> 0 AND NAME LIKE 'innodb_encrypted%'; SELECT NAME FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION <> 0 AND NAME LIKE 'innodb_encrypted%' ORDER BY NAME;
--echo # should be 100 --echo # should contain 0 tables
SELECT COUNT(*) FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION = 0 AND NAME LIKE 'innodb_encrypted%'; SELECT NAME FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION = 0 AND NAME LIKE 'innodb_encrypted%' ORDER BY NAME;
# #
# This will create 100 tables that are not encrypted # This will create 100 tables that are not encrypted
...@@ -126,45 +125,26 @@ show status like 'innodb_pages0_read%'; ...@@ -126,45 +125,26 @@ show status like 'innodb_pages0_read%';
# #
# Verify # Verify
# #
--echo # should be 100 --echo # should contain 100 tables
SELECT COUNT(*) FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION <> 0 AND NAME LIKE 'innodb_encrypted%'; SELECT NAME FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION <> 0 AND NAME LIKE 'innodb_encrypted%' ORDER BY NAME;
--echo # should be 200 --echo # should contain 100 tables
SELECT COUNT(*) FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION = 0 AND NAME LIKE 'innodb_encrypted%'; SELECT NAME FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION = 0 AND NAME LIKE 'innodb_encrypted%' ORDER BY NAME;
use test; use test;
show status like 'innodb_pages0_read%'; show status like 'innodb_pages0_read%';
SELECT COUNT(*) FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION <> 0 AND NAME LIKE 'innodb_encrypted%'; SELECT NAME FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION <> 0 AND NAME LIKE 'innodb_encrypted%' ORDER BY NAME;
SELECT COUNT(*) FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION = 0 AND NAME LIKE 'innodb_encrypted%'; SELECT NAME FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION = 0 AND NAME LIKE 'innodb_encrypted%' ORDER BY NAME;
SET GLOBAL innodb_encrypt_tables = on; SET GLOBAL innodb_encrypt_tables = on;
SET GLOBAL innodb_encryption_threads=4; SET GLOBAL innodb_encryption_threads=4;
--echo # Wait until all encrypted tables have been encrypted --let $wait_timeout= 600
let $cnt=600; --let $wait_condition=SELECT COUNT(*) = 100 FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION <> 0;
while ($cnt) --source include/wait_condition.inc
{
let $success=`SELECT COUNT(*) = 100 FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION = 0`;
if ($success)
{
let $cnt=0;
}
if (!$success)
{
real_sleep 1;
dec $cnt;
}
}
if (!$success)
{
SELECT COUNT(*) FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION <> 0;
SELECT COUNT(*) FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION = 0;
SHOW STATUS LIKE 'innodb_encryption%';
-- die Timeout waiting for encryption threads
}
SELECT COUNT(*) FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION <> 0 AND NAME LIKE 'innodb_encrypted%'; SELECT NAME FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION <> 0 AND NAME LIKE 'innodb_encrypted%' ORDER BY NAME;
SELECT COUNT(*) FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION = 0 AND NAME LIKE 'innodb_encrypted%'; SELECT NAME FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION = 0 AND NAME LIKE 'innodb_encrypted%' ORDER BY NAME;
show status like 'innodb_pages0_read%'; show status like 'innodb_pages0_read%';
--echo # Success! --echo # Success!
...@@ -231,40 +211,19 @@ while ($tables) ...@@ -231,40 +211,19 @@ while ($tables)
show status like 'innodb_pages0_read%'; show status like 'innodb_pages0_read%';
SELECT COUNT(*) FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION = 0 AND NAME LIKE 'innodb_encrypted%'; SELECT NAME FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION = 0 AND NAME LIKE 'innodb_encrypted%' ORDER BY NAME;
SELECT COUNT(*) FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION <> 0 AND NAME LIKE 'innodb_encrypted%'; SELECT NAME FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION <> 0 AND NAME LIKE 'innodb_encrypted%' ORDER BY NAME;
SET GLOBAL innodb_encrypt_tables = off; SET GLOBAL innodb_encrypt_tables = off;
SET GLOBAL innodb_encryption_threads=4; SET GLOBAL innodb_encryption_threads=4;
--echo # Wait until all default encrypted tables have been decrypted --let $wait_timeout= 600
let $cnt=600; --let $wait_condition=SELECT COUNT(*) = 100 FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION <> 0;
while ($cnt) --source include/wait_condition.inc
{
let $success=`SELECT COUNT(*) = 100 FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION <> 0`;
if ($success)
{
let $cnt=0;
}
if (!$success)
{
real_sleep 1;
dec $cnt;
}
}
if (!$success)
{
SELECT COUNT(*) FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION = 0;
SELECT COUNT(*) FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION <> 0;
SHOW STATUS LIKE 'innodb_encryption%';
-- die Timeout waiting for encryption threads
}
--echo # should be 100
SELECT COUNT(*) FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION <> 0 AND NAME LIKE 'innodb_encrypted%'; SELECT NAME FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION <> 0 AND NAME LIKE 'innodb_encrypted%' ORDER BY NAME;
--echo # should be 200 SELECT NAME FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION = 0 AND NAME LIKE 'innodb_encrypted%' ORDER BY NAME;
SELECT COUNT(*) FROM INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION WHERE MIN_KEY_VERSION = 0 AND NAME LIKE 'innodb_encrypted%';
show status like 'innodb_pages0_read%';
# #
# Cleanup # Cleanup
......
storage/innobase/fil/fil0crypt.cc
View file @ 352d27ce
...@@ -1403,7 +1403,7 @@ fil_crypt_realloc_iops( ...@@ -1403,7 +1403,7 @@ fil_crypt_realloc_iops(
DBUG_PRINT("ib_crypt", DBUG_PRINT("ib_crypt",
("thr_no: %u only waited %lu%% skip re-estimate.", ("thr_no: %u only waited %lu%% skip re-estimate.",
state->thread_no, state->thread_no,
(100 * state->cnt_waited) / state->batch)); (100 * state->cnt_waited) / (state->batch ? state->batch : 1)));
} }
if (state->estimated_max_iops <= state->allocated_iops) { if (state->estimated_max_iops <= state->allocated_iops) {
...@@ -1506,7 +1506,7 @@ fil_crypt_find_space_to_rotate( ...@@ -1506,7 +1506,7 @@ fil_crypt_find_space_to_rotate(
/* we need iops to start rotating */ /* we need iops to start rotating */
while (!state->should_shutdown() && !fil_crypt_alloc_iops(state)) { while (!state->should_shutdown() && !fil_crypt_alloc_iops(state)) {
os_event_reset(fil_crypt_threads_event); os_event_reset(fil_crypt_threads_event);
os_event_wait_time(fil_crypt_threads_event, 1000000); os_event_wait_time(fil_crypt_threads_event, 100000);
} }
if (state->should_shutdown()) { if (state->should_shutdown()) {
...@@ -2303,7 +2303,7 @@ fil_crypt_set_thread_cnt( ...@@ -2303,7 +2303,7 @@ fil_crypt_set_thread_cnt(
os_thread_create(fil_crypt_thread, NULL, &rotation_thread_id); os_thread_create(fil_crypt_thread, NULL, &rotation_thread_id);
ib_logf(IB_LOG_LEVEL_INFO, ib_logf(IB_LOG_LEVEL_INFO,
"Creating #%d thread id %lu total threads %u.", "Creating #%d encryption thread id %lu total threads %u.",
i+1, os_thread_pf(rotation_thread_id), new_cnt); i+1, os_thread_pf(rotation_thread_id), new_cnt);
} }
} else if (new_cnt < srv_n_fil_crypt_threads) { } else if (new_cnt < srv_n_fil_crypt_threads) {
...@@ -2315,7 +2315,13 @@ fil_crypt_set_thread_cnt( ...@@ -2315,7 +2315,13 @@ fil_crypt_set_thread_cnt(
while(srv_n_fil_crypt_threads_started != srv_n_fil_crypt_threads) { while(srv_n_fil_crypt_threads_started != srv_n_fil_crypt_threads) {
os_event_reset(fil_crypt_event); os_event_reset(fil_crypt_event);
os_event_wait_time(fil_crypt_event, 1000000); os_event_wait_time(fil_crypt_event, 100000);
}
/* Send a message to encryption threads that there could be
something to do. */
if (srv_n_fil_crypt_threads) {
os_event_set(fil_crypt_threads_event);
} }
} }
...@@ -2461,9 +2467,10 @@ fil_space_crypt_get_status( ...@@ -2461,9 +2467,10 @@ fil_space_crypt_get_status(
ut_ad(space->n_pending_ops > 0); ut_ad(space->n_pending_ops > 0);
fil_crypt_read_crypt_data(const_cast<fil_space_t*>(space)); fil_crypt_read_crypt_data(const_cast<fil_space_t*>(space));
status->space = space->id; status->space = ULINT_UNDEFINED;
if (fil_space_crypt_t* crypt_data = space->crypt_data) { if (fil_space_crypt_t* crypt_data = space->crypt_data) {
status->space = space->id;
mutex_enter(&crypt_data->mutex); mutex_enter(&crypt_data->mutex);
status->scheme = crypt_data->type; status->scheme = crypt_data->type;
status->keyserver_requests = crypt_data->keyserver_requests; status->keyserver_requests = crypt_data->keyserver_requests;
......
storage/innobase/fil/fil0fil.cc
View file @ 352d27ce
...@@ -2214,7 +2214,7 @@ fil_write_flushed_lsn( ...@@ -2214,7 +2214,7 @@ fil_write_flushed_lsn(
/* If tablespace is not encrypted, stamp flush_lsn to /* If tablespace is not encrypted, stamp flush_lsn to
first page of all system tablespace datafiles to avoid first page of all system tablespace datafiles to avoid
unnecessary error messages on possible downgrade. */ unnecessary error messages on possible downgrade. */
if (space->crypt_data->min_key_version == 0) { if (!space->crypt_data || space->crypt_data->min_key_version == 0) {
fil_node_t* node; fil_node_t* node;
ulint sum_of_sizes = 0; ulint sum_of_sizes = 0;
......
storage/innobase/fsp/fsp0fsp.cc
View file @ 352d27ce
...@@ -726,7 +726,11 @@ fsp_header_init(ulint space_id, ulint size, mtr_t* mtr) ...@@ -726,7 +726,11 @@ fsp_header_init(ulint space_id, ulint size, mtr_t* mtr)
fil_space_t* space = fil_space_acquire(space_id); fil_space_t* space = fil_space_acquire(space_id);
ut_ad(space); ut_ad(space);
if (space->crypt_data) { /* Write encryption metadata to page 0 if tablespace is
encrypted or encryption is disabled by table option. */
if (space->crypt_data &&
(space->crypt_data->should_encrypt() ||
space->crypt_data->not_encrypted())) {
space->crypt_data->write_page0(page, mtr); space->crypt_data->write_page0(page, mtr);
} }
......
storage/innobase/handler/i_s.cc
View file @ 352d27ce
...@@ -8212,6 +8212,12 @@ i_s_dict_fill_tablespaces_encryption( ...@@ -8212,6 +8212,12 @@ i_s_dict_fill_tablespaces_encryption(
fil_space_crypt_get_status(space, &status); fil_space_crypt_get_status(space, &status);
/* If tablespace id does not match, we did not find
encryption information for this tablespace. */
if (!space->crypt_data || space->id != status.space) {
goto skip;
}
OK(fields[TABLESPACES_ENCRYPTION_SPACE]->store(space->id)); OK(fields[TABLESPACES_ENCRYPTION_SPACE]->store(space->id));
OK(field_store_string(fields[TABLESPACES_ENCRYPTION_NAME], OK(field_store_string(fields[TABLESPACES_ENCRYPTION_NAME],
...@@ -8246,6 +8252,7 @@ i_s_dict_fill_tablespaces_encryption( ...@@ -8246,6 +8252,7 @@ i_s_dict_fill_tablespaces_encryption(
OK(schema_table_store_record(thd, table_to_fill)); OK(schema_table_store_record(thd, table_to_fill));
skip:
DBUG_RETURN(0); DBUG_RETURN(0);
} }
/*******************************************************************//** /*******************************************************************//**
......
storage/innobase/srv/srv0start.cc
View file @ 352d27ce
...@@ -1191,11 +1191,6 @@ open_or_create_data_files( ...@@ -1191,11 +1191,6 @@ open_or_create_data_files(
ut_a(ret); ut_a(ret);
if (i == 0) { if (i == 0) {
if (!crypt_data) {
crypt_data = fil_space_create_crypt_data(FIL_ENCRYPTION_DEFAULT,
FIL_DEFAULT_ENCRYPTION_KEY);
}
flags = FSP_FLAGS_PAGE_SSIZE(); flags = FSP_FLAGS_PAGE_SSIZE();
fil_space_create(name, 0, flags, FIL_TABLESPACE, fil_space_create(name, 0, flags, FIL_TABLESPACE,
......
storage/xtradb/fil/fil0crypt.cc
View file @ 352d27ce
...@@ -1403,7 +1403,7 @@ fil_crypt_realloc_iops( ...@@ -1403,7 +1403,7 @@ fil_crypt_realloc_iops(
DBUG_PRINT("ib_crypt", DBUG_PRINT("ib_crypt",
("thr_no: %u only waited %lu%% skip re-estimate.", ("thr_no: %u only waited %lu%% skip re-estimate.",
state->thread_no, state->thread_no,
(100 * state->cnt_waited) / state->batch)); (100 * state->cnt_waited) / (state->batch ? state->batch : 1)));
} }
if (state->estimated_max_iops <= state->allocated_iops) { if (state->estimated_max_iops <= state->allocated_iops) {
...@@ -1506,7 +1506,7 @@ fil_crypt_find_space_to_rotate( ...@@ -1506,7 +1506,7 @@ fil_crypt_find_space_to_rotate(
/* we need iops to start rotating */ /* we need iops to start rotating */
while (!state->should_shutdown() && !fil_crypt_alloc_iops(state)) { while (!state->should_shutdown() && !fil_crypt_alloc_iops(state)) {
os_event_reset(fil_crypt_threads_event); os_event_reset(fil_crypt_threads_event);
os_event_wait_time(fil_crypt_threads_event, 1000000); os_event_wait_time(fil_crypt_threads_event, 100000);
} }
if (state->should_shutdown()) { if (state->should_shutdown()) {
...@@ -2303,7 +2303,7 @@ fil_crypt_set_thread_cnt( ...@@ -2303,7 +2303,7 @@ fil_crypt_set_thread_cnt(
os_thread_create(fil_crypt_thread, NULL, &rotation_thread_id); os_thread_create(fil_crypt_thread, NULL, &rotation_thread_id);
ib_logf(IB_LOG_LEVEL_INFO, ib_logf(IB_LOG_LEVEL_INFO,
"Creating #%d thread id %lu total threads %u.", "Creating #%d encryption thread id %lu total threads %u.",
i+1, os_thread_pf(rotation_thread_id), new_cnt); i+1, os_thread_pf(rotation_thread_id), new_cnt);
} }
} else if (new_cnt < srv_n_fil_crypt_threads) { } else if (new_cnt < srv_n_fil_crypt_threads) {
...@@ -2315,7 +2315,13 @@ fil_crypt_set_thread_cnt( ...@@ -2315,7 +2315,13 @@ fil_crypt_set_thread_cnt(
while(srv_n_fil_crypt_threads_started != srv_n_fil_crypt_threads) { while(srv_n_fil_crypt_threads_started != srv_n_fil_crypt_threads) {
os_event_reset(fil_crypt_event); os_event_reset(fil_crypt_event);
os_event_wait_time(fil_crypt_event, 1000000); os_event_wait_time(fil_crypt_event, 100000);
}
/* Send a message to encryption threads that there could be
something to do. */
if (srv_n_fil_crypt_threads) {
os_event_set(fil_crypt_threads_event);
} }
} }
...@@ -2461,9 +2467,10 @@ fil_space_crypt_get_status( ...@@ -2461,9 +2467,10 @@ fil_space_crypt_get_status(
ut_ad(space->n_pending_ops > 0); ut_ad(space->n_pending_ops > 0);
fil_crypt_read_crypt_data(const_cast<fil_space_t*>(space)); fil_crypt_read_crypt_data(const_cast<fil_space_t*>(space));
status->space = space->id; status->space = ULINT_UNDEFINED;
if (fil_space_crypt_t* crypt_data = space->crypt_data) { if (fil_space_crypt_t* crypt_data = space->crypt_data) {
status->space = space->id;
mutex_enter(&crypt_data->mutex); mutex_enter(&crypt_data->mutex);
status->scheme = crypt_data->type; status->scheme = crypt_data->type;
status->keyserver_requests = crypt_data->keyserver_requests; status->keyserver_requests = crypt_data->keyserver_requests;
......
storage/xtradb/fil/fil0fil.cc
View file @ 352d27ce
...@@ -654,7 +654,7 @@ fil_node_open_file( ...@@ -654,7 +654,7 @@ fil_node_open_file(
page = static_cast<byte*>(ut_align(buf2, UNIV_PAGE_SIZE)); page = static_cast<byte*>(ut_align(buf2, UNIV_PAGE_SIZE));
success = os_file_read(node->handle, page, 0, UNIV_PAGE_SIZE); success = os_file_read(node->handle, page, 0, UNIV_PAGE_SIZE);
srv_stats.page0_read.add(1); srv_stats.page0_read.inc();
const ulint space_id = fsp_header_get_space_id(page); const ulint space_id = fsp_header_get_space_id(page);
ulint flags = fsp_header_get_flags(page); ulint flags = fsp_header_get_flags(page);
...@@ -2268,7 +2268,7 @@ fil_write_flushed_lsn( ...@@ -2268,7 +2268,7 @@ fil_write_flushed_lsn(
/* If tablespace is not encrypted, stamp flush_lsn to /* If tablespace is not encrypted, stamp flush_lsn to
first page of all system tablespace datafiles to avoid first page of all system tablespace datafiles to avoid
unnecessary error messages on possible downgrade. */ unnecessary error messages on possible downgrade. */
if (space->crypt_data->min_key_version == 0) { if (!space->crypt_data || space->crypt_data->min_key_version == 0) {
fil_node_t* node; fil_node_t* node;
ulint sum_of_sizes = 0; ulint sum_of_sizes = 0;
...@@ -2414,7 +2414,7 @@ fil_read_first_page( ...@@ -2414,7 +2414,7 @@ fil_read_first_page(
os_file_read(data_file, page, 0, UNIV_PAGE_SIZE); os_file_read(data_file, page, 0, UNIV_PAGE_SIZE);
srv_stats.page0_read.add(1); srv_stats.page0_read.inc();
/* The FSP_HEADER on page 0 is only valid for the first file /* The FSP_HEADER on page 0 is only valid for the first file
in a tablespace. So if this is not the first datafile, leave in a tablespace. So if this is not the first datafile, leave
......
storage/xtradb/fsp/fsp0fsp.cc
View file @ 352d27ce
...@@ -729,7 +729,11 @@ fsp_header_init(ulint space_id, ulint size, mtr_t* mtr) ...@@ -729,7 +729,11 @@ fsp_header_init(ulint space_id, ulint size, mtr_t* mtr)
fil_space_t* space = fil_space_acquire(space_id); fil_space_t* space = fil_space_acquire(space_id);
ut_ad(space); ut_ad(space);
if (space->crypt_data) { /* Write encryption metadata to page 0 if tablespace is
encrypted or encryption is disabled by table option. */
if (space->crypt_data &&
(space->crypt_data->should_encrypt() ||
space->crypt_data->not_encrypted())) {
space->crypt_data->write_page0(page, mtr); space->crypt_data->write_page0(page, mtr);
} }
......
storage/xtradb/handler/i_s.cc
View file @ 352d27ce
...@@ -8524,6 +8524,12 @@ i_s_dict_fill_tablespaces_encryption( ...@@ -8524,6 +8524,12 @@ i_s_dict_fill_tablespaces_encryption(
fil_space_crypt_get_status(space, &status); fil_space_crypt_get_status(space, &status);
/* If tablespace id does not match, we did not find
encryption information for this tablespace. */
if (!space->crypt_data || space->id != status.space) {
goto skip;
}
OK(fields[TABLESPACES_ENCRYPTION_SPACE]->store(space->id)); OK(fields[TABLESPACES_ENCRYPTION_SPACE]->store(space->id));
OK(field_store_string(fields[TABLESPACES_ENCRYPTION_NAME], OK(field_store_string(fields[TABLESPACES_ENCRYPTION_NAME],
...@@ -8558,6 +8564,7 @@ i_s_dict_fill_tablespaces_encryption( ...@@ -8558,6 +8564,7 @@ i_s_dict_fill_tablespaces_encryption(
OK(schema_table_store_record(thd, table_to_fill)); OK(schema_table_store_record(thd, table_to_fill));
skip:
DBUG_RETURN(0); DBUG_RETURN(0);
} }
/*******************************************************************//** /*******************************************************************//**
......
storage/xtradb/srv/srv0start.cc
View file @ 352d27ce
...@@ -1228,11 +1228,6 @@ open_or_create_data_files( ...@@ -1228,11 +1228,6 @@ open_or_create_data_files(
ut_a(ret); ut_a(ret);
if (i == 0) { if (i == 0) {
if (!crypt_data) {
crypt_data = fil_space_create_crypt_data(FIL_ENCRYPTION_DEFAULT,
FIL_DEFAULT_ENCRYPTION_KEY);
}
flags = FSP_FLAGS_PAGE_SSIZE(); flags = FSP_FLAGS_PAGE_SSIZE();
fil_space_create(name, 0, flags, FIL_TABLESPACE, fil_space_create(name, 0, flags, FIL_TABLESPACE,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7