Commit 51af1985 authored by Marko Mäkelä's avatar Marko Mäkelä

MDEV-11454 post-merge fix:

buf_dump(): Correct the printf format passed to buf_dump_status()
to match the argument types.

Revert the changes to storage/xtradb. XtraDB is not being compiled
for 10.2. The unused copy that we have in the 10.2 branch is only
getting merges from 10.1.

Disable the test sys_vars.innodb_buffer_pool_dump_pct_function
because it is unstable on buildbot.
parent 342b48b7
...@@ -12,3 +12,4 @@ ...@@ -12,3 +12,4 @@
innodb_flush_checkpoint_debug_basic: removed from XtraDB-26.0 innodb_flush_checkpoint_debug_basic: removed from XtraDB-26.0
all_vars: obsolete, see sysvars_* tests all_vars: obsolete, see sysvars_* tests
innodb_buffer_pool_dump_pct_function: MDEV-11454 follow-up needed (unstable)
...@@ -324,9 +324,12 @@ buf_dump( ...@@ -324,9 +324,12 @@ buf_dump(
* srv_buf_pool_dump_pct / 100; * srv_buf_pool_dump_pct / 100;
if (n_pages > t_pages) { if (n_pages > t_pages) {
buf_dump_status(STATUS_INFO, buf_dump_status(STATUS_INFO,
"Instance %d, restricted to %u pages " \ "Instance " ULINTPF
"due to innodb_buf_pool_dump_pct (%d)", ", restricted to " ULINTPF
i, t_pages, srv_buf_pool_dump_pct); " pages due to "
"innodb_buf_pool_dump_pct=%lu",
i, t_pages,
srv_buf_pool_dump_pct);
n_pages = t_pages; n_pages = t_pages;
} }
......
...@@ -156,7 +156,8 @@ buf_load_status( ...@@ -156,7 +156,8 @@ buf_load_status(
fmt, ap); fmt, ap);
if (severity == STATUS_NOTICE || severity == STATUS_ERR) { if (severity == STATUS_NOTICE || severity == STATUS_ERR) {
ib_logf((ib_log_level_t) severity, "%s", ut_print_timestamp(stderr);
fprintf(stderr, " InnoDB: %s\n",
export_vars.innodb_buffer_pool_load_status); export_vars.innodb_buffer_pool_load_status);
} }
...@@ -248,21 +249,9 @@ buf_dump( ...@@ -248,21 +249,9 @@ buf_dump(
} }
if (srv_buf_pool_dump_pct != 100) { if (srv_buf_pool_dump_pct != 100) {
ulint t_pages;
ut_ad(srv_buf_pool_dump_pct < 100); ut_ad(srv_buf_pool_dump_pct < 100);
/* limit the number of total pages dumped to X% of the n_pages = n_pages * srv_buf_pool_dump_pct / 100;
* total number of pages */
t_pages = buf_pool->curr_size
* srv_buf_pool_dump_pct / 100;
if (n_pages > t_pages) {
buf_dump_status(STATUS_INFO,
"Instance %d, restricted to %u pages " \
"due to innodb_buf_pool_dump_pct (%d)",
i, t_pages, srv_buf_pool_dump_pct);
n_pages = t_pages;
}
if (n_pages == 0) { if (n_pages == 0) {
n_pages = 1; n_pages = 1;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment