Commit 543208de authored by unknown's avatar unknown

removed 2 small useless if().


sql/log.cc:
  a comment for the future.
sql/mysqld.cc:
  if (p) is not needed: fn_ext() always returns a valid pointed; the way
  to test if an extension was found is if (*p), not if (p).
  But here even if there's no extension, we still want to truncate opt_name
  to FN_REFLEN, so we always execute the code.
  By design, the test was always 'false' (because we strip the extension before
  testing if there's an extension) so log->set_no_rotate never executed.
sql/sql_class.h:
  remove set_no_rotate as we don't need it.
parent d974959b
...@@ -1089,7 +1089,14 @@ bool MYSQL_LOG::write(Log_event* event_info) ...@@ -1089,7 +1089,14 @@ bool MYSQL_LOG::write(Log_event* event_info)
#endif #endif
if ((thd && !(thd->options & OPTION_BIN_LOG) && if ((thd && !(thd->options & OPTION_BIN_LOG) &&
(thd->master_access & SUPER_ACL)) || (thd->master_access & SUPER_ACL)) ||
(local_db && !db_ok(local_db, binlog_do_db, binlog_ignore_db))) (local_db && !db_ok(local_db, binlog_do_db, binlog_ignore_db))
/*
This is the place for future tests like "do the involved tables match
(to be implemented) binlog_[wild_]{do|ignore}_table?" (WL#1049):
we will add a
&& ... to the if().
*/
)
{ {
VOID(pthread_mutex_unlock(&LOCK_log)); VOID(pthread_mutex_unlock(&LOCK_log));
DBUG_PRINT("error",("!db_ok")); DBUG_PRINT("error",("!db_ok"));
......
...@@ -1966,14 +1966,9 @@ bool open_log(MYSQL_LOG *log, const char *hostname, ...@@ -1966,14 +1966,9 @@ bool open_log(MYSQL_LOG *log, const char *hostname,
if (type == LOG_BIN) if (type == LOG_BIN)
{ {
char *p = fn_ext(opt_name); char *p = fn_ext(opt_name);
if (p) uint length=(uint) (p-opt_name);
{ strmake(tmp,opt_name,min(length,FN_REFLEN));
uint length=(uint) (p-opt_name); opt_name=tmp;
strmake(tmp,opt_name,min(length,FN_REFLEN));
opt_name=tmp;
}
if (*fn_ext(opt_name))
log->set_no_rotate(1);
} }
return log->open(opt_name, type, 0, index_file_name, return log->open(opt_name, type, 0, index_file_name,
(read_append) ? SEQ_READ_APPEND : WRITE_CACHE, (read_append) ? SEQ_READ_APPEND : WRITE_CACHE,
......
...@@ -175,7 +175,6 @@ class MYSQL_LOG { ...@@ -175,7 +175,6 @@ class MYSQL_LOG {
inline void unlock_index() { pthread_mutex_unlock(&LOCK_index);} inline void unlock_index() { pthread_mutex_unlock(&LOCK_index);}
inline IO_CACHE *get_index_file() { return &index_file;} inline IO_CACHE *get_index_file() { return &index_file;}
inline uint32 get_open_count() { return open_count; } inline uint32 get_open_count() { return open_count; }
inline void set_no_rotate(bool no_rotate_arg) {no_rotate= no_rotate_arg;}
}; };
/* character conversion tables */ /* character conversion tables */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment