Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
M
MariaDB
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
nexedi
MariaDB
Commits
54c521ca
Commit
54c521ca
authored
Oct 22, 2020
by
Aleksey Midenkov
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
MDEV-23672: incorrect v_indexes access fix
v_indexes was wrongly copied from the source table.
parent
9868253b
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
1 addition
and
4 deletions
+1
-4
mysql-test/suite/innodb/t/instant_alter_bugs.test
mysql-test/suite/innodb/t/instant_alter_bugs.test
+0
-4
storage/innobase/handler/handler0alter.cc
storage/innobase/handler/handler0alter.cc
+1
-0
No files found.
mysql-test/suite/innodb/t/instant_alter_bugs.test
View file @
54c521ca
...
@@ -446,10 +446,6 @@ create table t1 (
...
@@ -446,10 +446,6 @@ create table t1 (
col_text_g
text
generated
always
as
(
substr
(
col_text
,
1
,
499
))
)
col_text_g
text
generated
always
as
(
substr
(
col_text
,
1
,
499
))
)
engine
innodb
row_format
=
redundant
;
engine
innodb
row_format
=
redundant
;
insert
into
t1
(
col_int
,
col_text
)
values
(
0
,
'a'
),
(
null
,
'b'
);
insert
into
t1
(
col_int
,
col_text
)
values
(
0
,
'a'
),
(
null
,
'b'
);
# FIXME: remove the following to trigger the bug
--
disable_query_log
alter
table
t1
modify
column
col_text
text
null
,
force
;
--
enable_query_log
alter
table
t1
modify
column
col_text
text
null
,
algorithm
=
instant
;
alter
table
t1
modify
column
col_text
text
null
,
algorithm
=
instant
;
insert
into
t1
(
col_int
,
col_text
)
values
(
1
,
null
),
(
null
,
null
);
insert
into
t1
(
col_int
,
col_text
)
values
(
1
,
null
),
(
null
,
null
);
update
t1
set
col_text
=
'd'
;
update
t1
set
col_text
=
'd'
;
...
...
storage/innobase/handler/handler0alter.cc
View file @
54c521ca
...
@@ -592,6 +592,7 @@ inline bool dict_table_t::instant_column(const dict_table_t& table,
...
@@ -592,6 +592,7 @@ inline bool dict_table_t::instant_column(const dict_table_t& table,
mem_heap_alloc
(
heap
,
table
.
n_v_cols
*
sizeof
(
*
v_cols
)));
mem_heap_alloc
(
heap
,
table
.
n_v_cols
*
sizeof
(
*
v_cols
)));
for
(
ulint
i
=
table
.
n_v_cols
;
i
--
;
)
{
for
(
ulint
i
=
table
.
n_v_cols
;
i
--
;
)
{
new
(
&
v_cols
[
i
])
dict_v_col_t
(
table
.
v_cols
[
i
]);
new
(
&
v_cols
[
i
])
dict_v_col_t
(
table
.
v_cols
[
i
]);
v_cols
[
i
].
v_indexes
.
clear
();
}
}
}
else
{
}
else
{
ut_ad
(
table
.
n_v_cols
==
0
);
ut_ad
(
table
.
n_v_cols
==
0
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment