Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
M
MariaDB
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
nexedi
MariaDB
Commits
6b5cdd4f
Commit
6b5cdd4f
authored
Dec 04, 2019
by
Marko Mäkelä
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
MDEV-19514: Update stale comments
parent
95e90326
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
7 additions
and
21 deletions
+7
-21
storage/innobase/include/log0recv.h
storage/innobase/include/log0recv.h
+2
-4
storage/innobase/log/log0recv.cc
storage/innobase/log/log0recv.cc
+5
-17
No files found.
storage/innobase/include/log0recv.h
View file @
6b5cdd4f
...
...
@@ -80,10 +80,8 @@ recv_sys_var_init(void);
/*===================*/
/** Apply recv_sys.pages to persistent data pages.
@param[in] last_batch whether the change buffer merge will be
performed as part of the operation */
void
recv_apply_hashed_log_recs
(
bool
last_batch
);
@param[in] last_batch whether redo log writes are possible */
void
recv_apply_hashed_log_recs
(
bool
last_batch
);
/** Whether to store redo log records in recv_sys.pages */
enum
store_t
{
...
...
storage/innobase/log/log0recv.cc
View file @
6b5cdd4f
...
...
@@ -254,10 +254,8 @@ class mlog_init_t
lsn_t
lsn
;
/** Whether btr_page_create() avoided a read of the page.
At the end of the last recovery batch, ibuf_merge()
will invoke change buffer merge for pages that reside
in the buffer pool. (In the last batch, loading pages
would trigger change buffer merge.) */
At the end of the last recovery batch, mark_ibuf_exist()
will mark pages for which this flag is set. */
bool
created
;
};
...
...
@@ -307,14 +305,9 @@ class mlog_init_t
}
}
/** On the last recovery batch, mark whether the
page contains
change buffered changes for the list of
pages that were initialized
/** On the last recovery batch, mark whether the
re exist
buffered changes for the
pages that were initialized
by buf_page_create() and still reside in the buffer pool.
Note: When MDEV-14481 implements redo log apply in the
background, we will have to ensure that buf_page_get_gen()
will not deliver stale pages to users (pages on which the
change buffer was not merged yet).
@param[in,out] mtr dummy mini-transaction */
void
mark_ibuf_exist
(
mtr_t
&
mtr
)
{
...
...
@@ -2100,8 +2093,7 @@ static void recv_read_in_area(page_id_t page_id)
}
/** Apply recv_sys.pages to persistent data pages.
@param[in] last_batch whether the change buffer merge will be
performed as part of the operation */
@param[in] last_batch whether redo log writes are possible */
void
recv_apply_hashed_log_recs
(
bool
last_batch
)
{
ut_ad
(
srv_operation
==
SRV_OPERATION_NORMAL
...
...
@@ -3199,10 +3191,6 @@ recv_group_scan_log_recs(
do
{
if
(
last_phase
&&
store_to_hash
==
STORE_NO
)
{
store_to_hash
=
STORE_IF_EXISTS
;
/* We must not allow change buffer
merge here, because it would generate
redo log records before we have
finished the redo log scan. */
recv_apply_hashed_log_recs
(
false
);
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment