Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
M
MariaDB
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
nexedi
MariaDB
Commits
722f1b2d
Commit
722f1b2d
authored
Mar 24, 2016
by
Sergei Petrunia
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Move the deprecated comments out of the way
parent
8d1f8e88
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
25 additions
and
21 deletions
+25
-21
sql/sql_window.cc
sql/sql_window.cc
+25
-21
No files found.
sql/sql_window.cc
View file @
722f1b2d
...
...
@@ -1440,22 +1440,10 @@ bool compute_two_pass_window_functions(Item_window_func *item_win,
return
is_error
;
}
/*
@brief
This function is called by JOIN::exec to compute window function values
@detail
JOIN::exec calls this after it has filled the temporary table with query
output. The temporary table has fields to store window function values.
@return
false OK
true Error
*/
bool
JOIN
::
process_window_functions
(
List
<
Item
>
*
curr_fields_list
)
{
/////////////////////////////////////////////////////////////////////////////
// Unneeded comments (will be removed when we develop a replacement for
// the feature that was attempted here
/////////////////////////////////////////////////////////////////////////////
/*
TODO Get this code to set can_compute_window_function during preparation,
not during execution.
...
...
@@ -1491,14 +1479,10 @@ bool JOIN::process_window_functions(List<Item> *curr_fields_list)
prefixes, or be a prefix itself. This must hold true for all partitions.
Analog for the order by clause.
*/
#if 0
List<Item_window_func> window_functions;
SQL_I_List<ORDER> largest_partition;
SQL_I_List<ORDER> largest_order_by;
List_iterator_fast
<
Item
>
it
(
*
curr_fields_list
);
Item
*
item
;
#if 0
bool can_compute_window_live = !need_tmp;
// Construct the window_functions item list and check if they can be
// computed using only one sorting.
...
...
@@ -1580,6 +1564,26 @@ bool JOIN::process_window_functions(List<Item> *curr_fields_list)
}
else
#endif
/*
@brief
This function is called by JOIN::exec to compute window function values
@detail
JOIN::exec calls this after it has filled the temporary table with query
output. The temporary table has fields to store window function values.
@return
false OK
true Error
*/
bool
JOIN
::
process_window_functions
(
List
<
Item
>
*
curr_fields_list
)
{
List_iterator_fast
<
Item
>
it
(
*
curr_fields_list
);
Item
*
item
;
{
while
((
item
=
it
++
))
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment