Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
M
MariaDB
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
nexedi
MariaDB
Commits
8246b0ac
Commit
8246b0ac
authored
Jan 30, 2017
by
Sergei Golubchik
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
cleanup: TABLE::non_determinstic_insert
move the check where it make sense, remove incorrect comment
parent
6c4144a4
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
2 additions
and
13 deletions
+2
-13
sql/table.cc
sql/table.cc
+2
-13
No files found.
sql/table.cc
View file @
8246b0ac
...
...
@@ -1073,6 +1073,8 @@ bool parse_vcol_defs(THD *thd, MEM_ROOT *mem_root, TABLE *table,
&
((
*
field_ptr
)
->
default_value
),
error_reported
);
*
(
dfield_ptr
++
)
=
*
field_ptr
;
if
(
vcol
&&
(
vcol
->
flags
&
(
VCOL_NON_DETERMINISTIC
|
VCOL_SESSION_FUNC
)))
table
->
s
->
non_determinstic_insert
=
true
;
break
;
case
VCOL_CHECK_FIELD
:
vcol
=
unpack_vcol_info_from_frm
(
thd
,
mem_root
,
table
,
&
expr_str
,
...
...
@@ -2761,12 +2763,6 @@ bool fix_session_vcol_expr_for_read(THD *thd, Field *field,
the virtual column vcol_field. The expression is used to compute the
values of this column.
@note
If the virtual column has stored_in_db set and it uses non deterministic
function then table->non_determinstic_insert is set.
This is used in replication to ensure that row based replication is used
for inserts.
@retval
TRUE An error occurred, something was wrong with the function
@retval
...
...
@@ -2816,13 +2812,6 @@ static bool fix_and_check_vcol_expr(THD *thd, TABLE *table,
}
vcol
->
flags
=
res
.
errors
;
/*
Mark what kind of default / virtual fields the table has
*/
if
(
vcol
->
stored_in_db
&&
vcol
->
flags
&
(
VCOL_NON_DETERMINISTIC
|
VCOL_SESSION_FUNC
))
table
->
s
->
non_determinstic_insert
=
true
;
if
(
vcol
->
flags
&
VCOL_SESSION_FUNC
)
table
->
s
->
vcols_need_refixing
=
true
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment