Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
M
MariaDB
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
nexedi
MariaDB
Commits
86acf267
Commit
86acf267
authored
Mar 02, 2016
by
Sergei Petrunia
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove all comments starting with 'psergey'
parent
dedf87fd
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
1 addition
and
14 deletions
+1
-14
sql/item_sum.h
sql/item_sum.h
+0
-3
sql/records.cc
sql/records.cc
+1
-1
sql/sql_select.cc
sql/sql_select.cc
+0
-5
sql/sql_window.cc
sql/sql_window.cc
+0
-5
No files found.
sql/item_sum.h
View file @
86acf267
...
...
@@ -546,7 +546,6 @@ class Item_sum :public Item_func_or_sum
virtual
bool
add
()
=
0
;
virtual
bool
setup
(
THD
*
thd
)
{
return
false
;
}
//psergey: for window functions:
virtual
void
remove
()
{
DBUG_ASSERT
(
0
);
}
virtual
void
cleanup
();
...
...
@@ -555,7 +554,6 @@ class Item_sum :public Item_func_or_sum
return
trace_unsupported_by_check_vcol_func_processor
(
func_name
());
}
//psergey-todo: this is ugly:
virtual
void
setup_window_func
(
THD
*
thd
,
Window_spec
*
window_spec
)
{}
};
...
...
@@ -787,7 +785,6 @@ class Item_sum_count :public Item_sum_int
void
clear
();
bool
add
();
void
cleanup
();
// psergey-added:
void
remove
();
public:
...
...
sql/records.cc
View file @
86acf267
...
...
@@ -531,7 +531,7 @@ static int rr_unpack_from_tempfile(READ_RECORD *info)
return
0
;
}
//psergey: make this 'static' again:
int
rr_from_pointers
(
READ_RECORD
*
info
)
{
int
tmp
;
...
...
sql/sql_select.cc
View file @
86acf267
...
...
@@ -3207,7 +3207,6 @@ void JOIN::exec_inner()
if
(
select_options
&
SELECT_DESCRIBE
)
{
do_select_call_count
=
0
;
// psergey-merge-todo: what to do with this ^^^ ?
select_describe
(
this
,
need_tmp
,
order
!=
0
&&
!
skip_sort_order
,
...
...
@@ -8207,9 +8206,6 @@ prev_record_reads(POSITION *positions, uint idx, table_map found_ref)
static
JOIN_TAB
*
next_breadth_first_tab
(
JOIN_TAB
*
first_top_tab
,
uint
n_top_tabs_count
,
JOIN_TAB
*
tab
)
{
/*
psergey-merge-todo: the following is UGLY:
*/
n_top_tabs_count
+=
tab
->
join
->
aggr_tables
;
if
(
!
tab
->
bush_root_tab
)
{
...
...
@@ -8499,7 +8495,6 @@ bool JOIN::get_best_combination()
(
order
?
1
:
0
)
+
(
select_options
&
(
SELECT_BIG_RESULT
|
OPTION_BUFFER_RESULT
)
?
1
:
0
)
;
// psergey-temp:
if
(
select_lex
->
window_specs
.
elements
)
aggr_tables
++
;
...
...
sql/sql_window.cc
View file @
86acf267
...
...
@@ -764,11 +764,6 @@ bool JOIN::process_window_functions(List<Item> *curr_fields_list)
#if 0
bool can_compute_window_live = !need_tmp;
/*
psergey-winfunc: temporarily disabled the below because there is no
way to test it. Enable it back when we can.
*/
// Construct the window_functions item list and check if they can be
// computed using only one sorting.
//
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment