Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
M
MariaDB
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
nexedi
MariaDB
Commits
9021f40b
Commit
9021f40b
authored
Sep 30, 2024
by
Sergei Golubchik
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
MDEV-35050 Found wrong usage of mutex upon setting plugin session variables
parent
b1bbdbab
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
25 additions
and
5 deletions
+25
-5
mysql-test/suite/plugins/r/fulltext_plugin.result
mysql-test/suite/plugins/r/fulltext_plugin.result
+11
-0
mysql-test/suite/plugins/t/fulltext_plugin.test
mysql-test/suite/plugins/t/fulltext_plugin.test
+12
-3
sql/session_tracker.cc
sql/session_tracker.cc
+2
-2
No files found.
mysql-test/suite/plugins/r/fulltext_plugin.result
View file @
9021f40b
#
# BUG#39746 - Debug flag breaks struct definition (server crash)
#
INSTALL PLUGIN simple_parser SONAME 'mypluglib.so';
CREATE TABLE t1(a TEXT, b TEXT, FULLTEXT(a) WITH PARSER simple_parser);
ALTER TABLE t1 ADD FULLTEXT(b) WITH PARSER simple_parser;
...
...
@@ -5,3 +8,11 @@ DROP TABLE t1;
UNINSTALL PLUGIN simple_parser;
show status like 'a%status';
Variable_name Value
#
# MDEV-35050 Found wrong usage of mutex upon setting plugin session variables
#
install soname 'mypluglib';
set session_track_system_variables="*";
set session simple_parser_simple_thdvar_one = 10;
uninstall soname 'mypluglib';
# End of 10.5 tests
mysql-test/suite/plugins/t/fulltext_plugin.test
View file @
9021f40b
--
source
include
/
have_simple_parser
.
inc
#
# BUG#39746 - Debug flag breaks struct definition (server crash)
#
--
echo
#
--
echo
# BUG#39746 - Debug flag breaks struct definition (server crash)
--
echo
#
--
replace_result
.
dll
.
so
eval
INSTALL
PLUGIN
simple_parser
SONAME
'$MYPLUGLIB_SO'
;
CREATE
TABLE
t1
(
a
TEXT
,
b
TEXT
,
FULLTEXT
(
a
)
WITH
PARSER
simple_parser
);
...
...
@@ -15,3 +15,12 @@ UNINSTALL PLUGIN simple_parser;
#
show
status
like
'a%status'
;
--
echo
#
--
echo
# MDEV-35050 Found wrong usage of mutex upon setting plugin session variables
--
echo
#
install
soname
'mypluglib'
;
set
session_track_system_variables
=
"*"
;
set
session
simple_parser_simple_thdvar_one
=
10
;
uninstall
soname
'mypluglib'
;
--
echo
# End of 10.5 tests
sql/session_tracker.cc
View file @
9021f40b
...
...
@@ -428,6 +428,7 @@ bool Session_sysvars_tracker::vars_list::store(THD *thd, String *buf)
SHOW_VAR
show
;
CHARSET_INFO
*
charset
;
size_t
val_length
,
length
;
mysql_mutex_lock
(
&
LOCK_global_system_variables
);
mysql_mutex_lock
(
&
LOCK_plugin
);
if
(
!*
node
->
test_load
)
{
...
...
@@ -444,13 +445,12 @@ bool Session_sysvars_tracker::vars_list::store(THD *thd, String *buf)
show
.
name
=
svar
->
name
.
str
;
show
.
value
=
(
char
*
)
svar
;
mysql_mutex_lock
(
&
LOCK_global_system_variables
);
const
char
*
value
=
get_one_variable
(
thd
,
&
show
,
OPT_SESSION
,
SHOW_SYS
,
NULL
,
&
charset
,
val_buf
,
&
val_length
);
mysql_mutex_unlock
(
&
LOCK_global_system_variables
);
if
(
is_plugin
)
mysql_mutex_unlock
(
&
LOCK_plugin
);
mysql_mutex_unlock
(
&
LOCK_global_system_variables
);
length
=
net_length_size
(
svar
->
name
.
length
)
+
svar
->
name
.
length
+
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment