Commit ae8d0b37 authored by Michael Widenius's avatar Michael Widenius

Fixed that we use same flags when testing for assembler as by makefiles.

Fixed bug in locking by triggers found by test case when compiling without query cache

configure.in:
  Fixed that we use same flags when testing for assembler as by makefiles.
sql/sql_yacc.yy:
  Fixed bug in locking by triggers found by test case when compiling without query cache
  The idea should be that triggers uses the same lock method (low_priority_locks...) as main tables.
parent d121e663
...@@ -224,14 +224,6 @@ then ...@@ -224,14 +224,6 @@ then
GXX="no" GXX="no"
fi fi
if test "$ac_cv_prog_gcc" = "yes"
then
AS="$CC -c"
AC_SUBST(AS)
else
AC_PATH_PROG(AS, as, as)
fi
# Still need ranlib for readline; local static use only so no libtool. # Still need ranlib for readline; local static use only so no libtool.
AC_PROG_RANLIB AC_PROG_RANLIB
# We use libtool # We use libtool
...@@ -688,7 +680,7 @@ AC_ARG_ENABLE(assembler, ...@@ -688,7 +680,7 @@ AC_ARG_ENABLE(assembler,
AC_MSG_CHECKING(if we should use assembler functions) AC_MSG_CHECKING(if we should use assembler functions)
# For now we only support assembler on i386 and sparc systems # For now we only support assembler on i386 and sparc systems
AM_CONDITIONAL(ASSEMBLER_x86, test "$ENABLE_ASSEMBLER" = "yes" -a "$BASE_MACHINE_TYPE" = "i386" && $AS strings/strings-x86.s -o checkassembler >/dev/null 2>&1 && test -f checkassembler && (rm -f checkassembler; exit 0;)) AM_CONDITIONAL(ASSEMBLER_x86, test "$ENABLE_ASSEMBLER" = "yes" -a "$BASE_MACHINE_TYPE" = "i386" && $CCAS $CCASFLAGS -c strings/strings-x86.s -o checkassembler >/dev/null 2>&1 && test -f checkassembler && (rm -f checkassembler; exit 0;))
AM_CONDITIONAL(ASSEMBLER_sparc32, test "$ENABLE_ASSEMBLER" = "yes" -a "$BASE_MACHINE_TYPE" = "sparc") AM_CONDITIONAL(ASSEMBLER_sparc32, test "$ENABLE_ASSEMBLER" = "yes" -a "$BASE_MACHINE_TYPE" = "sparc")
AM_CONDITIONAL(ASSEMBLER_sparc64, test "$ENABLE_ASSEMBLER" = "yes" -a "$BASE_MACHINE_TYPE" = "sparcv9") AM_CONDITIONAL(ASSEMBLER_sparc64, test "$ENABLE_ASSEMBLER" = "yes" -a "$BASE_MACHINE_TYPE" = "sparcv9")
AM_CONDITIONAL(ASSEMBLER, test "$ASSEMBLER_x86_TRUE" = "" -o "$ASSEMBLER_sparc32_TRUE" = "") AM_CONDITIONAL(ASSEMBLER, test "$ASSEMBLER_x86_TRUE" = "" -o "$ASSEMBLER_sparc32_TRUE" = "")
......
...@@ -9483,16 +9483,12 @@ replace: ...@@ -9483,16 +9483,12 @@ replace:
insert_lock_option: insert_lock_option:
/* empty */ /* empty */
{ {
#ifdef HAVE_QUERY_CACHE
/* /*
If it is SP we do not allow insert optimisation whan result of If it is SP we do not allow insert optimisation when result of
insert visible only after the table unlocking but everyone can insert visible only after the table unlocking but everyone can
read table. read table.
*/ */
$$= (Lex->sphead ? TL_WRITE_DEFAULT : TL_WRITE_CONCURRENT_INSERT); $$= (Lex->sphead ? TL_WRITE_DEFAULT : TL_WRITE_CONCURRENT_INSERT);
#else
$$= TL_WRITE_CONCURRENT_INSERT;
#endif
} }
| LOW_PRIORITY { $$= TL_WRITE_LOW_PRIORITY; } | LOW_PRIORITY { $$= TL_WRITE_LOW_PRIORITY; }
| DELAYED_SYM { $$= TL_WRITE_DELAYED; } | DELAYED_SYM { $$= TL_WRITE_DELAYED; }
...@@ -10515,15 +10511,11 @@ load_data_lock: ...@@ -10515,15 +10511,11 @@ load_data_lock:
/* empty */ { $$= TL_WRITE_DEFAULT; } /* empty */ { $$= TL_WRITE_DEFAULT; }
| CONCURRENT | CONCURRENT
{ {
#ifdef HAVE_QUERY_CACHE
/* /*
Ignore this option in SP to avoid problem with query cache Ignore this option in SP to avoid problem with query cache and
triggers with non default priority locks
*/ */
if (Lex->sphead != 0) $$= (Lex->sphead ? TL_WRITE_DEFAULT : TL_WRITE_CONCURRENT_INSERT);
$$= TL_WRITE_DEFAULT;
else
#endif
$$= TL_WRITE_CONCURRENT_INSERT;
} }
| LOW_PRIORITY { $$= TL_WRITE_LOW_PRIORITY; } | LOW_PRIORITY { $$= TL_WRITE_LOW_PRIORITY; }
; ;
...@@ -12237,12 +12229,7 @@ lock_option: ...@@ -12237,12 +12229,7 @@ lock_option:
| WRITE_SYM { $$= TL_WRITE_DEFAULT; } | WRITE_SYM { $$= TL_WRITE_DEFAULT; }
| WRITE_SYM CONCURRENT | WRITE_SYM CONCURRENT
{ {
#ifdef HAVE_QUERY_CACHE $$= (Lex->sphead ? TL_WRITE_DEFAULT : TL_WRITE_CONCURRENT_INSERT);
if (Lex->sphead != 0)
$$= TL_WRITE_DEFAULT;
else
#endif
$$= TL_WRITE_CONCURRENT_INSERT;
} }
| LOW_PRIORITY WRITE_SYM { $$= TL_WRITE_LOW_PRIORITY; } | LOW_PRIORITY WRITE_SYM { $$= TL_WRITE_LOW_PRIORITY; }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment