Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
M
MariaDB
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
nexedi
MariaDB
Commits
b44e28af
Commit
b44e28af
authored
May 09, 2022
by
Monty
Committed by
Sergei Petrunia
Feb 02, 2023
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Simple optimization: Remove JOIN::set_group_rpa as it is not needed
parent
5e5a8eda
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
1 addition
and
9 deletions
+1
-9
sql/sql_select.cc
sql/sql_select.cc
+1
-7
sql/sql_select.h
sql/sql_select.h
+0
-2
No files found.
sql/sql_select.cc
View file @
b44e28af
...
...
@@ -532,7 +532,6 @@ void JOIN::init(THD *thd_arg, List<Item> &fields_arg,
no_const_tables= FALSE;
first_select= sub_select;
set_group_rpa= false;
group_sent= 0;
outer_ref_cond= pseudo_bits_cond= NULL;
...
...
@@ -4467,7 +4466,6 @@ JOIN::reinit()
if (current_ref_ptrs != items0)
{
set_items_ref_array(items0);
set_group_rpa= false;
}
/* need to reset ref access state (see join_read_key) */
...
...
@@ -15383,7 +15381,6 @@ void JOIN::cleanup(bool full)
if (current_ref_ptrs != items0)
{
set_items_ref_array(items0);
set_group_rpa= false;
}
DBUG_VOID_RETURN;
}
...
...
@@ -23647,11 +23644,8 @@ end_send_group(JOIN *join, JOIN_TAB *join_tab, bool end_of_records)
List<Item> *fields= join_tab ? (join_tab-1)->fields : join->fields;
DBUG_ENTER("end_send_group");
if (!join->items3.is_null() && !join->set_group_rpa)
{
join->set_group_rpa= true;
if (!join->items3.is_null() && join->current_ref_ptrs != join->items3)
join->set_items_ref_array(join->items3);
}
if (!join->first_record || end_of_records ||
(idx=test_if_group_changed(join->group_fields)) >= 0)
sql/sql_select.h
View file @
b44e28af
...
...
@@ -1574,8 +1574,6 @@ class JOIN :public Sql_alloc
/* SJM nests that are executed with SJ-Materialization strategy */
List
<
SJ_MATERIALIZATION_INFO
>
sjm_info_list
;
/** TRUE <=> ref_pointer_array is set to items3. */
bool
set_group_rpa
;
/** Exec time only: TRUE <=> current group has been sent */
bool
group_sent
;
/**
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment