Commit c24d1d66 authored by Monty's avatar Monty

Improve error messages

- mysql_install_db now prints position to error file, if log-error is used
- Warning about compatibility now mentions MySQL 5.6 and 5.7
- Give warning if --show_compatibility_56 is used
parent cfaaace6
...@@ -4418,7 +4418,7 @@ sub extract_warning_lines ($$) { ...@@ -4418,7 +4418,7 @@ sub extract_warning_lines ($$) {
qr|feedback plugin: failed to retrieve the MAC address|, qr|feedback plugin: failed to retrieve the MAC address|,
qr|Plugin 'FEEDBACK' init function returned error|, qr|Plugin 'FEEDBACK' init function returned error|,
qr|Plugin 'FEEDBACK' registration as a INFORMATION SCHEMA failed|, qr|Plugin 'FEEDBACK' registration as a INFORMATION SCHEMA failed|,
qr|'log-bin-use-v1-row-events' is MySQL 5.6 compatible option|, qr|'log-bin-use-v1-row-events' is MySQL .* compatible option|,
qr|InnoDB: Setting thread \d+ nice to \d+ failed, current nice \d+, errno 13|, # setpriority() fails under valgrind qr|InnoDB: Setting thread \d+ nice to \d+ failed, current nice \d+, errno 13|, # setpriority() fails under valgrind
qr|Failed to setup SSL|, qr|Failed to setup SSL|,
qr|SSL error: Failed to set ciphers to use|, qr|SSL error: Failed to set ciphers to use|,
......
...@@ -24,6 +24,7 @@ builddir="" ...@@ -24,6 +24,7 @@ builddir=""
ldata="@localstatedir@" ldata="@localstatedir@"
langdir="" langdir=""
srcdir="" srcdir=""
log_error=""
args="" args=""
defaults="" defaults=""
...@@ -136,6 +137,8 @@ parse_arguments() ...@@ -136,6 +137,8 @@ parse_arguments()
--builddir=*) builddir=`parse_arg "$arg"` ;; --builddir=*) builddir=`parse_arg "$arg"` ;;
--srcdir=*) srcdir=`parse_arg "$arg"` ;; --srcdir=*) srcdir=`parse_arg "$arg"` ;;
--ldata=*|--datadir=*|--data=*) ldata=`parse_arg "$arg"` ;; --ldata=*|--datadir=*|--data=*) ldata=`parse_arg "$arg"` ;;
--log-error=*)
log_error=`parse_arg "$arg"` ;;
--user=*) --user=*)
# Note that the user will be passed to mysqld so that it runs # Note that the user will be passed to mysqld so that it runs
# as 'user' (crucial e.g. if log-bin=/some_other_path/ # as 'user' (crucial e.g. if log-bin=/some_other_path/
...@@ -147,7 +150,6 @@ parse_arguments() ...@@ -147,7 +150,6 @@ parse_arguments()
--help) usage ;; --help) usage ;;
--no-defaults|--defaults-file=*|--defaults-extra-file=*) --no-defaults|--defaults-file=*|--defaults-extra-file=*)
defaults="$arg" ;; defaults="$arg" ;;
--cross-bootstrap|--windows) --cross-bootstrap|--windows)
# Used when building the MariaDB system tables on a different host than # Used when building the MariaDB system tables on a different host than
# the target. The platform-independent files that are created in # the target. The platform-independent files that are created in
...@@ -475,9 +477,14 @@ if { echo "use mysql;$install_params"; cat "$create_system_tables" "$create_syst ...@@ -475,9 +477,14 @@ if { echo "use mysql;$install_params"; cat "$create_system_tables" "$create_syst
then then
s_echo "OK" s_echo "OK"
else else
log_file_place=$ldata
if test -n "$log_error"
then
log_file_place="$log_error or $log_file_place"
fi
echo echo
echo "Installation of system tables failed! Examine the logs in" echo "Installation of system tables failed! Examine the logs in"
echo "$ldata for more information." echo "$log_file_place for more information."
echo echo
echo "The problem could be conflicting information in an external" echo "The problem could be conflicting information in an external"
echo "my.cnf files. You can ignore these by doing:" echo "my.cnf files. You can ignore these by doing:"
......
...@@ -7759,6 +7759,7 @@ struct my_option my_long_options[]= ...@@ -7759,6 +7759,7 @@ struct my_option my_long_options[]=
MYSQL_SUGGEST_ANALOG_OPTION("max-binlog-dump-events", "--debug-max-binlog-dump-events"), MYSQL_SUGGEST_ANALOG_OPTION("max-binlog-dump-events", "--debug-max-binlog-dump-events"),
MYSQL_SUGGEST_ANALOG_OPTION("sporadic-binlog-dump-fail", "--debug-sporadic-binlog-dump-fail"), MYSQL_SUGGEST_ANALOG_OPTION("sporadic-binlog-dump-fail", "--debug-sporadic-binlog-dump-fail"),
MYSQL_COMPATIBILITY_OPTION("new"), MYSQL_COMPATIBILITY_OPTION("new"),
MYSQL_COMPATIBILITY_OPTION("show_compatibility_56"),
/* The following options were added after 5.6.10 */ /* The following options were added after 5.6.10 */
MYSQL_TO_BE_IMPLEMENTED_OPTION("rpl-stop-slave-timeout"), MYSQL_TO_BE_IMPLEMENTED_OPTION("rpl-stop-slave-timeout"),
...@@ -9044,12 +9045,12 @@ mysqld_get_one_option(int optid, const struct my_option *opt, char *argument) ...@@ -9044,12 +9045,12 @@ mysqld_get_one_option(int optid, const struct my_option *opt, char *argument)
opt->name); opt->name);
break; break;
case OPT_MYSQL_COMPATIBILITY: case OPT_MYSQL_COMPATIBILITY:
sql_print_warning("'%s' is MySQL 5.6 compatible option. Not used or needed " sql_print_warning("'%s' is MySQL 5.6 / 5.7 compatible option. Not used or "
"in MariaDB.", opt->name); "needed in MariaDB.", opt->name);
break; break;
case OPT_MYSQL_TO_BE_IMPLEMENTED: case OPT_MYSQL_TO_BE_IMPLEMENTED:
sql_print_warning("'%s' is MySQL 5.6 compatible option. To be implemented " sql_print_warning("'%s' is MySQL 5.6 / 5.7 compatible option. To be "
"in later versions.", opt->name); "implemented in later versions.", opt->name);
break; break;
case 'a': case 'a':
SYSVAR_AUTOSIZE(global_system_variables.sql_mode, MODE_ANSI); SYSVAR_AUTOSIZE(global_system_variables.sql_mode, MODE_ANSI);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment