Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
M
MariaDB
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
nexedi
MariaDB
Commits
cefe361b
Commit
cefe361b
authored
Nov 26, 2001
by
monty@hundin.mysql.fi
Browse files
Options
Browse Files
Download
Plain Diff
merge
parents
bbc5277c
50b43f85
Changes
8
Hide whitespace changes
Inline
Side-by-side
Showing
8 changed files
with
123 additions
and
22 deletions
+123
-22
Docs/manual.texi
Docs/manual.texi
+15
-1
mysql-test/r/bdb-deadlock.result
mysql-test/r/bdb-deadlock.result
+10
-0
mysql-test/t/backup.test
mysql-test/t/backup.test
+1
-0
mysql-test/t/bdb-crash.test
mysql-test/t/bdb-crash.test
+7
-7
mysql-test/t/bdb-deadlock.test
mysql-test/t/bdb-deadlock.test
+48
-0
mysys/thr_lock.c
mysys/thr_lock.c
+2
-1
sql/records.cc
sql/records.cc
+32
-12
sql/sql_table.cc
sql/sql_table.cc
+8
-1
No files found.
Docs/manual.texi
View file @
cefe361b
...
...
@@ -46244,6 +46244,7 @@ users use this code as the rest of the code and because of this we are
not yet 100% confident in this code.
@menu
* News-3.23.46::
* News-3.23.45:: Changes in release 3.23.45
* News-3.23.44:: Changes in release 3.23.44
* News-3.23.43:: Changes in release 3.23.43
...
...
@@ -46293,7 +46294,20 @@ not yet 100% confident in this code.
* News-3.23.0:: Changes in release 3.23.0
@end menu
@node News-3.23.45, News-3.23.44, News-3.23.x, News-3.23.x
@node News-3.23.46, News-3.23.45, News-3.23.x, News-3.23.x
@appendixsubsec Changes in release 3.23.46
@itemize @bullet
@item
Fixed bug where one got an empty set instead of a DEADLOCK error when using
BDB tables.
@item
One can now kill @code{ANALYZE},@code{REPAIR} and @code{OPTIMIZE TABLE} when
the thread is waiting to get a lock on the table.
@item
Fixed race condition in @code{ANALYZE TABLE}.
@end itemize
@node News-3.23.45, News-3.23.44, News-3.23.46, News-3.23.x
@appendixsubsec Changes in release 3.23.45
@itemize @bullet
@item
mysql-test/r/bdb-deadlock.result
0 → 100644
View file @
cefe361b
x
1
id x
0 1
id x
0 1
id x
0 1
id x
0 1
mysql-test/t/backup.test
View file @
cefe361b
...
...
@@ -39,3 +39,4 @@ reap;
unlock
tables
;
connection
con1
;
reap
;
drop
table
t1
;
mysql-test/t/bdb-crash.test
View file @
cefe361b
--
source
include
/
have_bdb
.
inc
# test for bug reported by Mark Steele
drop
table
if
exists
t
blChange
;
CREATE
TABLE
t
blCharge
(
drop
table
if
exists
t
1
;
CREATE
TABLE
t
1
(
ChargeID
int
(
10
)
unsigned
DEFAULT
'0'
NOT
NULL
auto_increment
,
ServiceID
int
(
10
)
unsigned
DEFAULT
'0'
NOT
NULL
,
ChargeDate
date
DEFAULT
'0000-00-00'
NOT
NULL
,
...
...
@@ -20,16 +20,16 @@ DEFAULT 'New' NOT NULL,
)
type
=
BDB
;
BEGIN
;
INSERT
INTO
t
blCharge
INSERT
INTO
t
1
VALUES
(
NULL
,
1
,
'2001-03-01'
,
1
,
1
,
1
,
'New'
,
NULL
,
NULL
,
'now'
);
COMMIT
;
BEGIN
;
UPDATE
t
blCharge
SET
ChargeAuthorizationMessage
=
'blablabla'
WHERE
UPDATE
t
1
SET
ChargeAuthorizationMessage
=
'blablabla'
WHERE
ChargeID
=
1
;
COMMIT
;
INSERT
INTO
t
blCharge
INSERT
INTO
t
1
VALUES
(
NULL
,
1
,
'2001-03-01'
,
1
,
1
,
1
,
'New'
,
NULL
,
NULL
,
'now'
);
select
*
from
t
blCharge
;
drop
table
t
blCharge
;
select
*
from
t
1
;
drop
table
t
1
;
mysql-test/t/bdb-deadlock.test
0 → 100644
View file @
cefe361b
# This test doesn't work with the embedded version as this code
# assumes that one query is running while we are doing queries on
# a second connection.
# This would work if mysqltest run would be threaded and handle each
# connection in a separate thread.
#
#-- source include/not_embedded.inc
--
source
include
/
have_bdb
.
inc
connect
(
con1
,
localhost
,
root
,,);
connect
(
con2
,
localhost
,
root
,,);
drop
table
if
exists
t1
,
t2
;
connection
con1
;
create
table
t1
(
id
integer
,
x
integer
)
type
=
BDB
;
create
table
t2
(
id
integer
,
x
integer
)
type
=
BDB
;
insert
into
t1
values
(
0
,
0
);
insert
into
t2
values
(
0
,
0
);
set
autocommit
=
0
;
update
t1
set
x
=
1
where
id
=
0
;
connection
con2
;
set
autocommit
=
0
;
update
t2
set
x
=
1
where
id
=
0
;
# The following query should hang because con1 is locking the page
--
send
select
x
from
t1
where
id
=
0
;
connection
con1
;
# This should generate a deadlock as we are trying to access a locked row
--
error
1213
select
x
from
t2
where
id
=
0
;
commit
;
connection
con2
;
reap
;
commit
;
select
*
from
t1
;
select
*
from
t2
;
commit
;
connection
con1
;
select
*
from
t1
;
select
*
from
t2
;
commit
;
drop
table
t1
,
t2
;
mysys/thr_lock.c
View file @
cefe361b
...
...
@@ -913,7 +913,8 @@ void thr_multi_unlock(THR_LOCK_DATA **data,uint count)
DBUG_VOID_RETURN
;
}
/* Abort all threads waiting for a lock. The lock will be upgraded to a
/*
Abort all threads waiting for a lock. The lock will be upgraded to
TL_WRITE_ONLY to abort any new accesses to the lock
*/
...
...
sql/records.cc
View file @
cefe361b
...
...
@@ -132,8 +132,13 @@ static int rr_quick(READ_RECORD *info)
{
if
(
tmp
==
HA_ERR_END_OF_FILE
)
tmp
=
-
1
;
else
if
(
info
->
print_error
)
info
->
file
->
print_error
(
tmp
,
MYF
(
0
));
else
{
if
(
info
->
print_error
)
info
->
file
->
print_error
(
tmp
,
MYF
(
0
));
if
(
tmp
<
0
)
// Fix negative BDB errno
tmp
=
1
;
}
}
return
tmp
;
}
...
...
@@ -153,8 +158,13 @@ static int rr_sequential(READ_RECORD *info)
{
if
(
tmp
==
HA_ERR_END_OF_FILE
)
tmp
=
-
1
;
else
if
(
info
->
print_error
)
info
->
table
->
file
->
print_error
(
tmp
,
MYF
(
0
));
else
{
if
(
info
->
print_error
)
info
->
table
->
file
->
print_error
(
tmp
,
MYF
(
0
));
if
(
tmp
<
0
)
// Fix negative BDB errno
tmp
=
1
;
}
break
;
}
}
...
...
@@ -168,21 +178,27 @@ static int rr_from_tempfile(READ_RECORD *info)
tryNext:
if
(
my_b_read
(
info
->
io_cache
,
info
->
ref_pos
,
info
->
ref_length
))
return
-
1
;
/* End of file */
tmp
=
info
->
file
->
rnd_pos
(
info
->
record
,
info
->
ref_pos
);
if
(
tmp
)
if
((
tmp
=
info
->
file
->
rnd_pos
(
info
->
record
,
info
->
ref_pos
)))
{
if
(
tmp
==
HA_ERR_END_OF_FILE
)
tmp
=
-
1
;
else
if
(
tmp
==
HA_ERR_RECORD_DELETED
)
goto
tryNext
;
else
if
(
info
->
print_error
)
info
->
file
->
print_error
(
tmp
,
MYF
(
0
));
else
{
if
(
info
->
print_error
)
info
->
file
->
print_error
(
tmp
,
MYF
(
0
));
if
(
tmp
<
0
)
// Fix negative BDB errno
tmp
=
1
;
}
}
return
tmp
;
}
/* rr_from_tempfile */
static
int
rr_from_pointers
(
READ_RECORD
*
info
)
{
int
tmp
;
byte
*
cache_pos
;
tryNext:
if
(
info
->
cache_pos
==
info
->
cache_end
)
...
...
@@ -190,15 +206,19 @@ static int rr_from_pointers(READ_RECORD *info)
cache_pos
=
info
->
cache_pos
;
info
->
cache_pos
+=
info
->
ref_length
;
int
tmp
=
info
->
file
->
rnd_pos
(
info
->
record
,
cache_pos
);
if
(
tmp
)
if
((
tmp
=
info
->
file
->
rnd_pos
(
info
->
record
,
cache_pos
)))
{
if
(
tmp
==
HA_ERR_END_OF_FILE
)
tmp
=
-
1
;
else
if
(
tmp
==
HA_ERR_RECORD_DELETED
)
goto
tryNext
;
else
if
(
info
->
print_error
)
info
->
file
->
print_error
(
tmp
,
MYF
(
0
));
else
{
if
(
info
->
print_error
)
info
->
file
->
print_error
(
tmp
,
MYF
(
0
));
if
(
tmp
<
0
)
// Fix negative BDB errno
tmp
=
1
;
}
}
return
tmp
;
}
...
...
sql/sql_table.cc
View file @
cefe361b
...
...
@@ -954,9 +954,11 @@ static int mysql_admin_table(THD* thd, TABLE_LIST* tables,
}
/* Close all instances of the table to allow repair to rename files */
if
(
open_for_modify
&&
table
->
table
->
version
)
if
(
lock_type
==
TL_WRITE
&&
table
->
table
->
version
)
{
pthread_mutex_lock
(
&
LOCK_open
);
const
char
*
old_message
=
thd
->
enter_cond
(
&
COND_refresh
,
&
LOCK_open
,
"Waiting to get writelock"
);
mysql_lock_abort
(
thd
,
table
->
table
);
while
(
remove_table_from_cache
(
thd
,
table
->
table
->
table_cache_key
,
table
->
table
->
real_name
)
&&
...
...
@@ -966,9 +968,11 @@ static int mysql_admin_table(THD* thd, TABLE_LIST* tables,
(
void
)
pthread_cond_wait
(
&
COND_refresh
,
&
LOCK_open
);
dropping_tables
--
;
}
thd
->
exit_cond
(
old_message
);
pthread_mutex_unlock
(
&
LOCK_open
);
if
(
thd
->
killed
)
goto
err
;
open_for_modify
=
0
;
}
int
result_code
=
(
table
->
table
->
file
->*
operator_func
)(
thd
,
check_opt
);
...
...
@@ -1016,6 +1020,9 @@ static int mysql_admin_table(THD* thd, TABLE_LIST* tables,
}
if
(
fatal_error
)
table
->
table
->
version
=
0
;
// Force close of table
else
if
(
open_for_modify
)
remove_table_from_cache
(
thd
,
table
->
table
->
table_cache_key
,
table
->
table
->
real_name
);
close_thread_tables
(
thd
);
if
(
my_net_write
(
&
thd
->
net
,
(
char
*
)
packet
->
ptr
(),
packet
->
length
()))
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment