FT-512 Remove the majority of the remaining BDB artifacts

CTestCustom.cmake

@@ -33,7 +33,6 @@ list(APPEND CTEST_CUSTOM_MEMCHECK_IGNORE
   ydb/preload-db-nested.tdb
   ydb/stress-gc.tdb
   ydb/stress-gc2.tdb
-  ydb/stress-test.bdb
   ydb/stress-test.tdb
   ydb/test-5138.tdb
   ydb/test-prepare.tdb
@@ -45,7 +44,6 @@ list(APPEND CTEST_CUSTOM_MEMCHECK_IGNORE
   ydb/test-xa-prepare.tdb
   ydb/test4573-logtrim.tdb
   ydb/test_3645.tdb
-  ydb/test_groupcommit_perf.bdb
   ydb/test_groupcommit_perf.tdb
   ydb/test_large_update_broadcast_small_cachetable.tdb
   ydb/test_update_broadcast_stress.tdb

README.md

@@ -35,7 +35,6 @@ mkdir build
 cd build
 CC=gcc47 CXX=g++47 cmake \
     -D CMAKE_BUILD_TYPE=Debug \
-    -D USE_BDB=OFF \
     -D BUILD_TESTING=OFF \
     -D USE_VALGRIND=OFF \
     -D CMAKE_INSTALL_PREFIX=../prefix/ \
@@ -84,15 +83,10 @@ There are some large data files not stored in the git repository, that
 will be made available soon.  For now, the tests that use these files will
 not run.
 
-Many of the tests are linked with both TokuFT and Berkeley DB, as a sanity
-check on the tests themselves.  To build these tests, you will need
-Berkeley DB and its header files installed.  If you do not have Berkeley
-DB installed, just don't pass `USE_BDB=ON`.
-
 In the build directory from above:
 
 ```sh
-cmake -D BUILD_TESTING=ON [-D USE_BDB=ON] ..
+cmake -D BUILD_TESTING=ON ..
 ctest -D ExperimentalStart \
       -D ExperimentalConfigure \
       -D ExperimentalBuild \

cmake_modules/FindBDB.cmake

-# - Try to find BDB
-# Once done this will define
-#  BDB_FOUND - System has BDB
-#  BDB_INCLUDE_DIRS - The BDB include directories
-#  BDB_LIBRARIES - The libraries needed to use BDB
-#  BDB_DEFINITIONS - Compiler switches required for using BDB
-
-find_path(BDB_INCLUDE_DIR db.h)
-
-find_library(BDB_LIBRARY NAMES db libdb)
-
-include(CheckSymbolExists)
-## check if the found bdb has DB_TXN_SNAPSHOT
-set(CMAKE_REQUIRED_INCLUDES ${BDB_INCLUDE_DIR})
-check_symbol_exists(DB_TXN_SNAPSHOT "db.h" HAVE_DB_TXN_SNAPSHOT)
-if(HAVE_DB_TXN_SNAPSHOT)
-  set(BDB_INCLUDE_DIRS ${BDB_INCLUDE_DIR})
-  set(BDB_LIBRARIES ${BDB_LIBRARY})
-
-  include(FindPackageHandleStandardArgs)
-  # handle the QUIETLY and REQUIRED arguments and set BDB_FOUND to TRUE
-  # if all listed variables are TRUE
-  find_package_handle_standard_args(BDB DEFAULT_MSG
-                                    BDB_LIBRARY BDB_INCLUDE_DIR)
-
-  mark_as_advanced(BDB_INCLUDE_DIR BDB_LIBRARY)
-endif()

cmake_modules/TokuFeatureDetection.cmake

@@ -2,11 +2,6 @@
 find_package(Threads)
 find_package(ZLIB REQUIRED)
 
-option(USE_BDB "Build some tools and tests with bdb (requires a proper BerkeleyDB include directory and library)." ON)
-if(USE_BDB)
-  find_package(BDB REQUIRED)
-endif()
-
 option(USE_VALGRIND "Build to run safely under valgrind (often slower)." ON)
 if(USE_VALGRIND)
   find_package(Valgrind REQUIRED)

scripts/run-nightly-coverage-tests.bash

@@ -20,7 +20,6 @@ if [ ! -d build ] ; then
         -D USE_GTAGS=OFF \
         -D USE_CSCOPE=OFF \
         -D USE_ETAGS=OFF \
-        -D USE_BDB=OFF \
         -D USE_GCOV=ON \
         -D CMAKE_LINK_DEPENDS_NO_SHARED=ON \
         -G Ninja \

scripts/run-nightly-drd-tests.bash

@@ -20,7 +20,6 @@ if [ ! -d build ] ; then
         -D USE_GTAGS=OFF \
         -D USE_CSCOPE=OFF \
         -D USE_ETAGS=OFF \
-        -D USE_BDB=OFF \
         -D CMAKE_LINK_DEPENDS_NO_SHARED=ON \
         -G Ninja \
         -D RUN_LONG_TESTS=ON \

scripts/run-nightly-release-tests.bash

@@ -20,7 +20,6 @@ if [ ! -d build ] ; then
         -D USE_GTAGS=OFF \
         -D USE_CSCOPE=OFF \
         -D USE_ETAGS=OFF \
-        -D USE_BDB=ON \
         -D CMAKE_LINK_DEPENDS_NO_SHARED=ON \
         -G Ninja \
         -D RUN_LONG_TESTS=ON \
@@ -41,6 +40,6 @@ ctest -j16 \
     -E '/drd|/helgrind'
 ctest -j16 \
     -D NightlyMemCheck \
-    -E '^ydb/.*\.bdb|test1426\.tdb|/drd|/helgrind'
+    -E 'test1426\.tdb|/drd|/helgrind'
 set -e
 ctest -D NightlySubmit

scripts/run.fractal.tree.tests.cmake

@@ -78,19 +78,16 @@ list(APPEND CTEST_NOTES_FILES
   )
 
 set(all_opts
-  -DBDBDIR=/usr/local/BerkeleyDB.5.3
   -DBUILD_TESTING=ON
   -DUSE_CILK=OFF
   )
 set(rel_opts
   ${all_opts}
   -DCMAKE_BUILD_TYPE=Release
-  -DUSE_BDB=ON
   )
 set(dbg_opts
   ${all_opts}
   -DCMAKE_BUILD_TYPE=Debug
-  -DUSE_BDB=ON
   )
 set(cov_opts
   ${all_opts}

scripts/run.stress-tests.py

@@ -552,7 +552,6 @@ def rebuild(tokudb, builddir, tokudb_data, cc, cxx, tests):
     newenv['CXX'] = cxx
     r = call(['cmake',
               '-DCMAKE_BUILD_TYPE=Debug',
-              '-DUSE_BDB=OFF',
               '-DUSE_GTAGS=OFF',
               '-DUSE_CTAGS=OFF',
               '-DUSE_ETAGS=OFF',