Merge mariadb-10.4.8 to 10.4

cmake/cpack_rpm.cmake

@@ -39,6 +39,7 @@ ELSE()
   SET(CPACK_RPM_FILE_NAME "RPM-DEFAULT")
   OPTION(CPACK_RPM_DEBUGINFO_PACKAGE "" ON)
   MARK_AS_ADVANCED(CPACK_RPM_DEBUGINFO_PACKAGE)
+  SET(CPACK_RPM_BUILD_SOURCE_DIRS_PREFIX "/usr/src/debug/${CPACK_RPM_PACKAGE_NAME}-${VERSION}")
 ENDIF()
 
 SET(CPACK_RPM_PACKAGE_RELEASE "1%{?dist}")
@@ -270,7 +271,6 @@ IF(CMAKE_VERSION VERSION_GREATER "3.9.99")
 SET(CPACK_SOURCE_GENERATOR "RPM")
 SETA(CPACK_RPM_SOURCE_PKG_BUILD_PARAMS
   "-DRPM=${RPM}"
-  "-DCPACK_RPM_BUILD_SOURCE_DIRS_PREFIX=/usr/src/debug/${CPACK_RPM_PACKAGE_NAME}-${VERSION}"
   )
 
 MACRO(ADDIF var)

mysql-test/lib/My/Handles.pm

@@ -24,8 +24,10 @@ use My::Platform;
 
 my $handle_exe;
 
-
-if (IS_WINDOWS){
+sub import {
+  my $self = shift;
+  my $params = shift;
+  return if (!IS_WINDOWS || $handle_exe);
   # Check if handle.exe is available
   # Pass switch to accept the EULA to avoid hanging
   # if the program hasn't been run before.
@@ -35,7 +37,7 @@ if (IS_WINDOWS){
     $handle_exe= "$2.$3"
       if ($line =~ /(Nth|H)andle v([0-9]*)\.([0-9]*)/);
   }
-  if ($handle_exe){
+  if ($handle_exe && (!$params || !$params->{suppress_init_messages})){
     print "Found handle.exe version $handle_exe\n";
   }
 }

mysql-test/main/selectivity.result

@@ -1634,8 +1634,6 @@ SELECT @cnt;
 @cnt
 2
 alter table  t1 force;
-set @@use_stat_tables= @save_use_stat_tables;
-set @@optimizer_use_condition_selectivity=@save_optimizer_use_condition_selectivity;
 drop table t1;
 drop function f1;
 #

mysql-test/main/selectivity.test

@@ -1102,8 +1102,6 @@ set @@optimizer_use_condition_selectivity=4;
 SELECT * FROM t1 WHERE a = f1();
 SELECT @cnt;
 alter table  t1 force;
-set @@use_stat_tables= @save_use_stat_tables;
-set @@optimizer_use_condition_selectivity=@save_optimizer_use_condition_selectivity;
 drop table t1;
 drop function f1;
 

mysql-test/main/selectivity_innodb.result

@@ -1644,8 +1644,6 @@ SELECT @cnt;
 @cnt
 2
 alter table  t1 force;
-set @@use_stat_tables= @save_use_stat_tables;
-set @@optimizer_use_condition_selectivity=@save_optimizer_use_condition_selectivity;
 drop table t1;
 drop function f1;
 #
@@ -1661,19 +1659,19 @@ test.t1	analyze	status	OK
 # Check what info the optimizer has about selectivities
 explain extended select * from t1 use index () where a in (17,51,5);
 id	select_type	table	type	possible_keys	key	key_len	ref	rows	filtered	Extra
-1	SIMPLE	t1	ALL	NULL	NULL	NULL	NULL	1091	3.83	Using where
+1	SIMPLE	t1	ALL	NULL	NULL	NULL	NULL	1000	3.90	Using where
 Warnings:
 Note	1003	select `test`.`t1`.`a` AS `a`,`test`.`t1`.`b` AS `b` from `test`.`t1` USE INDEX () where `test`.`t1`.`a` in (17,51,5)
 explain extended select * from t1 use index () where b=2;
 id	select_type	table	type	possible_keys	key	key_len	ref	rows	filtered	Extra
-1	SIMPLE	t1	ALL	NULL	NULL	NULL	NULL	1091	5.47	Using where
+1	SIMPLE	t1	ALL	NULL	NULL	NULL	NULL	1000	5.47	Using where
 Warnings:
 Note	1003	select `test`.`t1`.`a` AS `a`,`test`.`t1`.`b` AS `b` from `test`.`t1` USE INDEX () where `test`.`t1`.`b` = 2
 # Now, the equality is used for ref access, while the range condition
 # gives selectivity data
 explain extended select * from t1 where a in (17,51,5) and b=2;
 id	select_type	table	type	possible_keys	key	key_len	ref	rows	filtered	Extra
-1	SIMPLE	t1	ref|filter	b,a	b|a	5|5	const	59 (3%)	2.66	Using where; Using rowid filter
+1	SIMPLE	t1	ref|filter	b,a	b|a	5|5	const	59 (3%)	2.90	Using where; Using rowid filter
 Warnings:
 Note	1003	select `test`.`t1`.`a` AS `a`,`test`.`t1`.`b` AS `b` from `test`.`t1` where `test`.`t1`.`b` = 2 and `test`.`t1`.`a` in (17,51,5)
 drop table t1;

mysql-test/suite/mariabackup/big_innodb_log.test

@@ -76,6 +76,7 @@ rmdir $targetdir;
 
 perl;
 use lib "lib";
+use My::Handles { suppress_init_messages => 1 };
 use My::File::Path;
 my $install_db_dir = ($ENV{MTR_PARALLEL} == 1) ?
   "$ENV{'MYSQLTEST_VARDIR'}/install.db" :

mysql-test/suite/mariabackup/disabled.def

-##############################################################################
-#
-#  List the test cases that are to be disabled temporarily.
-#
-#  Separate the test case name and the comment with ':'.
-#
-#    <testcasename> : BUG#<xxxx> <date disabled> <disabler> <comment>
-#
-#  Do not use any TAB characters for whitespace.
-#
-##############################################################################
-big_innodb_log : MDEV-20421 2019-08-26 wlad Always fails on Windows buildbot
\ No newline at end of file

mysql-test/suite/period/r/versioning.result

@@ -87,8 +87,4 @@ x	s	e	if(row_start = @ins_time, "OLD", "NEW")	check_row(row_start, row_end)
 2	1999-01-01	1999-12-12	OLD	CURRENT ROW
 6	2000-01-01	2018-01-01	NEW	CURRENT ROW
 drop table t,log_tbl;
-drop function check_row;
-drop function current_row;
-drop procedure verify_trt;
-drop procedure verify_trt_dummy;
 drop procedure log;

mysql-test/suite/period/t/versioning.test

@@ -57,8 +57,5 @@ select *, if(row_start = @ins_time, "OLD", "NEW"), check_row(row_start, row_end)
        order by x, s, e, row_start;
 
 drop table t,log_tbl;
-drop function check_row;
-drop function current_row;
-drop procedure verify_trt;
-drop procedure verify_trt_dummy;
 drop procedure log;
+source suite/versioning/common_finish.inc;

mysql-test/suite/vcol/r/vcol_sql_mode_upgrade.result

@@ -52,40 +52,66 @@ Warnings:
 Warning	1901	Function or expression '`a`' cannot be used in the GENERATED ALWAYS AS clause of `v`
 Warning	1105	Expression depends on the @@sql_mode value PAD_CHAR_TO_FULL_LENGTH
 CREATE TABLE t2 LIKE t1;
-ERROR HY000: Function or expression '`a`' cannot be used in the GENERATED ALWAYS AS clause of `v`
+Warnings:
+Warning	1901	Function or expression '`a`' cannot be used in the GENERATED ALWAYS AS clause of `v`
+Warning	1105	Expression depends on the @@sql_mode value PAD_CHAR_TO_FULL_LENGTH
+DROP TABLE t2;
 FLUSH TABLES;
 CREATE TABLE t2 LIKE t1;
-ERROR HY000: Function or expression '`a`' cannot be used in the GENERATED ALWAYS AS clause of `v`
+Warnings:
+Warning	1901	Function or expression '`a`' cannot be used in the GENERATED ALWAYS AS clause of `v`
+Warning	1105	Expression depends on the @@sql_mode value PAD_CHAR_TO_FULL_LENGTH
+Warning	1901	Function or expression '`a`' cannot be used in the GENERATED ALWAYS AS clause of `v`
+Warning	1105	Expression depends on the @@sql_mode value PAD_CHAR_TO_FULL_LENGTH
+DROP TABLE t2;
 SHOW CREATE TABLE t1;
 Table	Create Table
 t1	CREATE TABLE `t1` (
   `a` char(5) DEFAULT NULL,
   `v` varchar(5) GENERATED ALWAYS AS (`a`) STORED
 ) ENGINE=MyISAM DEFAULT CHARSET=latin1
+ALTER TABLE t1 ADD b INT DEFAULT a;
 Warnings:
 Warning	1901	Function or expression '`a`' cannot be used in the GENERATED ALWAYS AS clause of `v`
 Warning	1105	Expression depends on the @@sql_mode value PAD_CHAR_TO_FULL_LENGTH
-ALTER TABLE t1 ADD b INT DEFAULT a;
-ERROR HY000: Function or expression '`a`' cannot be used in the GENERATED ALWAYS AS clause of `v`
+Warning	1901	Function or expression '`a`' cannot be used in the GENERATED ALWAYS AS clause of `v`
+Warning	1105	Expression depends on the @@sql_mode value PAD_CHAR_TO_FULL_LENGTH
+Warning	1901	Function or expression '`a`' cannot be used in the GENERATED ALWAYS AS clause of `v`
+Warning	1105	Expression depends on the @@sql_mode value PAD_CHAR_TO_FULL_LENGTH
 SHOW CREATE TABLE t1;
 Table	Create Table
 t1	CREATE TABLE `t1` (
   `a` char(5) DEFAULT NULL,
-  `v` varchar(5) GENERATED ALWAYS AS (`a`) STORED
+  `v` varchar(5) GENERATED ALWAYS AS (`a`) STORED,
+  `b` int(11) DEFAULT `a`
 ) ENGINE=MyISAM DEFAULT CHARSET=latin1
+Warnings:
+Warning	1901	Function or expression '`a`' cannot be used in the GENERATED ALWAYS AS clause of `v`
+Warning	1105	Expression depends on the @@sql_mode value PAD_CHAR_TO_FULL_LENGTH
 SELECT * FROM t1;
-a	v
-1	1
-2	2
-3	3
+a	v	b
+1	1	1
+2	2	2
+3	3	3
 FLUSH TABLES;
 ALTER TABLE t1 ADD c INT DEFAULT a;
-ERROR HY000: Function or expression '`a`' cannot be used in the GENERATED ALWAYS AS clause of `v`
+Warnings:
+Warning	1901	Function or expression '`a`' cannot be used in the GENERATED ALWAYS AS clause of `v`
+Warning	1105	Expression depends on the @@sql_mode value PAD_CHAR_TO_FULL_LENGTH
+Warning	1901	Function or expression '`a`' cannot be used in the GENERATED ALWAYS AS clause of `v`
+Warning	1105	Expression depends on the @@sql_mode value PAD_CHAR_TO_FULL_LENGTH
+Warning	1901	Function or expression '`a`' cannot be used in the GENERATED ALWAYS AS clause of `v`
+Warning	1105	Expression depends on the @@sql_mode value PAD_CHAR_TO_FULL_LENGTH
+Warning	1901	Function or expression '`a`' cannot be used in the GENERATED ALWAYS AS clause of `v`
+Warning	1105	Expression depends on the @@sql_mode value PAD_CHAR_TO_FULL_LENGTH
 SELECT * FROM t1;
-a	v
-1	1
-2	2
-3	3
+a	v	b	c
+1	1	1	1
+2	2	2	2
+3	3	3	3
+Warnings:
+Warning	1901	Function or expression '`a`' cannot be used in the GENERATED ALWAYS AS clause of `v`
+Warning	1105	Expression depends on the @@sql_mode value PAD_CHAR_TO_FULL_LENGTH
 DROP TABLE t1;
 #
 # Fixing a Maria-10.2.26 table with a stored VARCHAR column
@@ -177,10 +203,18 @@ Warnings:
 Warning	1901	Function or expression '`a`' cannot be used in the GENERATED ALWAYS AS clause of `v`
 Warning	1105	Expression depends on the @@sql_mode value PAD_CHAR_TO_FULL_LENGTH
 CREATE TABLE t2 LIKE t1;
-ERROR HY000: Function or expression '`a`' cannot be used in the GENERATED ALWAYS AS clause of `v`
+Warnings:
+Warning	1901	Function or expression '`a`' cannot be used in the GENERATED ALWAYS AS clause of `v`
+Warning	1105	Expression depends on the @@sql_mode value PAD_CHAR_TO_FULL_LENGTH
+DROP TABLE t2;
 FLUSH TABLES;
 CREATE TABLE t2 LIKE t1;
-ERROR HY000: Function or expression '`a`' cannot be used in the GENERATED ALWAYS AS clause of `v`
+Warnings:
+Warning	1901	Function or expression '`a`' cannot be used in the GENERATED ALWAYS AS clause of `v`
+Warning	1105	Expression depends on the @@sql_mode value PAD_CHAR_TO_FULL_LENGTH
+Warning	1901	Function or expression '`a`' cannot be used in the GENERATED ALWAYS AS clause of `v`
+Warning	1105	Expression depends on the @@sql_mode value PAD_CHAR_TO_FULL_LENGTH
+DROP TABLE t2;
 SHOW CREATE TABLE t1;
 Table	Create Table
 t1	CREATE TABLE `t1` (
@@ -188,19 +222,33 @@ t1	CREATE TABLE `t1` (
   `v` varchar(5) GENERATED ALWAYS AS (`a`) VIRTUAL,
   KEY `v` (`v`)
 ) ENGINE=MyISAM DEFAULT CHARSET=latin1
+ALTER TABLE t1 ADD b INT DEFAULT a;
 Warnings:
 Warning	1901	Function or expression '`a`' cannot be used in the GENERATED ALWAYS AS clause of `v`
 Warning	1105	Expression depends on the @@sql_mode value PAD_CHAR_TO_FULL_LENGTH
-ALTER TABLE t1 ADD b INT DEFAULT a;
-ERROR HY000: Function or expression '`a`' cannot be used in the GENERATED ALWAYS AS clause of `v`
+Warning	1901	Function or expression '`a`' cannot be used in the GENERATED ALWAYS AS clause of `v`
+Warning	1105	Expression depends on the @@sql_mode value PAD_CHAR_TO_FULL_LENGTH
+Warning	1901	Function or expression '`a`' cannot be used in the GENERATED ALWAYS AS clause of `v`
+Warning	1105	Expression depends on the @@sql_mode value PAD_CHAR_TO_FULL_LENGTH
 FLUSH TABLES;
 ALTER TABLE t1 ADD c INT DEFAULT a;
-ERROR HY000: Function or expression '`a`' cannot be used in the GENERATED ALWAYS AS clause of `v`
+Warnings:
+Warning	1901	Function or expression '`a`' cannot be used in the GENERATED ALWAYS AS clause of `v`
+Warning	1105	Expression depends on the @@sql_mode value PAD_CHAR_TO_FULL_LENGTH
+Warning	1901	Function or expression '`a`' cannot be used in the GENERATED ALWAYS AS clause of `v`
+Warning	1105	Expression depends on the @@sql_mode value PAD_CHAR_TO_FULL_LENGTH
+Warning	1901	Function or expression '`a`' cannot be used in the GENERATED ALWAYS AS clause of `v`
+Warning	1105	Expression depends on the @@sql_mode value PAD_CHAR_TO_FULL_LENGTH
+Warning	1901	Function or expression '`a`' cannot be used in the GENERATED ALWAYS AS clause of `v`
+Warning	1105	Expression depends on the @@sql_mode value PAD_CHAR_TO_FULL_LENGTH
 SELECT * FROM t1;
-a	v
-1	1
-2	2
-3	3
+a	v	b	c
+1	1	1	1
+2	2	2	2
+3	3	3	3
+Warnings:
+Warning	1901	Function or expression '`a`' cannot be used in the GENERATED ALWAYS AS clause of `v`
+Warning	1105	Expression depends on the @@sql_mode value PAD_CHAR_TO_FULL_LENGTH
 DROP TABLE t1;
 #
 # Fixing a Maria-10.2.26 table with a virtual VARCHAR column

mysql-test/suite/vcol/t/vcol_sql_mode.test

@@ -21,21 +21,25 @@ DROP TABLE t1;
 CREATE TABLE t1 (a CHAR(5), v TIME AS (a) VIRTUAL, KEY(v));
 DROP TABLE t1;
 
---error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
+#--error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
 CREATE TABLE t1 (c CHAR(8), v BINARY(8) AS (c), KEY(v));
 SHOW WARNINGS;
+DROP TABLE t1;
 
---error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
+#--error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
 CREATE TABLE t1 (a CHAR(5), v BIT(64) AS (a) VIRTUAL, KEY(v));
 SHOW WARNINGS;
+DROP TABLE t1;
 
---error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
+#--error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
 CREATE TABLE t1 (a CHAR(5), v VARCHAR(5) AS (a) VIRTUAL, KEY(v));
 SHOW WARNINGS;
+DROP TABLE t1;
 
---error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
+#--error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
 CREATE TABLE t1 (a CHAR(5), v TEXT AS (a) VIRTUAL, KEY(v(100)));
 SHOW WARNINGS;
+DROP TABLE t1;
 
 
 --echo # PAD_CHAR_TO_FULL_LENGTH + TRIM resolving dependency
@@ -75,52 +79,61 @@ DROP TABLE t1;
 
 --echo # PAD_CHAR_TO_FULL_LENGTH + TRIM not resolving dependency
 
---error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
+#--error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
 CREATE TABLE t1 (a CHAR(5), v VARCHAR(5) AS (TRIM(LEADING ' ' FROM a)) VIRTUAL, KEY(v));
 SHOW WARNINGS;
+DROP TABLE t1;
 
---error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
+#--error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
 CREATE TABLE t1 (a CHAR(5), v TEXT AS (TRIM(LEADING ' ' FROM a)) VIRTUAL, KEY(v(100)));
 SHOW WARNINGS;
+DROP TABLE t1;
 
---error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
+#--error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
 CREATE TABLE t1 (a CHAR(5), v VARCHAR(5) AS (TRIM(TRAILING '' FROM a)) VIRTUAL, KEY(v));
 SHOW WARNINGS;
+DROP TABLE t1;
 
---error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
+#--error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
 CREATE TABLE t1 (a CHAR(5), v VARCHAR(5) AS (TRIM(BOTH '' FROM a)) VIRTUAL, KEY(v));
 SHOW WARNINGS;
+DROP TABLE t1;
 
---error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
+#--error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
 CREATE TABLE t1 (a CHAR(5), v VARCHAR(5) AS (TRIM(TRAILING 'x' FROM a)) VIRTUAL, KEY(v));
 SHOW WARNINGS;
+DROP TABLE t1;
 
---error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
+#--error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
 CREATE TABLE t1 (a CHAR(5), v VARCHAR(5) AS (TRIM(BOTH 'x' FROM a)) VIRTUAL, KEY(v));
 SHOW WARNINGS;
+DROP TABLE t1;
 
---error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
 # more than one space
+#--error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
 CREATE TABLE t1 (
   a CHAR(5),
   v VARCHAR(5) AS (TRIM(TRAILING '  ' FROM a)) VIRTUAL, KEY(v));
 SHOW WARNINGS;
+DROP TABLE t1;
 
---error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
 # more than one space
+#--error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
 CREATE TABLE t1 (
   a CHAR(5),
   v VARCHAR(5) AS (TRIM(BOTH '  ' FROM a)) VIRTUAL, KEY(v));
 SHOW WARNINGS;
+DROP TABLE t1;
 
 
 --echo # PAD_CHAR_TO_FULL_LENGTH + TRIM(... non_constant FROM a)
---error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
+#--error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
 CREATE TABLE t1 (
   a CHAR(5),
   b CHAR(5),
   v TEXT AS (TRIM(TRAILING b FROM a)) VIRTUAL, KEY(v(100)));
 SHOW WARNINGS;
+DROP TABLE t1;
 
 
 --echo # PAD_CHAR_TO_FULL_LENGTH + RPAD resolving dependency
@@ -144,11 +157,12 @@ DROP TABLE t1;
 
 --echo # PAD_CHAR_TO_FULL_LENGTH + RPAD not resolving dependency
 
---error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
+#--error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
 CREATE TABLE t1 (a CHAR(5), v VARCHAR(5) AS (RPAD(a,4,' ')) VIRTUAL, KEY(v));
 SHOW WARNINGS;
+DROP TABLE t1;
 
---error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
+#--error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
 CREATE TABLE t1 (
   a CHAR(5),
   b CHAR(5),
@@ -156,6 +170,7 @@ CREATE TABLE t1 (
   KEY(v)
 );
 SHOW WARNINGS;
+DROP TABLE t1;
 
 
 --echo # PAD_CHAR_TO_FULL_LENGTH + comparison
@@ -164,12 +179,13 @@ CREATE TABLE t1 (a CHAR(5), v INT AS (a='a') VIRTUAL, KEY(v));
 SHOW CREATE TABLE t1;
 DROP TABLE t1;
 
---error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
+#--error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
 CREATE TABLE t1 (
    a CHAR(5) CHARACTER SET latin1 COLLATE latin1_nopad_bin,
    v INT AS (a='a') VIRTUAL, KEY(v)
 );
 SHOW WARNINGS;
+DROP TABLE t1;
 
 
 --echo # PAD_CHAR_TO_FULL_LENGTH + LIKE
@@ -182,23 +198,25 @@ CREATE TABLE t1 (a CHAR(5), v INT AS (a LIKE NULL) VIRTUAL, KEY(v));
 SHOW CREATE TABLE t1;
 DROP TABLE t1;
 
---error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
+#--error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
 CREATE TABLE t1 (a CHAR(5), v INT AS (a LIKE 'a') VIRTUAL, KEY(v));
 SHOW WARNINGS;
+DROP TABLE t1;
 
 
 --echo # PAD_CHAR_TO_FULL_LENGTH + LENGTH(char_column) = hard dependency
 
---error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
+#--error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
 CREATE TABLE t1 (a CHAR(5), v INT AS (LENGTH(a)) VIRTUAL, KEY(v));
 SHOW WARNINGS;
+DROP TABLE t1;
 
 
 --echo #
 --echo # Testing NO_UNSIGNED_SUBTRACTION
 --echo #
 
---error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
+#--error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
 CREATE TABLE t1 (
   a INT UNSIGNED,
   b INT UNSIGNED,
@@ -206,8 +224,9 @@ CREATE TABLE t1 (
   KEY (c)
 );
 SHOW WARNINGS;
+DROP TABLE t1;
 
---error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
+#--error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
 CREATE TABLE t1 (
   a INT UNSIGNED,
   b INT UNSIGNED,
@@ -215,8 +234,9 @@ CREATE TABLE t1 (
   KEY (c)
 );
 SHOW WARNINGS;
+DROP TABLE t1;
 
---error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
+#--error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
 CREATE TABLE t1 (
   a INT UNSIGNED,
   b INT UNSIGNED,
@@ -224,6 +244,7 @@ CREATE TABLE t1 (
   KEY (c)
 );
 SHOW WARNINGS;
+DROP TABLE t1;
 
 CREATE TABLE t1 (
   a INT UNSIGNED,
@@ -250,7 +271,7 @@ DROP TABLE t1;
 --echo # Comnination: PAD_CHAR_TO_FULL_LENGTH + NO_UNSIGNED_SUBTRACTION
 --echo #
 
---error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
+#--error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
 CREATE TABLE t1 (
   a INT UNSIGNED,
   b INT UNSIGNED,
@@ -259,13 +280,14 @@ CREATE TABLE t1 (
   KEY (v)
 );
 SHOW WARNINGS;
+DROP TABLE t1;
 
 
 # The below solves the dependency on NO_UNSIGNED_SUBTRACTION
 # but does not solve the dependency on PAD_CHAR_TO_FULL_LENGTH,
 # because the 'length' argument to RPAD() is not a constant.
 
---error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
+#--error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
 CREATE TABLE t1 (
   a INT UNSIGNED,
   b INT UNSIGNED,
@@ -274,6 +296,7 @@ CREATE TABLE t1 (
   KEY (v)
 );
 SHOW WARNINGS;
+DROP TABLE t1;
 
 
 
@@ -291,10 +314,12 @@ CREATE TABLE t1 (
   c CHAR(5),
   v VARCHAR(5) GENERATED ALWAYS AS (c) VIRTUAL
 );
---error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
+#--error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
 ALTER TABLE t1 ADD KEY(v);
 SHOW WARNINGS;
---error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
+ALTER TABLE t1 DROP KEY v;
+
+#--error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
 CREATE INDEX v ON t1 (v);
 SHOW WARNINGS;
 DROP TABLE t1;
@@ -302,16 +327,18 @@ DROP TABLE t1;
 
 --echo # A virtual column on the second position in an index - cannot depend on sql_mode
 
---error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
+#--error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
 CREATE TABLE t1 (id int, a CHAR(5), v TEXT AS (a) VIRTUAL, KEY(id, v(100)));
 SHOW WARNINGS;
+DROP TABLE t1;
 
 
 --echo # A persisten virtual column cannot depend on sql_mode
 
---error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
+#--error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
 CREATE TABLE t1 (a CHAR(5), v VARCHAR(5) AS (a) PERSISTENT);
 SHOW WARNINGS;
+DROP TABLE t1;
 
 CREATE TABLE t1 (a CHAR(5), v VARCHAR(5) AS (RTRIM(a)) PERSISTENT);
 SHOW CREATE TABLE t1;

mysql-test/suite/vcol/t/vcol_sql_mode_upgrade.test

@@ -25,19 +25,21 @@ SELECT * FROM t1;
 FLUSH TABLES;
 SELECT * FROM t1;
 
---error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
+#--error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
 CREATE TABLE t2 LIKE t1;
+DROP TABLE t2;
 FLUSH TABLES;
---error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
+#--error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
 CREATE TABLE t2 LIKE t1;
+DROP TABLE t2;
 
 SHOW CREATE TABLE t1;
---error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
+#--error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
 ALTER TABLE t1 ADD b INT DEFAULT a;
 SHOW CREATE TABLE t1;
 SELECT * FROM t1;
 FLUSH TABLES;
---error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
+#--error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
 ALTER TABLE t1 ADD c INT DEFAULT a;
 SELECT * FROM t1;
 DROP TABLE t1;
@@ -90,18 +92,20 @@ SELECT * FROM t1;
 FLUSH TABLES;
 SELECT * FROM t1;
 
---error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
+#--error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
 CREATE TABLE t2 LIKE t1;
+DROP TABLE t2;
 FLUSH TABLES;
---error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
+#--error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
 CREATE TABLE t2 LIKE t1;
+DROP TABLE t2;
 
 
 SHOW CREATE TABLE t1;
---error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
+#--error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
 ALTER TABLE t1 ADD b INT DEFAULT a;
 FLUSH TABLES;
---error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
+#--error ER_GENERATED_COLUMN_FUNCTION_IS_NOT_ALLOWED
 ALTER TABLE t1 ADD c INT DEFAULT a;
 SELECT * FROM t1;
 DROP TABLE t1;

mysql-test/unstable-tests

@@ -23,7 +23,7 @@
 #
 ##############################################################################
 #
-# Based on 10.4 c1a2778e689030fcbb6cdc93d8c1f1d85024ed28
+# Based on bb-10.4-release 8885e7ba7814b5721bcf1a6c5241aea815a80eb9
 
 main.alter_table                      : Modified in 10.4.8
 main.alter_table_mdev539_maria        : Include file modified in 10.4.8
@@ -800,7 +800,7 @@ perfschema_stress.* : MDEV-10996 - Not maintained
 
 #-----------------------------------------------------------------------
 
-period.versioning : MDEV-20159 - Assertion failure; include file modified in 10.4.8
+period.versioning : MDEV-20159 - Assertion failure; modified in 10.4.8
 
 #-----------------------------------------------------------------------
 

sql/table.cc

@@ -3778,6 +3778,7 @@ enum open_frm_error open_table_from_share(THD *thd, TABLE_SHARE *share,
       outparam->check_constraints= check_constraint_ptr;
 
     vcol_init_mode mode= VCOL_INIT_DEPENDENCY_FAILURE_IS_WARNING;
+#if MYSQL_VERSION_ID > 100500
     switch (thd->lex->sql_command)
     {
     case SQLCOM_CREATE_TABLE:
@@ -3792,9 +3793,10 @@ enum open_frm_error open_table_from_share(THD *thd, TABLE_SHARE *share,
     default:
       break;
     }
+#endif
 
-    if (unlikely(parse_vcol_defs(thd, &outparam->mem_root, outparam,
-                                 &error_reported, mode)))
+    if (parse_vcol_defs(thd, &outparam->mem_root, outparam,
+                        &error_reported, mode))
     {
       error= OPEN_FRM_CORRUPTED;
       goto err;

storage/innobase/fsp/fsp0fsp.cc

@@ -2758,7 +2758,6 @@ fseg_free_page_low(
 	ulint	state;
 	ib_id_t	descr_id;
 	ib_id_t	seg_id;
-	ulint	i;
 
 	ut_ad(seg_inode != NULL);
 	ut_ad(mtr != NULL);
@@ -2794,7 +2793,7 @@ fseg_free_page_low(
 	if (state != XDES_FSEG) {
 		/* The page is in the fragment pages of the segment */
 
-		for (i = 0;; i++) {
+		for (ulint i = 0;; i++) {
 			if (fseg_get_nth_frag_page_no(seg_inode, i, mtr)
 			    == offset) {
 
@@ -2954,7 +2953,6 @@ fseg_free_extent(
 	xdes_t*	descr;
 	ulint	not_full_n_used;
 	ulint	descr_n_used;
-	ulint	i;
 
 	ut_ad(mtr != NULL);
 
@@ -2970,7 +2968,7 @@ fseg_free_extent(
 
 #ifdef BTR_CUR_HASH_ADAPT
 	if (ahi) {
-		for (i = 0; i < FSP_EXTENT_SIZE; i++) {
+		for (ulint i = 0; i < FSP_EXTENT_SIZE; i++) {
 			if (!xdes_mtr_get_bit(descr, XDES_FREE_BIT, i, mtr)) {
 
 				/* Drop search system page hash index
@@ -3008,7 +3006,7 @@ fseg_free_extent(
 	fsp_free_extent(space, page, mtr);
 
 #ifdef UNIV_DEBUG
-	for (i = 0; i < FSP_EXTENT_SIZE; i++) {
+	for (ulint i = 0; i < FSP_EXTENT_SIZE; i++) {
 
 		buf_page_set_file_page_was_freed(
 			page_id_t(space->id, first_page_in_extent + i));

storage/rocksdb/mysql-test/rocksdb/r/ttl_primary_read_filtering.result

@@ -76,6 +76,7 @@ select variable_value-@a from information_schema.global_status where variable_na
 variable_value-@a
 4
 DROP TABLE t1;
+set global ROCKSDB_COMPACT_CF= 'default';
 CREATE TABLE t1 (
 a int,
 b int,

storage/rocksdb/mysql-test/rocksdb/suite.pm

@@ -11,7 +11,7 @@ use My::Find;
 use File::Basename;
 use strict;
 
-sub is_default { not $::opt_embedded_server }
+#sub is_default { not $::opt_embedded_server }
 
 my $sst_dump=
 ::mtr_exe_maybe_exists(

storage/rocksdb/mysql-test/rocksdb/t/ttl_primary_read_filtering.test

@@ -102,6 +102,8 @@ SELECT * FROM t1;
 select variable_value-@a from information_schema.global_status where variable_name='rocksdb_rows_filtered';
 
 DROP TABLE t1;
+# Compact away the dropped data
+set global ROCKSDB_COMPACT_CF= 'default';
 
 # Read filtering index scan tests (None of these queries should return any results)
 CREATE TABLE t1 (

storage/rocksdb/mysql-test/rocksdb_rpl/suite.pm

@@ -9,7 +9,7 @@ use My::Find;
 use File::Basename;
 use strict;
 
-sub is_default { not $::opt_embedded_server }
+#sub is_default { not $::opt_embedded_server }
 
 my $sst_dump=
 ::mtr_exe_maybe_exists(

storage/rocksdb/mysql-test/rocksdb_stress/suite.pm

@@ -11,7 +11,7 @@ use My::Find;
 use File::Basename;
 use strict;
 
-sub is_default { not $::opt_embedded_server }
+#sub is_default { not $::opt_embedded_server }
 
 my $sst_dump=
 ::mtr_exe_maybe_exists(

storage/rocksdb/mysql-test/rocksdb_sys_vars/suite.pm

@@ -8,7 +8,7 @@ use My::Find;
 use File::Basename;
 use strict;
 
-sub is_default { not $::opt_embedded_server }
+#sub is_default { not $::opt_embedded_server }
 
 my $sst_dump=
 ::mtr_exe_maybe_exists(