Commit f424eb97 authored by Marko Mäkelä's avatar Marko Mäkelä

Clean up the merge of MDEV-22494

The merge commit f2a94451
included some incorrect conflict resolution and left
an unused function wsrep_abort_slave_trx().

Also, we will clean up wsrep_innobase_kill_one_trx() a little.
parent 4cbfdeca
...@@ -18682,24 +18682,6 @@ static struct st_mysql_storage_engine innobase_storage_engine= ...@@ -18682,24 +18682,6 @@ static struct st_mysql_storage_engine innobase_storage_engine=
{ MYSQL_HANDLERTON_INTERFACE_VERSION }; { MYSQL_HANDLERTON_INTERFACE_VERSION };
#ifdef WITH_WSREP #ifdef WITH_WSREP
void
wsrep_abort_slave_trx(
/*==================*/
wsrep_seqno_t bf_seqno,
wsrep_seqno_t victim_seqno)
{
WSREP_ERROR("Trx %lld tries to abort slave trx %lld. This could be "
"caused by:\n\t"
"1) unsupported configuration options combination, please check documentation.\n\t"
"2) a bug in the code.\n\t"
"3) a database corruption.\n Node consistency compromized, "
"need to abort. Restart the node to resync with cluster.",
(long long)bf_seqno, (long long)victim_seqno);
abort();
}
/*******************************************************************//**
This function is used to kill one transaction in BF. */
/** This function is used to kill one transaction. /** This function is used to kill one transaction.
...@@ -18724,10 +18706,7 @@ comparison as in the local certification failure. ...@@ -18724,10 +18706,7 @@ comparison as in the local certification failure.
@param[in] bf_thd Brute force (BF) thread @param[in] bf_thd Brute force (BF) thread
@param[in,out] victim_trx Vimtim trx to be killed @param[in,out] victim_trx Vimtim trx to be killed
@param[in] signal Should victim be signaled */ @param[in] signal Should victim be signaled */
UNIV_INTERN int wsrep_innobase_kill_one_trx(THD *bf_thd, trx_t *victim_trx, bool signal)
int
wsrep_innobase_kill_one_trx(THD* bf_thd, trx_t *victim_trx,
bool signal)
{ {
ut_ad(bf_thd); ut_ad(bf_thd);
ut_ad(victim_trx); ut_ad(victim_trx);
...@@ -18736,7 +18715,7 @@ wsrep_innobase_kill_one_trx(THD* bf_thd, trx_t *victim_trx, ...@@ -18736,7 +18715,7 @@ wsrep_innobase_kill_one_trx(THD* bf_thd, trx_t *victim_trx,
DBUG_ENTER("wsrep_innobase_kill_one_trx"); DBUG_ENTER("wsrep_innobase_kill_one_trx");
THD *thd= (THD *) victim_trx->mysql_thd; THD *thd= victim_trx->mysql_thd;
ut_ad(thd); ut_ad(thd);
/* Note that bf_trx might not exist here e.g. on MDL conflict /* Note that bf_trx might not exist here e.g. on MDL conflict
case (test: galera_concurrent_ctas). Similarly, BF thread case (test: galera_concurrent_ctas). Similarly, BF thread
......
...@@ -226,9 +226,7 @@ innobase_casedn_str( ...@@ -226,9 +226,7 @@ innobase_casedn_str(
char* a); /*!< in/out: string to put in lower case */ char* a); /*!< in/out: string to put in lower case */
#ifdef WITH_WSREP #ifdef WITH_WSREP
int int wsrep_innobase_kill_one_trx(THD *bf_thd, trx_t *victim_trx, bool signal);
wsrep_innobase_kill_one_trx(THD *bf_thd, trx_t *victim_trx,
bool signal);
ulint wsrep_innobase_mysql_sort(int mysql_type, uint charset_number, ulint wsrep_innobase_mysql_sort(int mysql_type, uint charset_number,
unsigned char* str, ulint str_length, unsigned char* str, ulint str_length,
unsigned int buf_length); unsigned int buf_length);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment