An error occurred fetching the project authors.
  1. 17 Sep, 2021 3 commits
  2. 16 Sep, 2021 1 commit
    • Eugene Kosov's avatar
      MDEV-26621 assertion failue "index->table->persistent_autoinc" in... · 5b0a7607
      Eugene Kosov authored
      MDEV-26621 assertion failue "index->table->persistent_autoinc" in /storage/innobase/btr/btr0btr.cc during IMPORT
      
      dict_index_t::clear_instant_alter(): when searhing for an AUTO_INCREMENT column
      don't skip the beginning of the list because the field can be at the beginning of the list
      5b0a7607
  3. 14 Sep, 2021 3 commits
    • Monty's avatar
      MDEV-23519 Protocol packet - "Original Name" info is showing alias name, · 689b8d06
      Monty authored
      instead of original name of the column
      
      When doing refactoring of temporary table field creation a mistake was
      done when copying the column name when creating internal temporary tables.
      For internal temporary tables we should use the original field name, not
      the item name (= alias).
      689b8d06
    • Daniel Black's avatar
      MDEV-26601: mysys - O_TMPFILE ^ O_CREAT · adaf0dde
      Daniel Black authored
      Thanks to Fabian Vogt for noticing the mutual exclusions
      of these open flags on tmpfs caused by mariadb opening it
      incorrectly.
      
      As such we clear the O_CREAT flag while opening it as O_TMPFILE.
      adaf0dde
    • Daniele Sciascia's avatar
      MDEV-21613 Failed to open table mysql.wsrep_streaming_log for writing · 5527fc58
      Daniele Sciascia authored
      Fix sporadic failure for MTR test galera_sr.GCF-1018B. The test
      sometimes fails due to an error that is logged to the error log
      unnecessarily.
      A deterministic test case (included in this patch) shows that the
      error is loggen when a transaction is BF aborted right before  it
      opens the streaming log table to perform fragment removal. When that
      happens, the attempt to open the table fails and consequently an error
      is logged. There is no need to log this error, as an ER_LOCK_DEADLOCK
      error is returned to the client.
      Reviewed-by: default avatarJan Lindström <jan.lindstrom@mariadb.com>
      5527fc58
  4. 11 Sep, 2021 10 commits
  5. 10 Sep, 2021 3 commits
    • Marko Mäkelä's avatar
      MDEV-26537 InnoDB corrupts files due to incorrect st_blksize calculation · d09426f9
      Marko Mäkelä authored
      The st_blksize returned by fstat(2) is not documented to be
      a power of 2, like we assumed in
      commit 58252fff (MDEV-26040).
      While on Linux, the st_blksize appears to report the file system
      block size (which hopefully is not smaller than the sector size
      of the underlying block device), on FreeBSD we observed
      st_blksize values that might have been something similar to st_size.
      
      Also IBM AIX was affected by this. A simple test case would
      lead to a crash when using the minimum innodb_buffer_pool_size=5m
      on both FreeBSD and AIX:
      
      seq -f 'create table t%g engine=innodb select * from seq_1_to_200000;' \
      1 100|mysql test&
      seq -f 'create table u%g engine=innodb select * from seq_1_to_200000;' \
      1 100|mysql test&
      
      We will fix this by not trusting st_blksize at all, and assuming that
      the smallest allowed write size (for O_DIRECT) is 4096 bytes. We hope
      that no storage systems with larger block size exist. Anything larger
      than 4096 bytes should be unlikely, given that it is the minimum
      virtual memory page size of many contemporary processors.
      
      MariaDB Server on Microsoft Windows was not affected by this.
      
      While the 512-byte sector size of the venerable Seagate ST-225 is still
      in widespread use, the minimum innodb_page_size is 4096 bytes, and
      innodb_log_file_size can be set in integer multiples of 65536 bytes.
      
      The only occasion where InnoDB uses smaller data file block sizes than
      4096 bytes is with ROW_FORMAT=COMPRESSED tables with KEY_BLOCK_SIZE=1
      or KEY_BLOCK_SIZE=2 (or innodb_page_size=4096). For such tables,
      we will from now on preallocate space in integer multiples of 4096 bytes
      and let regular writes extend the file by 1024, 2048, or 3072 bytes.
      
      The view INFORMATION_SCHEMA.INNODB_SYS_TABLESPACES.FS_BLOCK_SIZE
      should report the raw st_blksize.
      
      For page_compressed tables, the function fil_space_get_block_size()
      will map to 512 any st_blksize value that is larger than 4096.
      
      os_file_set_size(): Assume that the file system block size is 4096 bytes,
      and only support extending files to integer multiples of 4096 bytes.
      
      fil_space_extend_must_retry(): Round down the preallocation size to
      an integer multiple of 4096 bytes.
      d09426f9
    • Eugene Kosov's avatar
      MDEV-25951 followup · 4f85eadf
      Eugene Kosov authored
      FTS indexes has a prefix_len=1 or prefix_len=0 as stated by comment in
      mysql_prepare_create_table().
      
      Thus, a newly added assertion should be relaxed for FTS indexes.
      4f85eadf
    • Vladislav Vaintroub's avatar
      Speedup build of the MSI package · 1c378f1b
      Vladislav Vaintroub authored
      1c378f1b
  6. 09 Sep, 2021 5 commits
  7. 08 Sep, 2021 1 commit
    • Eugene Kosov's avatar
      MDEV-25951 MariaDB crash after ALTER TABLE convert to utf8mb4 · a4b3970c
      Eugene Kosov authored
      Bug happens when partially indexed CHAR or VARCHAR field in converted from
      utf8mb3 to utf8mb4.
      
      Fixing by relaxing assertions. For some time dict_index_t and dict_table_t
      are becoming not synchronized. Namely, dict_index_t has a new prefix_len which
      is a multiple of a user-provided length and charset->mbmaxlen. But
      the table still have and old mbmaxlen and assertion fails. This happens only
      during utf8mb3 -> utf8mb4 conversions and the magic number 4 comes from
      utf8mb_4_.
      
      At the end of ALTER TABLE (innobase_rename_or_enlarge_columns_cache())
      dict_index_t and dict_table_t became synchronized
      again and will stay so at all times. For, example, they will be synchronized
      on table load and newly added assertion proves that.
      a4b3970c
  8. 07 Sep, 2021 8 commits
  9. 06 Sep, 2021 4 commits
  10. 05 Sep, 2021 2 commits
    • Daniel Black's avatar
      MDEV-12055 binlog.binlog_stm_ctype_ucs postfix · 38648bbb
      Daniel Black authored
      As highlighted in https://bugs.gentoo.org/807995,
      people occasionaly run tests in the 20:00->23:59:59 time range.
      
      Fixes 265e3253
      
      binlog.binlog_stm_ctype_ucs 'mix'        w1 [ fail ]
              Test ended at 2021-08-11 22:55:35
      
      CURRENT_TEST: binlog.binlog_stm_ctype_ucs
      --- /var/tmp/portage/dev-db/mariadb-10.5.11/work/mysql/mysql-test/suite/binlog/r/binlog_stm_ctype_ucs.result    2021-06-18 18:19:11.000000000 +0800
      +++ /var/tmp/portage/dev-db/mariadb-10.5.11/work/mysql/mysql-test/suite/binlog/r/binlog_stm_ctype_ucs.reject    2021-08-11 22:55:34.993447479 +0800
      @@ -76,21 +76,21 @@
       /*!50003 SET @OLD_COMPLETION_TYPE=@@COMPLETION_TYPE,COMPLETION_TYPE=0*/;
       DELIMITER /*!*/;
       # at #
      -#YYMMDD HH:MM:SS server id #  end_log_pos # CRC32 XXX  Start: binlog v 4, server v #.##.## created YYMMDD HH:MM:SS
      +#210811 22:55:34 server id #  end_log_pos # CRC32 XXX  Start: binlog v 4, server v #.##.## created 210811 22:55:34
      38648bbb
    • Daniel Black's avatar
      MDEV-26529: binlog.binlog_flush_binlogs_delete_domain fails on RISC-V · 21d31b99
      Daniel Black authored
      Per https://bugs.gentoo.org/807995
      
      The test failed with:
      
      CURRENT_TEST: binlog.binlog_flush_binlogs_delete_domain
      — /tmp/mariadb-10.5.11/mysql-test/suite/binlog/r/binlog_flush_binlogs_delete_domain.result 2021-06-18 18:19:11.000000000 +0800
      +++ /tmp/mariadb-10.5.11/mysql-test/suite/binlog/r/binlog_flush_binlogs_delete_domain.reject 2021-09-01 22:55:29.406655479 +0800
      @@ -85,6 +85,6 @@
      ERROR HY000: The value of gtid domain being deleted ('4294967296') exceeds its maximum size of 32 bit unsigned integer
      FLUSH BINARY LOGS DELETE_DOMAIN_ID = (4294967295);
      Warnings:
      -Warning 1076 The gtid domain being deleted ('4294967295') is not in the current binlog state
      +Warning 1076 The gtid domain being deleted ('18446744073709551615') is not in the current binlog state
      DROP TABLE t;
      RESET MASTER;
      
      mysqltest: Result length mismatch
      
      ptr_domain_id is a uint32* so explicitly cast this when printing it out.
      
      Thanks Marek Szuba for the bug report and testing the patch.
      21d31b99