1. 26 Jan, 2021 1 commit
  2. 25 Jan, 2021 8 commits
  3. 23 Jan, 2021 2 commits
    • Marko Mäkelä's avatar
      MDEV-24661: Disable an unstable test · 5adcb2e7
      Marko Mäkelä authored
      5adcb2e7
    • Marko Mäkelä's avatar
      MDEV-24659 Assertion !fsp_is_system_temporary(bpage->id().space()) failed in... · 84b8f529
      Marko Mäkelä authored
      MDEV-24659 Assertion !fsp_is_system_temporary(bpage->id().space()) failed in buf_flush_relocate_on_flush_list()
      
      When commit 5eb53955 (MDEV-12227)
      removed the pages of temporary tables from the buf_pool.flush_list,
      an adjustment to the buffer pool resizing was forgotten.
      
      buf_pool_t::realloc(): Do not invoke buf_flush_relocate_on_flush_list()
      for pages that belong to the temporary tablespace. Also, deduplicate
      some code at the end.
      
      buf_page_t::set_corrupt_id(): Tolerate oldest_modification()==1
      (the dummy value) for temporary tablespace pages. The revised
      buf_pool_t::realloc() may invoke this on dirty temporary tablespace pages.
      84b8f529
  4. 22 Jan, 2021 4 commits
  5. 21 Jan, 2021 4 commits
    • Sergei Golubchik's avatar
      MDEV-24593 Signal 11 when group by primary key of table joined to information_schema.columns · 4e503aec
      Sergei Golubchik authored
      I_S tables were materialized too late, an attempt to use table
      statistics before the table was created caused a crash.
      
      Let's move table creation up. it only needs read_set to
      be calculated properly, this happens in JOIN::optimize_inner(),
      after semijoin transformation.
      
      Note that tables are not populated at that point, so most of the
      statistics would make no sense anyway. But at least field sizes
      will be correct. And it won't crash.
      4e503aec
    • Sergei Golubchik's avatar
      remove now-unused rdiff file · 61feb568
      Sergei Golubchik authored
      61feb568
    • Monty's avatar
      MDEV-24452 ALTER TABLE event take infinite time which for example breaks mysql_upgrade · 6eb1eed5
      Monty authored
      The problem was that update_timing_fields_for_event() didn't release all
      MDL locks it took.
      6eb1eed5
    • Jan Lindström's avatar
      MDEV-24596 : Assertion `state_ == s_exec || state_ == s_quitting' failed in... · be5fce16
      Jan Lindström authored
      MDEV-24596 : Assertion `state_ == s_exec || state_ == s_quitting' failed in wsrep::client_state::disable_streaming
      
      There were multiple problems here
      * wsrep_trx_fragment_size should not be set when wsrep is disabled or provider is not loaded
      * wsrep_trx_fragment_unit should not be set when wsrep is disabled or provider is not loaded
      * wsrep_debug has no effect if wsrep is disabled or provider is not loaded
      * wsrep_start_position should not be set when wsrep is disabled or provider is not loaded any other value than default
      * wsrep_start_position should be changed only when we are joiner or initialized
      * wsrep_start_position should be allowed to set only a value that exits, thus
      we need to add error handling to wsrep_sst_complete
      be5fce16
  6. 20 Jan, 2021 1 commit
    • sjaakola's avatar
      MDEV-21153 Replica nodes crash due to indexed virtual columns and FK cascading delete · 9377e9ba
      sjaakola authored
      Fix for MDEV-23033 fixes a problem in replication applying of transactions, which contain cascading foreign key delete for a table, which has indexed virtual column.
      This fix adds slave_fk_event_map flag for table, to mark when the prelocking is needed for applying of a transaction.
      See commit 608b0ee5 for more details.
      However, this fix is targeted for async replication only, Rows_log_event::do_apply_event() has condition to rule out galera replication from the fix domain, and use cases suffering from MDEV-23033 and related MDEV-21153 will fail in galera cluster.
      
      The fix in this commit removes the condition to rule out the setting of slave_fk_event_map flag from galera replication, and makes the fix in MDEV-23033 effective for galera replication as well.
      
      However, the above fix has caused regressions for some galera_sr suite tests, which run tests for streaming replication.
      This regression can be observed e.g. by: /mtr galera_sr.galera_sr_multirow_rollback  --mysqld=--slave_run_triggers_for_rbr=yes
      These galera_sr suite tests were failing in last phase of replication applying, where actual transaction is already applied, and streaming replication related meta data needs to be updated in wsrep system tables.
      Opening the wsrep system tables failed for corrupt data in THD::lex:query_tables_list. The fix in this commit uses back query table list for the duration of fragment update operation.
      
      Finally, a mtr test for virtual column support has been added. galera.galera_virtual_column.test has as first test a scenario from MDEV-21153
      
      new fix
      Reviewed-by: default avatarJan Lindström <jan.lindstrom@mariadb.com>
      9377e9ba
  7. 19 Jan, 2021 4 commits
    • sjaakola's avatar
      MDEV-21153 Replica nodes crash due to indexed virtual columns and FK cascading delete · 7d04ce6a
      sjaakola authored
      Fix for MDEV-23033 fixes a problem in replication applying of transactions, which contain cascading foreign key delete for a table, which has indexed virtual column.
      This fix adds slave_fk_event_map flag for table, to mark when the prelocking is needed for applying of a transaction.
      See commit 608b0ee5 for more details.
      However, this fix is targeted for async replication only, Rows_log_event::do_apply_event() has condition to rule out galera replication from the fix domain, and use cases suffering from MDEV-23033 and related MDEV-21153 will fail in galera cluster.
      
      The fix in this commit removes the condition to rule out the setting of slave_fk_event_map flag from galera replication, and makes the fix in MDEV-23033 effective for galera replication as well.
      
      Finally, a mtr test for virtual column support has been added. galera.galera_virtual_column.test has as first test a scenario from MDEV-21153
      Reviewed-by: default avatarJan Lindström <jan.lindstrom@mariadb.com>
      7d04ce6a
    • Dmitry Shulga's avatar
      MDEV-24577: Fix warnings generated during compilation of... · 8bcddb02
      Dmitry Shulga authored
      MDEV-24577: Fix warnings generated during compilation of plugin/auth_pam/testing/pam_mariadb_mtr.c on FreeBSD
      
      Compiler warnings generated on building MariaDB server for BSD has the same
      reason as in case building is performed on MacOS. Both platforms do use
      clang as a C/C++ compiler. So, fix the compiler warnings in case the compiler
      is clang doesn't matter what kind of building platform do we use for building.
      
      This is a follow-up patch for the following bug reports:
        MDEV-23564: CMAKE failing due to deprecated Apple GSS method
        MDEV-23935: Fix warnings generated during compilation of
                    plugin/auth_pam/testing/pam_mariadb_mtr.c on MacOS
      8bcddb02
    • Marko Mäkelä's avatar
      Merge 10.2 into 10.3 · 049811ec
      Marko Mäkelä authored
      049811ec
    • Vlad Lesin's avatar
      MDEV-24612: innodb hangs if it's initialization is broken before encryption threads are started · 9930cb22
      Vlad Lesin authored
      Do not init encryption threads if shutdown is in progress.
      9930cb22
  8. 17 Jan, 2021 1 commit
  9. 15 Jan, 2021 5 commits
  10. 14 Jan, 2021 3 commits
    • Marko Mäkelä's avatar
      MDEV-24569: Change buffer merge modifies freed page · deadec4e
      Marko Mäkelä authored
      Starting with MDEV-15528, we will avoid writing freed pages back
      to data files. During stress testing, the assertion
      mach_read_from_4(frame + 4U) == block.page.id().page_no()
      failed in log_phys_t::apply(), because before the server was
      killed and restarted, change buffer merge was executed on a
      previously freed page.
      
      During recovery, the assertion would fail when InnoDB would apply
      a FREE_PAGE and a WRITE record to the page.
      
      ibuf_merge_or_delete_for_page(): Before applying any changes, check whether
      the secondary index leaf page has already been freed according to
      the allocation bitmap page. If it is freed, then we must reset the bits
      in change buffer bitmap page.
      
      ibuf_reset_bitmap(): Auxiliary function for repeated code.
      
      mtr_t::sx_lock_space(): Replaces mtr_t::x_lock_space(). Due to the
      lazy approach of the change buffer, The function
      ibuf_merge_or_delete_for_page() may be executed in buf_page_create()
      while the tablespace is already X-latched. An S-latch must not be
      acquired while the thread already holds an X-latch, but a redundant
      SX-latch is fine.
      
      The fix was developed by Thirunarayanan Balathandayuthapani.
      deadec4e
    • Jan Lindström's avatar
      MDEV-22285 : Assertion `xid_seqno > wsrep_seqno' failed in... · b87828b6
      Jan Lindström authored
      MDEV-22285 : Assertion `xid_seqno > wsrep_seqno' failed in trx_rseg_update_wsrep_checkpoint on SET @@global.wsrep_start_position
      
      Actual assertion mentioned on MDEV seems to be already fixed but
      setting seqno to -2 will trigger a different assertion
      
      mysqld: /home/jan/mysql/10.4-bugs/wsrep-lib/src/server_state.cpp:702: void wsrep::server_state::sst_received(wsrep::client_service&, int): Assertion `state_ == s_joiner || state_ == s_initialized' failed.
      
      Fixed this by not allowing user to set seqno < -1 (-1 is special
      seqno meaning undefined and seqno is initialized to it). MariaDB
      releases 10.2 and 10.3 already do not allow to set seqno < -1.
      b87828b6
    • Dmitry Shulga's avatar
      MDEV-23666: Assertion `m_cpp_buf <= ptr && ptr <= m_cpp_buf + m_buf_length'... · f130adbf
      Dmitry Shulga authored
      MDEV-23666: Assertion `m_cpp_buf <= ptr && ptr <= m_cpp_buf + m_buf_length' failed in Lex_input_stream::body_utf8_append
      
      On parsing statements for which a starting backtick (`) delimiter doesn't have
      a corresponding ending backtick, a current pointer to a position inside a
      pre-processed buffer could go beyond the end of the buffer.
      
      This bug report caused by the commit d4967659
        "MDEV-22022 Various mangled SQL statements will crash 10.3 to 10.5 debug builds".
      
      In order to fix the issue both pointers m_ptr and m_cpp_ptr must be
      rolled back to previous position in raw input and pre-processed input streams
      correspondingly in case end of query reached during parsing.
      f130adbf
  11. 13 Jan, 2021 4 commits
  12. 12 Jan, 2021 3 commits