1. 29 Apr, 2020 1 commit
  2. 28 Apr, 2020 14 commits
  3. 27 Apr, 2020 20 commits
  4. 26 Apr, 2020 1 commit
    • Monty's avatar
      Fixed shutdown crash in Aria that affects debug binaries · 81511b47
      Monty authored
      MDEV-18286 Assertion `pagecache->cnt_for_resize_op == 0' failed in
      check_pagecache_is_cleaned_up on server shutdown
      
      The reason for the crash is that the counter-of-pinned-pages in the
      Aria pagecache goes wrong.
      This only affects debug builds, as in these we do an assert on shutdown
      if the counter-of-pinned-pages is not 0 (some page was left pinned).
      
      The bug was that in 2 places in the page cache, when not succeeding to
      pin a page and a retry was made, the counter-of-pinned-pages counter was
      not properly adjusted.
      
      In the given test case, BLOCK_COMMIT flushed all Aria files. If a block was flushed at the same time the insert tried to access it, the insert would retry to get the block and that would cause the counter to go wrong.
      81511b47
  5. 24 Apr, 2020 4 commits
    • Eugene Kosov's avatar
      cleanup THR_KEY_mysys · 2c5067b6
      Eugene Kosov authored
      read TLS with my_thread_var
      write TLS with set_mysys_var()
      
      my_thread_var is no longer __attribute__ ((const)): this attribute
      is simply incorrect here. Read gcc manual for more information.
      sql/threadpool_generic.cc fails with that attribute.
      2c5067b6
    • Marko Mäkelä's avatar
      MDEV-14735: Fix -Wunused-const-variable · a1978252
      Marko Mäkelä authored
      a1978252
    • Marko Mäkelä's avatar
      Fixup d1c3342d for --embedded · be42004d
      Marko Mäkelä authored
      be42004d
    • Marko Mäkelä's avatar
      MDEV-7962 wsrep_on() takes 0.14% in OLTP RO · edd38b50
      Marko Mäkelä authored
      The reason why we have wsrep_on() at all is that the macro WSREP(thd)
      depends on the definition of THD, and that is intentionally an opaque
      data type for InnoDB. So, we cannot avoid invoking wsrep_on(), but
      we can evaluate the less expensive conditions thd && WSREP_ON before
      calling the function.
      
      Global_read_lock: Use WSREP_NNULL(thd) instead of wsrep_on(thd)
      because we not only know the definition of THD but also that
      the pointer is not null.
      
      wsrep_open(): Use WSREP(thd) instead of wsrep_on(thd).
      
      InnoDB: Replace thd && wsrep_on(thd) with wsrep_on(thd), now that
      the condition has been merged to the definition of the macro
      wsrep_on().
      edd38b50