1. 20 May, 2022 1 commit
    • Tuukka Pasanen's avatar
      MDEV-28191: Suspend Lintian problems in mariadb-test-data package · 06f043d7
      Tuukka Pasanen authored
      Suspend
       national-encoding
       repeated-path-segment
       package-contains-documentation-outside-usr-share-doc
      
      Package mariadb-test-data has test files
      in directory '/usr/share/mysql/mysql-test/' which are not UTF-8
      encoded and they should not be as they are for testing.
      
      package also have Lintian warnings for files that
      are not in correct place in directory 'usr/share/mysql/mysql-test'
      but as they are all are test results they are not in incorrect place
      
      At last there is intentional use for some repeated directories so
      they are false-positives and should be suspended
      06f043d7
  2. 15 May, 2022 1 commit
    • Michael Widenius's avatar
      Fixed warning from UBSAN · e03e7223
      Michael Widenius authored
      The warning comes from copying POSITION objects where 'type' is not
      initialized.  This does not affect any production code as when 'type'
      was compared/used, it was always initialized.
      
      Removed by initializing the type variable in the constructor
      e03e7223
  3. 13 May, 2022 1 commit
    • Vladislav Vaintroub's avatar
      MDEV-28471 mysql_install_db.exe does not work with --innodb-page-size=64K · f027c121
      Vladislav Vaintroub authored
      The error message "InnoDB: innodb_page_size=65536 requires innodb_buffer_pool_size >= 20MiB current 10MiB" is the relevant one.
      
      The root cause:
      mysql_install_db bootstraps with --innodb-buffer-pool-size=10M.
      Small bufferpool is here by design - bootstrap should succeed,
      even if there is not much RAM available, bootstrap does not need that much
      memory.
      
      For pagesize 64K specifically, Innodb thinks it needs a larger bufferpool,
      and thus it lets the bootstrap process die (although the expected behavior
      in this case would be to adjust value, give warning and continue)
      
      The workaround:
      - pass --innodb-buffer-pool-size=20M, which is suitable for all page sizes.
      - check the same limit in MSI custom action.
      
      Also, the patch adds mtr test for 64K page size.
      f027c121
  4. 12 May, 2022 4 commits
  5. 11 May, 2022 4 commits
    • Vlad Lesin's avatar
      MDEV-28473 field_ref_zero is not initialized in xtrabackup_prepare_func() · 3fabdc3c
      Vlad Lesin authored
      The solution is to initialize field_ref_zero in main_low() before
      xtrabackup_backup_func() and xtrabackup_prepare_func() calls.
      3fabdc3c
    • Alexander Barkov's avatar
      MDEV-28446 mariabackup prepare fails for incrementals if a new schema is... · 7da0f30c
      Alexander Barkov authored
      MDEV-28446 mariabackup prepare fails for incrementals if a new schema is created after full backup is taken
      
      Adding a 10.6 specific test
      7da0f30c
    • Sergei Golubchik's avatar
      fix galera.MDEV-26575 failures · a917be3e
      Sergei Golubchik authored
      a917be3e
    • Daniel Black's avatar
      MDEV-28534: clang-12 compile warnings · 09ee95e3
      Daniel Black authored
      Errors where:
      
      /buildbot/amd64-ubuntu-2004-msan/build/sql/item.h:6478:12: error: 'val_datetime_packed' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
        longlong val_datetime_packed(THD *thd)
                 ^
      /buildbot/amd64-ubuntu-2004-msan/build/sql/item.h:3501:12: note: overridden virtual function is here
        longlong val_datetime_packed(THD *thd) override;
                 ^
      /buildbot/amd64-ubuntu-2004-msan/build/sql/item.h:6480:12: error: 'val_time_packed' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
        longlong val_time_packed(THD *thd)
                 ^
      /buildbot/amd64-ubuntu-2004-msan/build/sql/item.h:3502:12: note: overridden virtual function is here
        longlong val_time_packed(THD *thd) override;
                 ^
      09ee95e3
  6. 10 May, 2022 2 commits
  7. 09 May, 2022 4 commits
  8. 08 May, 2022 4 commits
  9. 07 May, 2022 2 commits
  10. 06 May, 2022 12 commits
    • Daniel Black's avatar
      MDEV-27816: Set sql_mode before DROP IF EXISTS already (postfix) · 0db27eff
      Daniel Black authored
      Test compat/oracle.sp-package-mysqldump needed re-record.
      0db27eff
    • Andrei's avatar
      MDEV-28310 Missing binlog data for INSERT .. ON DUPLICATE KEY UPDATE · a5dc12ee
      Andrei authored
      MDEV-21810 MBR: Unexpected "Unsafe statement" warning for unsafe IODKU
      
      MDEV-17614 fixes to replication unsafety for INSERT ON DUP KEY UPDATE
      on two or more unique key table left a flaw. The fixes checked the
      safety condition per each inserted record with the idea to catch a user-created
      value to an autoincrement column and when that succeeds the autoincrement column
      would become the source of unsafety too.
      It was not expected that after a duplicate error the next record's
      write_set may become different and the unsafe decision for that
      specific record will be computed to screw the Query's binlogging
      state and when @@binlog_format is MIXED nothing gets bin-logged.
      
      This case has been already fixed in 10.5.2 by 91ab42a8 that
      relocated/optimized THD::decide_logging_format_low() out of the record insert
      loop. The safety decision is computed once and at the right time.
      Pertinent parts of the commit are cherry-picked.
      
      Also a spurious warning about unsafety is removed when MIXED
      @@binlog_format; original MDEV-17614 test result corrected.
      The original test of MDEV-17614 is extended and made more readable.
      a5dc12ee
    • Marko Mäkelä's avatar
    • Daniel Black's avatar
      MDEV-4875 Can't restore a mysqldump if --add-drop-database meets general_log · 221ced92
      Daniel Black authored
      or slow query log when the log_output=TABLE.
      
      When this happens, we temporary disable by changing log_output until
      we've created the general_log and slow_log tables again.
      
      Move </database> in xml mode until after the transaction_registry.
      
      General_log and slow_log tables where moved to be first to be dumped so
      that the disabling of the general/slow queries is minimal.
      221ced92
    • Hartmut Holzgraefe's avatar
      MDEV-27816 Set sql_mode before DROP IF EXISTS already · 9fe3bc2a
      Hartmut Holzgraefe authored
      Previously the correct SQL mode for a stored routine or
      package was only set before doing the CREATE part, this
      worked out for PROCEDUREs and FUNCTIONs, but with ORACLE
      mode specific PACKAGEs the DROP also only works in ORACLE
      mode.
      
      Moving the setting of the sql_mode a few lines up to happen
      right before the DROP statement is writen fixes this.
      9fe3bc2a
    • Marko Mäkelä's avatar
      MDEV-28484 InnoDB encryption key rotation is not being marked completed · f67d65e3
      Marko Mäkelä authored
      fil_crypt_flush_space(): Correct a condition that was refactored
      incorrectly in commit aaef2e1d
      f67d65e3
    • Marko Mäkelä's avatar
      Merge 10.5 into 10.6 · 57a9626f
      Marko Mäkelä authored
      57a9626f
    • Oleksandr Byelkin's avatar
      MDEV-28402 ASAN heap-use-after-free in create_tmp_table, Assertion `l_offset... · 141ab971
      Oleksandr Byelkin authored
      MDEV-28402 ASAN heap-use-after-free in create_tmp_table, Assertion `l_offset >= 0 && table->s->rec_buff_length - l_offset > 0'
      
      Make default() function follow Item_field and use get_tmp_table_item() for
      change_to_use_tmp_fields().
      141ab971
    • Marko Mäkelä's avatar
      fd9e733a
    • Sergei Petrunia's avatar
      624cb973
    • Marko Mäkelä's avatar
      MDEV-28478: INSERT into SPATIAL INDEX in TEMPORARY table writes log · 26d46234
      Marko Mäkelä authored
      This is based on commit 20ae4816
      with some adjustments for MDEV-12353.
      
      row_ins_sec_index_entry_low(): If a separate mini-transaction is
      needed to adjust the minimum bounding rectangle (MBR) in the parent
      page, we must disable redo logging if the table is a temporary table.
      For temporary tables, no log is supposed to be written, because
      the temporary tablespace will be reinitialized on server restart.
      
      rtr_update_mbr_field(), rtr_merge_and_update_mbr(): Changed the return
      type to void and removed unreachable code. In older versions, these
      used to return a different value for temporary tables.
      
      page_id_t: Add constexpr to most member functions.
      
      mtr_t::log_write(): Catch log writes to invalid tablespaces
      so that the test case would crash without the fix to
      row_ins_sec_index_entry_low().
      26d46234
    • Marko Mäkelä's avatar
      MDEV-28478: INSERT into SPATIAL INDEX in TEMPORARY table writes log · 20ae4816
      Marko Mäkelä authored
      row_ins_sec_index_entry_low(): If a separate mini-transaction is
      needed to adjust the minimum bounding rectangle (MBR) in the parent
      page, we must disable redo logging if the table is a temporary table.
      For temporary tables, no log is supposed to be written, because
      the temporary tablespace will be reinitialized on server restart.
      
      rtr_update_mbr_field(): Plug a memory leak.
      20ae4816
  11. 05 May, 2022 5 commits