- 08 Sep, 2017 3 commits
-
-
Monty authored
-
Monty authored
Bug in privilege checking of sequences. Test case added.
-
Marko Mäkelä authored
-
- 07 Sep, 2017 7 commits
-
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
Marko Mäkelä authored
recv_reset_logs(): Initialize the redo log buffer, so that no data from the old redo log can be written to the new redo log. This bug has very little impact before MariaDB 10.2. The innodb_log_encrypt option that was introduced in MariaDB 10.1 increases the impact. If the redo log used to be encrypted, and it is being resized and encryption disabled, then previously encrypted data could end up being written to the new redo log in clear text. This resulted in encryption.innodb_encrypt_log test failures in MariaDB 10.2.
-
Marko Mäkelä authored
The SEARCH_ABORT logic was not working as intended (tests were not being aborted).
-
Marko Mäkelä authored
In XtraDB, buf_block_get_frame() can return NULL, and this value can be passed to buf_page_print(). Do not declare the parameter as nonnull.
-
- 06 Sep, 2017 10 commits
-
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
Marko Mäkelä authored
The files ibtmp1 and ib_buffer_pool are sometimes created, sometimes not. Remove them if they exist.
-
Marko Mäkelä authored
-
Oleksandr Byelkin authored
MDEV-13523: Group By in a View, called within a Stored Routine causes Error Code 1356 when a non-root user runs the routine for a second time it is actually test suite for second code chunk fix in MDEV-13439
-
Marko Mäkelä authored
row_merge_read_clustered_index(): The row->fields[] could point to a record in the clustered index page of the source table, or to an old version of the record that was constructed in row_heap. If the row->fields[] points to the clustered index page, then we were modifying buffer pool data without holding appropriate block->lock and without appropriate redo logging. The intention was to modify a copy of the data, not the source file page, because concurrent readers would still very much need the original values of the DB_TRX_ID,DB_ROLL_PTR for their multi-versioning. Either way, it is simplest to not write anything at all, and to make row->fields[] point to the constant reset_trx_id.
-
Marko Mäkelä authored
The bug only affects ROW_FORMAT=DYNAMIC tables. It is reproducible already with 2 records in the table. Keep testing with ROW_FORMAT=REDUNDANT just in case.
-
Marko Mäkelä authored
The bug only affected innodb_page_size=64k. There is no point running the test with smaller page sizes.
-
Marko Mäkelä authored
-
Marko Mäkelä authored
buf_page_print(): Remove the parameter 'flags', and when a server abort is intended, perform that in the caller. In this way, page corruption reports due to different reasons can be distinguished better. This is non-functional code refactoring that does not fix any page corruption issues. The change is only made to avoid falsely grouping together unrelated causes of page corruption.
-
- 05 Sep, 2017 3 commits
-
-
Varun Gupta authored
Rdb_io_watchdog can not be built on OS X. Disable it.
-
Sergei Petrunia authored
-
Marko Mäkelä authored
-
- 04 Sep, 2017 4 commits
-
-
andrelkin authored
Was reported as 'rpl.rpl_gtid_stop_start fails with Valgrind in buildbot and outside'. The 'Conditional jump or move depends on uninitialized value' valgrind complaint is valid and means THD::m_current_stage_key that is not initialized indeed by constructor. Fixed with its initialization added to the initializer list of THD::THD. Double checked with mysql to have found a similar fixes for the very same issue which was discovered after P_S merge to Maria (60589aee where the member is introduced) had been done.
-
Andrei Elkin authored
A new $MYSQLD_LAST_CMD evaluation was too late in case --manual-gdb. Now it is done before the server restart type branches which is safe and the args value has been fully computed by the new point of evaluation.
-
Oleksandr Byelkin authored
save thd->select_number between parsing and executions (in case it was not complete executed due to errors (for example epsent table))
-
Marko Mäkelä authored
This is a backport of the following: MDEV-13009 10.1.24 does not compile on architectures without 64-bit atomics Add a missing #include "sync0types.h" that was removed in MDEV-12674.
-
- 03 Sep, 2017 1 commit
-
-
Julien Del-Piccolo authored
* Fix bash expansion issue in wsrep_sst_rsync. https://github.com/docker-library/mariadb/issues/126 * Fix permissions
-
- 02 Sep, 2017 1 commit
-
-
Sergei Golubchik authored
so that even the ancient patch 2.5.4 could apply it correctly. fixes centos5-x86
-
- 01 Sep, 2017 11 commits
-
-
Vladislav Vaintroub authored
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
Marko Mäkelä authored
Follow-up to MDEV-13570 Assertion failure !srv_read_only_mode in --innodb-read-only shutdown when buf_resize_thread is active logs_empty_and_mark_files_at_shutdown(): Actually skip the debug assertion when the buf_resize_thread is active. The previous fix skipped the debug assertion failure when buf_dump_thread is active. Both these threads are created also in innodb_read_only mode. Depending on how fast these threads react to the shutdown signal, the debug assertion could be triggered. There is no impact on non-debug servers, and very little impact on debug servers either, because in innodb_read_only shutdown, no InnoDB files will need to be written.
-
Sergei Golubchik authored
followup for 62139dc2
-
Jan Lindström authored
MDEV-13690: Remove unnecessary innodb_use_mtflush, innodb_mtflush_threads parameters and related code Users can use innodb-page-cleaners instead.
-
Oleksandr Byelkin authored
-
Marko Mäkelä authored
innobase_rec_reset(): Remove. This function was introduced in the InnoDB Plugin for MySQL 5.1, which later evolved into MySQL 5.5. There used to be a bug that ADD UNIQUE INDEX would not always correctly report the duplicate key value of the secondary index. This function ensured that instead of reporting total garbage values, InnoDB would report NULL. It looks like the function was made unnecessary in MySQL 5.6.6 by https://github.com/mysql/mysql-server/commit/d143097eb1e02904baed34990db637ff68fe3113 The corresponding test was subsequently adjusted in https://github.com/mysql/mysql-server/commit/fde80cf49d4b7635d2aef47d8a77681f2df62105 The ALTER TABLE tests were imported to MariaDB as part of MDEV-13625, and these tests do pass with this change. The unnecessary function did not do any harm before MDEV-11371 introduced compressed columns. One question remains: What if we needed to report a duplicate key value for a compressed column? The simple answer is that the test main.column_compression demonstrates that no indexes can be defined on compressed columns.
-
Marko Mäkelä authored
metadata_lock_info_duration[]: Remove the unused variable. Add some comments /* fall through */ to silence -Wimplicit-fallthrough
-
Marko Mäkelä authored
pretty_print_engine_list(): When the plugin list is empty, return an empty string instead of allocating a buffer of 0 bytes and then trying to write a NUL byte into it.
-
Marko Mäkelä authored
-