1. 17 Oct, 2004 1 commit
    • unknown's avatar
      Fix for bug #6081 "Call to deprecated mysql_create_db() function crashes · 07c7aadf
      unknown authored
      server".
      
      Altough mysql_create_db()/mysql_drop_db() API calls are deprecated
      since 4.0, they should not crash server and should not stall connection
      in case of errors. 
      
      
      sql/sql_parse.cc:
        Handling of COM_CREATE_DB, COM_DROP_DB:
          mysql_create_db() requires from its second parameter to be non-zero.
          We also should call send_error() if mysql_create_db or mysql_drop_db
          return error (like we do it for SQL versions of these commands).
      tests/client_test.c:
        Added test for bug #6081 "Execution of deprecated mysql_create_db()
        crashes server".
      07c7aadf
  2. 16 Oct, 2004 1 commit
  3. 15 Oct, 2004 7 commits
  4. 14 Oct, 2004 17 commits
  5. 13 Oct, 2004 10 commits
    • unknown's avatar
      761ae02c
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · 55c1b794
      unknown authored
      into mysql.com:/media/sda1/mysql/mysql-4.1-5985
      
      
      sql/sql_class.h:
        Auto merged
      55c1b794
    • unknown's avatar
      A fix and test case for Bug#5985 ""prepare stmt from "select rand(?)" · 54b00f54
      unknown authored
      crashes server." The fix makes Item_func_rand prepared-statements
      aware plus it fixes the case when RAND is used in prepared
      statements and replication is on (as well as several similar issues).
      Until now we did not reset THD before every execution of a prepared
      statement, so if some execution had set thd->time_zone_used
      or thd->rand_used they would not be reset until next mysql_parse.
      Some of post-review fixes done.
      
      
      mysql-test/r/ps.result:
        A test case for Bug#5985: test results fixed.
      mysql-test/t/ps.test:
        A test case for Bug#5985 "prepare stmt from "select rand(?)" crashes
        server."
      sql/item_func.cc:
        Actual fix for Bug#5985: Item_func_rand rewritten to be 
        prepared statements aware.
      sql/item_func.h:
        Actual fix for Bug#5985: Item_func_rand rewritten to be 
        prepared statements aware.
      sql/mysql_priv.h:
        We need a separate call to reset THD state before every execute of
        a prepared statement. Otherwise things like THD->user_var_events
        are never cleaned up and bloat binary log (as the list of events
        grows from execution to execution).
      sql/sql_class.cc:
        Statement::end_statement -> THD::end_statement()
        (a leftover from some design change which is not to pushed now, but the
        leftover is to be pushed).
      sql/sql_class.h:
        Statement::end_statement -> THD::end_statement()
        (a leftover from some design change which is not to pushed now, but the
        leftover is to be pushed).
      sql/sql_lex.cc:
        Move the part responsible for initializing LEX from mysql_init_query
        to lex_start.
      sql/sql_lex.h:
        All lex-related initialization is now in lex_start.
        Move thd->select_number to lex->select_number to be able to use it
        easily in lex_start.
      sql/sql_parse.cc:
        Split mysql_init_query into two functions: mysql_reset_thd_for_next_query,
        which is used in PS and conventional execution, and lex_start, used only
        when we want to parse something.
        Fix init_connect to use initialized THD.
      sql/sql_prepare.cc:
        Deploy mysql_reset_thd_for_next_query to reset THD state before
        execution of a prepared statement.
        Normally this should have been added to just one place, but
        we have to reset thd before assigning placeholders from variables,
        thus we can't do that in execute_stmt (yuck).
      54b00f54
    • unknown's avatar
      Merge sanja.is.com.ua:/home/bell/mysql/bk/mysql-4.1 · ee7518b5
      unknown authored
      into sanja.is.com.ua:/home/bell/mysql/bk/work-4.1
      
      
      sql/item_subselect.cc:
        Auto merged
      ee7518b5
    • unknown's avatar
      srv0srv.c, log0log.c, srv0srv.h, ha_innodb.cc, ha_innodb.h: · 7b1f818d
      unknown authored
        Implement innobase_very_fast_shutdown and innobase_start_trx_and_assign_read_view(); these were requested by Guilhem
      
      
      sql/ha_innodb.h:
        Implement innobase_very_fast_shutdown and innobase_start_trx_and_assign_read_view(); these were requested by Guilhem
      sql/ha_innodb.cc:
        Implement innobase_very_fast_shutdown and innobase_start_trx_and_assign_read_view(); these were requested by Guilhem
      innobase/include/srv0srv.h:
        Implement innobase_very_fast_shutdown and innobase_start_trx_and_assign_read_view(); these were requested by Guilhem
      innobase/log/log0log.c:
        Implement innobase_very_fast_shutdown and innobase_start_trx_and_assign_read_view(); these were requested by Guilhem
      innobase/srv/srv0srv.c:
        Implement innobase_very_fast_shutdown and innobase_start_trx_and_assign_read_view(); these were requested by Guilhem
      7b1f818d
    • unknown's avatar
      Merge istruewing@bk-internal.mysql.com:/home/bk/mysql-4.1 · 8983293d
      unknown authored
      into mysql.com:/home/mydev/mysql-4.1
      
      
      8983293d
    • unknown's avatar
      BUG#4286 - HANDLER tables are closed by FLUSH TABLE(S). · fd6009ac
      unknown authored
      BUG#4335 - one name can be handler open'ed many times.
      Fixed problems detected on Windows build by VC++.
      Removed unused variables.
      Applied a neccessary cast.
      
      
      fd6009ac
    • unknown's avatar
      tests/client_test.c: · ba48e6f9
      unknown authored
        Make checks (asserts) performed in client_test.c work in non-debug
        builds.
      
      
      tests/client_test.c:
        Make checks (asserts) performed in client_test.c work in non-debug
        builds: all asserts/DBUG_ASSERTs replaced with if (!(expr)) abort();
      ba48e6f9
    • unknown's avatar
      InnoDB: correct potential overflow in trx_purge() · 74c25418
      unknown authored
      
      innobase/trx/trx0purge.c:
        trx_purge(): avoid overflow in setting srv_dml_needed_delay
      74c25418
    • unknown's avatar
      fix for some build/test errors for 4.1.6 · beb3fddc
      unknown authored
      beb3fddc
  6. 12 Oct, 2004 4 commits
    • unknown's avatar
      Move Heikki's comment about thd->query comment to proper place · 63af3d3a
      unknown authored
      (bad merge from 4.0)
      
      
      sql/sql_class.h:
        Move a comment to proper place (bad merge from 4.0)
      63af3d3a
    • unknown's avatar
      post-commit: · 9b8586bf
      unknown authored
        Added catch for (example) WL#1234 into bk commit subjects
      
      
      BitKeeper/triggers/post-commit:
        Added catch for (example) WL#1234 into bk commit subjects
      9b8586bf
    • unknown's avatar
      ps.test, ps.result: a test case for Bug#6042 "constants · d007600b
      unknown authored
      propogation works only once (prepared statements)".
      
      
      mysql-test/r/ps.result:
        Test case for Bug#6042: test results fixed
      mysql-test/t/ps.test:
        A test case for Bug#6042 "constants propogation works only once
        (prepared statements).
      d007600b
    • unknown's avatar
      New tests for prepared statements: · 4855ff51
      unknown authored
      - 'ps_10nestset' uses a "nested set" approach for an employee 
        hierarchy, then does arithmetic on the "salary" field;
        (soon) to be extended by inserts / deletes which imply
        mass updates on the "l"/"r" fields showing the set inclusion,
      - 'ps_11bugs' will get (some of ?) those bug DB entries which
        refer to prepared statements, but whose number does not appear
        in a test file comment - so it will also be extended.
      
      
      4855ff51