- 18 Dec, 2019 1 commit
-
-
Jan Lindström authored
Problem was that wsrep_on was OFF. This is 10.4 version.
-
- 16 Dec, 2019 1 commit
-
-
Teemu Ollakka authored
This commit updates the wsrep-lib. The changes are a cleanup in client_state TOI processing and stub methods for future extensions.
-
- 13 Dec, 2019 2 commits
-
-
Marko Mäkelä authored
We disable the MDEV-21189 test galera.galera_partition because it times out.
-
Marko Mäkelä authored
-
- 12 Dec, 2019 7 commits
-
-
Eugene Kosov authored
offset_t: this is a type which represents one record offset. It's unsigned short int. a lot of functions: replace ulint with offset_t btr_pcur_restore_position_func(), page_validate(), row_ins_scan_sec_index_for_duplicate(), row_upd_clust_rec_by_insert_inherit_func(), row_vers_impl_x_locked_low(), trx_undo_prev_version_build(): allocate record offsets on the stack instead of waiting for rec_get_offsets() to allocate it from mem_heap_t. So, reducing memory allocations. RECORD_OFFSET, INDEX_OFFSET: now it's less convenient to store pointers in offset_t* array. One pointer occupies now several offset_t. And those constant are start indexes into array to places where to store pointer values REC_OFFS_HEADER_SIZE: adjusted for the new reality REC_OFFS_NORMAL_SIZE: increase size from 100 to 300 which means less heap allocations. And sizeof(offset_t[REC_OFFS_NORMAL_SIZE]) now is 600 bytes which is smaller than previous 800 bytes. REC_OFFS_SEC_INDEX_SIZE: adjusted for the new reality rem0rec.h, rem0rec.ic, rem0rec.cc: various arguments, return values and local variables types were changed to fix numerous integer conversions issues. enum field_type_t: offset types concept was introduces which replaces old offset flags stuff. Like in earlier version, 2 upper bits are used to store offset type. And this enum represents those types. REC_OFFS_SQL_NULL, REC_OFFS_MASK: removed get_type(), set_type(), get_value(), combine(): these are convenience functions to work with offsets and it's types rec_offs_base()[0]: still uses an old scheme with flags REC_OFFS_COMPACT and REC_OFFS_EXTERNAL rec_offs_base()[i]: these have type offset_t now. Two upper bits contains type.
-
Eugene Kosov authored
recv_dblwr_t::list is used for appending to the beginning and iterating through its elements. std::deque fits better for that purpose because it does less allocations than std::forward_list and provides better memory locality.
-
Marko Mäkelä authored
-
Alexander Barkov authored
When backpatching a forward GOTO label, the old code erroneously used CURSOR/HANDLER difference between context frames "c" and "a" to tune a cpop/hpop command. So the cpop/hpop command later tried to pop all cursors/handlers declared between "a" and "c", but those between "b" and "c" were not cpushed/hpoped yet during the execution of "GOTO x". Fixing the code to use the difference between frames "b" and "a" only. BEGIN -- a ... GOTO x; -- b ... <<x>> -- c ... END -- d
-
Vladislav Vaintroub authored
fil_node_t::find_metadata() tries to find out whether file is on an SSD, and the disk sector size. On Windows, it opens the corresponding volume for finding this data. This does not go well, if datadir is on network path/UNC. The volume name is invalid, CreateFile() function fails, and a cryptic (from the end user perspective) error is reported. Like this [ERROR] InnoDB: File \\.\\\workpc\work: 'CreateFile()' returned OS error 203. The fix is not to report error if open volume failed, and the path was not on fixed disk, i.e not on HDD or SSD. This is not a fatal error, there is a fallback anyway.
-
Vladislav Vaintroub authored
-
Vlad Lesin authored
copy thread) mariabackup hangs waiting until innodb redo log thread read log till certain LSN, and it waits under FTWRL. If there is redo log read error in the thread, it is finished, and main thread knows nothing about it, what leads to hanging. As it hangs under FTWRL, slave threads on server side can be blocked due to MDL lock conflict. The fix is to finish mariabackup with error message on innodb redo log read failure.
-
- 11 Dec, 2019 7 commits
-
-
Varun Gupta authored
The issue here is window function makes the passed string object to point to an area in a temporary table's record buffer. Then, the temporary table is freed, together with its record buffer. Then, Item_cache_str attempts to read this value. The fix is to call value_buff.copy(). This will make the value_buff to store its string in a buffer that it owns, which will not disappear unexpectedly.
-
Daniel Bartholomew authored
-
Daniel Bartholomew authored
-
Daniel Bartholomew authored
-
Vladislav Vaintroub authored
Simplify loading messages into mariabackup. Do the same as server does We're forcing english, so there is no attempt to load errmsg.sys
-
Daniele Sciascia authored
Test galera_sr_ddl_master would sometimes fail due to leftover streaming replication fragments. Rollbacker thread would attempt to open streaming_log table to remove the fragments, but would fail in check_stack_overrun(). Ultimately the check_stack_overrun() failure was caused by rollbacker missing to switch the victim's THD thread stack to rollbacker's thread stack. Also in this patch: - Remove duplicate functionality in rollbacker helper functions, and extract rollbacker fragment removal into function wsrep_remove_streaming_fragments() - Reuse open_for_write() in wsrep_schema::remove_fragments - Partially revert changes to galera_sr_ddl_master test from commit 44a11a7c. Removed unnecessary wait condition and isolation level setting
-
Vladislav Vaintroub authored
-
- 10 Dec, 2019 9 commits
-
-
Marko Mäkelä authored
When using huge pages, the innodb_buffer_pool_size cannot necessarily be restored. Simplify things by restarting the server.
-
Marko Mäkelä authored
InnoDB RNG maintains global state, causing otherwise unnecessary bus traffic. Even worse, this is cross-mutex traffic. That is, different mutexes suffer from contention. Fixed delay of 4 was verified to give best throughput by OLTP update index and read-write benchmarks on Intel Broadwell (2/20/40) and ARM (1/46/46). This is a backport of ce047900 from MariaDB Server 10.3.
-
Marko Mäkelä authored
We should not need anywhere near 32 bits of entropy, so we might just limit ourselves to a 32-bit random number generator. Also, it might be cheaper to use exclusive-or, bit shifting and conditional jumps, instead of multiplication and addition. We use relaxed atomic operations on the global random number generator state in order in an attempt to silence any warnings about race conditions. There is an obvious race condition between the load and store in ut_rnd_gen(), but we do not think that it matters much that the state of the random number generator could 'stutter'. This change seems makes the 'uncompress_ops' nondeterministic in innodb_zip.cmp_per_index after the restart. It looks like there is an inherent race condition in the test, because the table could be opened for InnoDB statistics recalculation already before innodb_cmp_per_index_enabled was set. We might end up having uncompress_ops anywhere between 0 and 9, or perhaps even more. Let us remove that part of the test.
-
Marko Mäkelä authored
ut_rnd_interval(): Remove the first parameter, which was mostly passed as 0. Implement as a simple wrapper around ut_rnd_gen(). Trivially return 0 if the size of the interval is smaller than 2. ut_rnd_ulint_counter, ut_rnd_gen_next_ulint(), ut_rnd_gen_ulint(): Remove.
-
Marko Mäkelä authored
ut_rnd_set_seed(): Unused function; remove. ut_rnd_gen(): Renamed from page_cur_lcg_prng(). ut_rnd_current: The internal state of ut_rnd_gen(). page_cur_open_on_rnd_user_rec(): Replace linear search with page_rec_get_nth().
-
Eugene Kosov authored
FreeState(): replace pointer to freed memory with NULL. This actually fixes a crash which is use-after-free as reported by ASAN DbugParse(): unconditionally lock mutex because we're touching shared init_settings.keywords
-
Elena Stepanova authored
-
Oleksandr Byelkin authored
When there is a WITH clause we postpone check for tables without database for later stages when tables in WITH will be defined. But we should not try to open such tables as temporary tables because temporary tables always belong to a some database.
-
Varun Gupta authored
Disable the IN predicate to IN subquery conversion when the types on the left and right hand side of the IN predicate are not of comparable type.
-
- 09 Dec, 2019 5 commits
-
-
Oleksandr Byelkin authored
-
Marko Mäkelä authored
-
Marko Mäkelä authored
The InnoDB internal SQL parser, which is used for updating the InnoDB data dictionary tables (to be removed in MDEV-11655), persistent statistics (to be refactored in MDEV-15020) and fulltext indexes, implements some unused keywords and built-in functions: OUT BINARY BLOB INTEGER FLOAT SUM DISTINCT READ COMPACT BLOCK_SIZE TO_CHAR TO_NUMBER BINARY_TO_NUMBER REPLSTR SYSDATE PRINTF ASSERT RND RND_STR ROW_PRINTF UNSIGNED Also, procedures are never declared with parameters. Only one top-level procedure is declared and invoked at a time, and parameters are being passed via pars_info_t.
-
Jan Lindström authored
MDEV-21189: Dropping partition with 'wsrep_OSU_method=RSU' and 'SESSION sql_log_bin = 0' cases the galera node to hang Found two bugs (1) have_committing_connections was missing mutex unlock on one exit case. As this function is called on a loop it caused mutex lock when we already owned the mutex. This could cause hang. (2) wsrep_RSU_begin did set up error code when partition to be dropped could not be MDL-locked because of concurrent operations but wrong error code was propagated to upper layer causing error to be ignored. This could have also caused the hang.
-
Teemu Ollakka authored
The assertion was caused by use of operator[] for an empty vector. The wsrep-lib update changes vector operations which access the underlying data array to use data() method which is valid for empty vectors.
-
- 08 Dec, 2019 3 commits
-
-
Alexey Botchkov authored
Add necessary checks.
-
Vladislav Vaintroub authored
reenable ssl_8k_key on Windows, which was affected by this bug
-
Vladislav Vaintroub authored
Enable CRL checking on Windows. Enable certificate verification testing in client testing.
-
- 05 Dec, 2019 5 commits
-
-
Elena Stepanova authored
-
Aleksey Midenkov authored
Versioned conditions in on_expr can not be rebuilt at optimization stage on non-conventional arena.
-
Kentoku authored
-
Robert Bindar authored
MDEV-17978 Server crash in SHOW CREATE SEQUENCE on a broken view
-
Aleksey Midenkov authored
Incorrect assertion of EXTRA_CACHE for HA_EXTRA_PREPARE_FOR_UPDATE. The latter is related to read cache, but must operate without it as a noop. Related to Bug#55458 and MDEV-20441.
-