1. 23 Jun, 2021 3 commits
  2. 22 Jun, 2021 5 commits
  3. 21 Jun, 2021 9 commits
  4. 19 Jun, 2021 2 commits
  5. 18 Jun, 2021 2 commits
    • Sergei Golubchik's avatar
      fix spider tests for --ps · 068246c0
      Sergei Golubchik authored
      spider tests use
      
      --let $var= many;sql;statements
      --eval $var
      
      and this doesn't work in ps
      068246c0
    • Sergei Golubchik's avatar
      spider tests aren't big · a5f6eca5
      Sergei Golubchik authored
      and *never* disable tests in suite.pm based on $::opt_big_test,
      this will make the test skipped both as too big (for ./mtr)
      and as too small (for ./mtr --big --big).
      a5f6eca5
  6. 17 Jun, 2021 1 commit
  7. 16 Jun, 2021 2 commits
  8. 15 Jun, 2021 9 commits
    • Julius Goryavsky's avatar
      MDEV-25880 part 2: Improving reliability of the SST scripts · 2edb8e12
      Julius Goryavsky authored
      Additional improvements aimed at improving operational
      reliability of the SST scripts:
      
      1) Script need to give rsync and stunnel a short time to
         terminate after "kill -9" before the first PID check
         using ps utility;
      2) The temporary file used to create the binlog index could
         sometimes remain in the data directory if tar failed and
         then may be reused without being cleaned up (the next
         time when SST was run) - now it's fixed;
      3) The temporary file used to build the binlog index is now
         created using mktemp and, if this variable is present in
         the configuration file, in tmpdir;
      4) Checking the secret tag in SST via rsync is made faster
         and does not require creating a temporary file, which
         could remain in the data directory in case of failure;
      5) Added "-F" option to grep to check the tag when using
         mariabackup/xtrabackup-v2 - to avoid possible collisions
         in case of special characters in the tag value (unlikely
         scenario, but the new check is more reliable).
      2edb8e12
    • Julius Goryavsky's avatar
      MDEV-25880: rsync may be mistakenly killed when overlapping SST · 18d5be5b
      Julius Goryavsky authored
      This commit fixes a bug was originally discovered during the
      galera_nbo_sst_slave mtr test for 10.6 branch. However it is
      relevant for all versions and can lead to intermittent SST
      crashes via rsync on very fast server restarts - when a new
      SST process (for example, after starting a new server instance)
      overlaps the old SST process started by the previous, already
      terminated server. This overlap can result in the new rsync
      being killed instead of the old rsync, or the pid file from
      the new rsync being killed, which then lead to problems.
      18d5be5b
    • Eugene Kosov's avatar
      fix clang build · 1c35a3f6
      Eugene Kosov authored
      a new warning -Wunused-but-set-variable was introduced recently to clang
      1c35a3f6
    • Thirunarayanan Balathandayuthapani's avatar
      MDEV-24713 Assertion `dict_table_is_comp(index->table)' failed in row_merge_buf_add() · 7d591cf8
      Thirunarayanan Balathandayuthapani authored
      - During online alter conversion from compact to redundant,
      virtual column field length already set during
      innobase_get_computed_value(). Skip the char(n) check for
      virtual column in row_merge_buf_add()
      7d591cf8
    • Thirunarayanan Balathandayuthapani's avatar
      MDEV-25872 InnoDB: Assertion failure in row_merge_read_clustered_index upon... · 7229107e
      Thirunarayanan Balathandayuthapani authored
      MDEV-25872 InnoDB: Assertion failure in row_merge_read_clustered_index upon ALTER on table with indexed virtual columns
      
      - InnoDB fails to check DB_COMPUTE_VALUE_FAILED error in
      row_merge_read_clustered_index() and wrongly asserts that
      the buffer shouldn't be ran out of memory. Alter table
      should give warning when the column value is being
      truncated.
      7229107e
    • Thirunarayanan Balathandayuthapani's avatar
      MDEV-14180 Automatically disable key rotation checks for file_key_managment plugin · 8c7d8b71
      Thirunarayanan Balathandayuthapani authored
      Problem:
      =======
      - InnoDB iterates the fil_system space list to encrypt the
      tablespace in case of key rotation. But it is not
      necessary for any encryption plugin which doesn't do
      key version rotation.
      
      Solution:
      =========
      - Introduce a new variable called srv_encrypt_rotate to
      indicate whether encryption plugin does key rotation
      
      fil_space_crypt_t::key_get_latest_version(): Enable the
      srv_encrypt_rotate only once if current key version is
      higher than innodb_encyrption_rotate_key_age
      
      fil_crypt_must_default_encrypt(): Default encryption tables
      should be added to default_encryp_tables list if
      innodb_encyrption_rotate_key_age is zero and encryption
      plugin doesn't do key version rotation
      
      fil_space_create(): Add the newly created space to
      default_encrypt_tables list if
      fil_crypt_must_default_encrypt() returns true
      
      Removed the nondeterministic select from
      innodb-key-rotation-disable test. By default,
      InnoDB adds the tablespace to the rotation list and
      background crypt thread does encryption of tablespace.
      So these select doesn't give reliable results.
      8c7d8b71
    • Thirunarayanan Balathandayuthapani's avatar
      MDEV-14180 preparation: Rename key_rotation_list · 7d2c338c
      Thirunarayanan Balathandayuthapani authored
      - Rename the rotation list to default_encrypt_tables in
      fil_system_t. Because rotation list naming could be
      misleading when it comes to key version rotation
      
      - Rename is_in_rotation_list to is_in_default_encrypt
      in fil_space_t
      
      - Rename keyrotate_next function to default_encrypt_next
      
      fil_system_t::default_encrypt_next(): Find the next
      suitable default encrypt table if beginning of
      default_encrypt_tables list has been scheduled
      to be deleted
      7d2c338c
    • Daniel Black's avatar
      cmake OpenBSD copyright notice correction · be243ed9
      Daniel Black authored
      Brad Smith made this OpenBSD file based of the
      FreeBSD cmake directives in commit ab589043
      by the Monty Program Ab.
      
      As such the Oracle Copyright header isn't really applicable.
      be243ed9
    • Jordy Zomer's avatar
      eventscheduler mismatch of my_{malloc,free}, delete · ec4df514
      Jordy Zomer authored
      Fix malloc/delete mismatch. This causes a double free in the cleanup.
      
      closes #1845
      ec4df514
  9. 14 Jun, 2021 1 commit
  10. 12 Jun, 2021 2 commits
  11. 11 Jun, 2021 2 commits
    • Daniel Black's avatar
      MDEV-20162: fix connect-abstract test case · 8a2b4d53
      Daniel Black authored
      The check-testcase record uses a mysqltest connection
      to the database to do the recording. With the server configured
      as an abstract socket, the mysqltest client cannot connect and
      fails.
      
      We work around this by starting the server as normal and then
      restart with an abstract socket and test this.
      
      This didn't affect Windows as it just did a tcp connection.
      So this did affect all unix socket based systems except Linux
      as this was the only one that supported abstract sockets.
      8a2b4d53
    • Brad Smith's avatar
  12. 10 Jun, 2021 2 commits
    • Otto Kekäläinen's avatar
      MDEV-20392: Skip ABI check if 'diff' is not found · 152c83d4
      Otto Kekäläinen authored
      Not all environments have 'diff' installed. Most notably CentOS 8
      does not have diff out-of-the-box. Thus users running 'cmake .' and
      'make' would fail to build MariaDB, and they would think the error
      was in ABI incompatibilities due to the error message emitted by CMake
      when in reality simply 'diff' was missing.
      
      This fixes it and makes the developer experience better by simply
      skipping the diffing if 'diff' is not found.
      
      Closes #1846
      152c83d4
    • Vladislav Vaintroub's avatar
      MDEV-19702 Refactor Bitmap<N> to be based on ulonglong, not on uint32 · e85df7fe
      Vladislav Vaintroub authored
      Removed Field_map, since it was used only in a single function.
      
      Fixed is_indexed_agg_distinct(), since it relied on initialization of
      Bitmap in constructor.
      
      Fixes MDEV-25888 in 10.4
      e85df7fe