- 22 Sep, 2006 1 commit
-
-
unknown authored
local file slipped into a previous commit, fixing ignore. BitKeeper/etc/ignore: fixing a slip in previous bk citool invokation.
-
- 15 Sep, 2006 8 commits
-
-
unknown authored
into dl145h.mysql.com:/tmp/andrei/5.1-rpl
-
unknown authored
re-activating the bug to fix related to the limitation tests. mysql-test/t/disabled.def: re-disabling
-
unknown authored
into dsl-hkigw8-fe00f800-98.dhcp.inet.fi:/home/elkin/MySQL/TEAM/BARE/mysql-5.1-new-rpl BitKeeper/etc/ignore: auto-union
-
unknown authored
A query SET @@GLOBAL.binlog_format = ... returns an error when NDB is the default storage. This fails some tests invoking the set binlog_format explicitly. because the var turns to be read-only. In the following are files and method to fix if needed. t/ ndb_binlog_basic2.test # here the failure is benign rpl_rbr_to_sbr.test # does not check any ndb features => . # => not_ndb_default is enough rpl_row_basic_8partition.test # set binlog_format can be replaced rpl_switch_stm_row_mixed.test # does not check any ndb features => . # => not_ndb_default is enough two more invoking invoke extra/rpl_truncate_helper.test rpl_truncate_2myisam # to be fixed with not_ndb_default rpl_truncate_3innodb # same as above . # because there is a dedicated to ndb . . # rpl_truncate_7ndb* suit. Adapting/testing a new implement --source include/safe_set_to_maybe_ro_var.inc to avoid abort due to the error using binlog_format as application. BitKeeper/etc/ignore: Added mysql-test/t/rpl_truncate_4ndb.test to the ignore list mysql-test/r/rpl_row_basic_8partition.result: new results mysql-test/t/rpl_rbr_to_sbr.test: # does not check any ndb features => not_ndb_default is enough mysql-test/t/rpl_row_basic_8partition.test: set binlog_format can be read-only because of e.g default storage ndb. adapting/testing a new implement --source include/safe_set_to_maybe_ro_var.inc to avoid abort due to the error. Note, that it this particular test we could simply remove SET binlog_format because there is have_binlog_format_row require, as the test is about RBR. Futhermore utilizing safe_set_to_maybe_ro_var is redundat as well as long as we keep non_ndb_default guard. The latter is introduced because of ndb partitioning per-key limitation #19259: rpl_ndb_dd_partitions fails on solaris. The page is updated to refer to this test's. mysql-test/t/rpl_switch_stm_row_mixed.test: excluding ndb option, no ndb features mysql-test/t/rpl_truncate_2myisam.test: ndb checks truncate separately mysql-test/t/rpl_truncate_3innodb.test: ndb checks truncate separately mysql-test/include/safe_set_to_maybe_ro_var.inc: pseudo-macro to make read-only global/session vars "settable" in sense that SET var= val won't produce any error nor aborts testing.
-
unknown authored
for push in 5.1 (I will inform Trudy). Storage engines and plugins can now have unit tests to test their components; such test must be an executable C/C++ program which name ends with '-t' and which is obeys the mytap protocol, it must be stored in the storage engine's or plugin's source directory (storage/<engine> or plugin/<plugin>) or any subdirectories of this. The top-level Makefile target "test-unit" will run all unit tests: it will scan the engines' and plugins' directories, recursively, and execute all executable files which name ends with '-t'." Makefile.am: "unittest" directory must be built before "storage" and "plugin" because the unit tests in these directories may need libmytap.a which is in unittest/mytap. config/ac-macros/plugins.m4: When enabling engine "X", we add "../storage/X" to the unit tests directories which unittest/unit.pl should traverse looking for tests to execute. Same for plugins. unittest/Makefile.am: Those variables contain all enabled engines and plugins.
-
unknown authored
into mysql.com:/users/lthalmann/bk/MERGE/mysql-5.1-merge sql/ha_ndbcluster.cc: Auto merged sql/sql_class.h: Auto merged sql/sql_yacc.yy: Auto merged storage/ndb/src/kernel/blocks/dbdih/DbdihMain.cpp: Auto merged client/mysqldump.c: Merge rpl 5.0->5.1 mysql-test/r/mysqldump.result: Merge rpl 5.0->5.1 mysql-test/t/mysqldump.test: Merge rpl 5.0->5.1
-
unknown authored
-
unknown authored
-
- 14 Sep, 2006 4 commits
-
-
unknown authored
into mysql.com:/users/lthalmann/bk/MERGE/mysql-5.1-merge mysql-test/r/mysqldump.result: Auto merged mysql-test/t/variables.test: Auto merged sql/field.cc: Auto merged sql/log.cc: Auto merged sql/mysql_priv.h: Auto merged sql/mysqld.cc: Auto merged sql/sql_class.cc: Auto merged sql/sql_insert.cc: Auto merged sql/sql_parse.cc: Auto merged sql/sql_show.cc: Auto merged sql/sql_yacc.yy: Auto merged storage/innobase/handler/ha_innodb.cc: Auto merged client/mysqldump.c: Merge main->rpl mysql-test/r/variables.result: Merge main->rpl mysql-test/t/disabled.def: Merge main->rpl mysql-test/t/mysqldump.test: Merge main->rpl
-
unknown authored
into mysql.com:/users/lthalmann/bk/MERGE/mysql-5.0-merge ndb/src/kernel/blocks/dbdih/DbdihMain.cpp: Auto merged sql/ha_ndbcluster.cc: Auto merged sql/sql_class.h: Auto merged sql/sql_yacc.yy: Auto merged client/mysqldump.c: Merge main->rpl mysql-test/r/mysqldump.result: Merge main->rpl mysql-test/t/mysqldump.test: Merge main->rpl
-
unknown authored
into gbichot3.local:/home/mysql_src/mysql-5.1-rpl-clean
-
unknown authored
tables to INFORMATION_SCHEMA. mysql-test/r/mysqlshow.result: WL#3247,#3248: Adding [GLOBAL|SESSION]_STATUS and [GLOBAL|SESSION]_VARIABLES tables to INFORMATION_SCHEMA. Fixed test cases result (changes are due to addition of new tables).
-
- 13 Sep, 2006 3 commits
-
-
unknown authored
- compiler warning - detection of pthread_create failure (you will see this message only if you run with "make test-verbose" in unittest; otherwise unit.pl masks all messages from the test but "ok" ones. - the test fails randomly on some machines (I filed it as BUG#22320), on one host it looks like a crash at exit() which a sleep(2) makes disappear. So I add the sleep(2), which can be removed when BUG#22320 is fixed. unittest/mysys/my_atomic-t.c: - fix for compiler warning on 64-bit "cast from pointer to integer of different size". Casting to long and then to int. We'll use intptr instead later. - detect if pthread_create fails. - sleep(2) until BUG#22320 is fixed
-
unknown authored
tables to INFORMATION_SCHEMA. mysql-test/r/information_schema.result: WL#3247,#3248: Adding [GLOBAL|SESSION]_STATUS and [GLOBAL|SESSION]_VARIABLES tables to INFORMATION_SCHEMA. Fixed test cases result (changes are due to the new tables added). mysql-test/r/information_schema_db.result: WL#3247,#3248: Adding [GLOBAL|SESSION]_STATUS and [GLOBAL|SESSION]_VARIABLES tables to INFORMATION_SCHEMA. Fixed test cases result (changes are due to the new tables added). mysql-test/r/status.result: WL#3247,#3248: Adding [GLOBAL|SESSION]_STATUS and [GLOBAL|SESSION]_VARIABLES tables to INFORMATION_SCHEMA. Fixed results for added testcases. mysql-test/r/variables.result: WL#3247,#3248: Adding [GLOBAL|SESSION]_STATUS and [GLOBAL|SESSION]_VARIABLES tables to INFORMATION_SCHEMA. Fixed results for added test cases. mysql-test/t/status.test: WL#3247,#3248: Adding [GLOBAL|SESSION]_STATUS and [GLOBAL|SESSION]_VARIABLES tables to INFORMATION_SCHEMA. Added test cases. mysql-test/t/variables.test: WL#3247,#3248: Adding [GLOBAL|SESSION]_STATUS and [GLOBAL|SESSION]_VARIABLES tables to INFORMATION_SCHEMA. Added test cases. sql/sql_show.cc: WL#3247,#3248: Adding [GLOBAL|SESSION]_STATUS and [GLOBAL|SESSION]_VARIABLES tables to INFORMATION_SCHEMA. Implementation of the new I_S tables. Also, show_status_array(): argument 'ucase_names' is added (true means that all variable names are to be converted to upper case). sql/table.h: WL#3247,#3248: Adding [GLOBAL|SESSION]_STATUS and [GLOBAL|SESSION]_VARIABLES tables to INFORMATION_SCHEMA. Implementation of the new I_S tables.
-
unknown authored
into lamia.home:/home/timka/mysql/src/5.1-dbg mysql-test/r/insert_select.result: Auto merged sql/sql_base.cc: Auto merged sql/sql_insert.cc: Auto merged sql/sql_parse.cc: Auto merged
-
- 12 Sep, 2006 12 commits
-
-
unknown authored
into maint2.mysql.com:/data/localhome/tsmith/bk/mrg/51 libmysqld/libmysqld.def: Auto merged mysql-test/t/handler.test: Auto merged sql/log.cc: Auto merged sql-common/client.c: Auto merged sql/mysqld.cc: Auto merged sql/sql_select.cc: Auto merged
-
unknown authored
The cause of the bug was an incomplete fix for bug 18080. The problem was that setup_tables() unconditionally reset the name resolution context to its 'tables' argument, which pointed to the first table of an SQL statement. The bug fix limits resetting of the name resolution context in setup_tables() only in the cases when the context was not set by earlier parser/optimizer phases. mysql-test/r/insert_select.result: Test for BUG#21774. mysql-test/t/insert_select.test: Test for BUG#21774. sql/sql_base.cc: Do not reset the name resolution contect unconditionally. Instead set the context to 'tables' only if it was not set before calling setup_tables(). sql/sql_insert.cc: Added asserts to make sure that in the case of INSERT ... VALUES ... statements it is not necessary to reset the name resolution context to the first table, because there is only one table in the list of tables anyway. The actual code is not removed in order not to confuse it with the actual bug fix. sql/sql_parse.cc: Removed unnecessary reset of the name resolution context. The context is anyway unconditionally reset in mysql_insert() and mysql_prepare_insert().
-
unknown authored
Correct faulty merge, "mysql_priv.h" must be included for the ifdef WITH_INNOBASE_STORAGE_ENGINE to work
-
unknown authored
into neptunus.(none):/home/msvensson/mysql/mysql-5.1-new-maint
-
unknown authored
(as part of the auto_increment cleanup of WL#3146; let's not be sad, that monster push still removed serious bugs): one problem with INSERT DELAYED (unexpected interval releases), one with stored functions (wrong auto_inc binlogging). These bugs were not released. mysql-test/extra/binlog_tests/binlog_insert_delayed.test: more tests of binlogging of INSERT DELAYED: with multi-row INSERTs. I identified why sleeps are needed to get a repeatable row-based binlogged: because without sleeps rows sometimes get groupped and so generate different row based events. mysql-test/extra/rpl_tests/rpl_foreign_key.test: don't forget to drop tables on slave too, otherwise it leaves an orphan innodb table leading to rpl_insert_id failing sometimes (like in pushbuild "sapsrv2 -max"). mysql-test/extra/rpl_tests/rpl_insert_id.test: testing that if some statement does not update any row, it does not pollute the auto_inc binlog variables of the next statement; the test has to use stored procedures because with plain statements, mysql_reset_thd_for_next_command() does the resetting (and thus there is no problem); mysql_reset_thd_for_next_command() is not called inside routines. mysql-test/r/binlog_row_binlog.result: result additions mysql-test/r/binlog_statement_insert_delayed.result: result additions mysql-test/r/binlog_stm_binlog.result: result additions mysql-test/r/rpl_insert_id.result: result additions mysql-test/r/rpl_loaddata.result: With the change to log.cc reverted, the result changes and is better: the change to log.cc had caused some INSERT_ID events to disappear though they were necessary (but testsuite could not catch that because it's single-threaded). mysql-test/r/rpl_ndb_insert_ignore.result: NDB is now like other engines regarding INSERT IGNORE: autoincrement values which caused a duplicate key are re-used for next row, not lost. rpl_ndb_insert_ignore.result is now identical to rpl_insert_ignore.result. sql/log.cc: LOAD DATA INFILE is binlogged as several events, and the last of them must have the auto_inc id. So it's wrong to reset the auto_inc id after every binlog write (because then it's lost after the first event of LOAD DATA INFILE and so missing for the last one)/ Another problem: MYSQL_LOG::write() is not always called (for example if no row was updated), so we were missing reset in some cases. sql/sp_head.cc: SELECT func1(),func2() generates two binlog events, so needs to clear auto_increment binlog variables after each binlog event (it would be more natural to clear them in the log write code, but LOAD DATA INFILE would suffer from this see the cset comment for log.cc). Without the clearing, the problem is: > exec func1() >> call cleanup_after_query() (which does not clear our vars here) >> binlog SELECT func1() < > exec func2() and so SELECT func2() is binlogged with the auto_inc of SELECT func1(). sql/sql_class.cc: after every statement we should clear auto_inc variables used for binlogging, except if this was a function/trigger (in which case it may be "INSERT SELECT func()", where the cleanup_after_query() executed in func() should not reset the auto_inc binlog variables as they'll be necessary when binlogging the INSERT SELECT later). sql/sql_insert.cc: - as INSERT DELAYED uses the same TABLE object as the delayed_insert system thread, we should not call ha_release_auto_increment() from INSERT DELAYED (and btw it's logical as we reserve nothing as we don't perform the insert). Calling the function caused us to release values being used by the delayed_insert thread. So I do the call only if this is a non-DELAYED INSERT. - Assuming two INSERT DELAYED which get grouped by the delayed_insert thread, the second may use values reserved by the first, which is ok per se, but is a problem in statement-based binlogging: the 2nd INSERT gets binlogged with the "interval start" value of the first INSERT (=> duplicate error in slave). - no reason to ha_release_auto_increment() after every inserted row in INSERT SELECT; more efficient to do it only when the statement ends sql/sql_parse.cc: a comment
-
unknown authored
into neptunus.(none):/home/msvensson/mysql/mysql-5.1-new-maint client/mysqldump.c: Auto merged
-
unknown authored
into neptunus.(none):/home/msvensson/mysql/mysql-5.1-new-maint
-
unknown authored
into neptunus.(none):/home/msvensson/mysql/mysql-5.1-new-maint sql/share/errmsg.txt: Auto merged storage/innobase/Makefile.am: Auto merged storage/innobase/handler/ha_innodb.cc: SCCS merged
-
unknown authored
into naruto.:C:/cpp/mysql-5.1-maint storage/myisam/mi_locking.c: Auto merged
-
unknown authored
- When an ALTER TABLE RENAME is performed on windows, the files are closed and their cached file descriptors are marked invalid. Performing INSERT, UPDATE or SELECT on the associated merge table causes a server crash on windows. This patch adds a test for bad file descriptors when a table attempts a lock. If a bad descriptor is found an error is thrown. An additional FLUSH TABLES will be necessary to further operate on the associated merge table. myisam/mi_locking.c: This patch prevents the windows built to crash if the file is closed. mysql-test/r/windows.result: Added test case for the windows built. mysql-test/t/windows.test: Added test case for the windows built.
-
unknown authored
Fixing failed merge sql/log.cc: Fixing failed merge
-
unknown authored
More specifically, the scripts/Makefile isn't created and it doesn't translate mysql_fix_privilege_tables ".sh" . So, mysql-test/mysql-test-run.pl doesn't find the binary and substitutes /bin/false instead. That obviously doesn't "fix" anything and the test fails because of it. mysql-test/t/system_mysql_db_fix.test: Change stolen from the -win tree.
-
- 11 Sep, 2006 11 commits
-
-
unknown authored
sql/sql_yacc.yy: Manual merge
-
unknown authored
into mysql.com:/users/lthalmann/bk/MERGE/mysql-5.1-merge sql/sql_yacc.yy: Auto merged client/mysqldump.c: Manual merge (rpl 5.0 -> rpl 5.1) mysql-test/r/mysqldump.result: Manual merge (rpl 5.0 -> rpl 5.1) mysql-test/t/mysqldump.test: Manual merge (rpl 5.0 -> rpl 5.1)
-
unknown authored
into bk-internal.mysql.com:/data0/bk/mysql-5.1-kt
-
unknown authored
-
unknown authored
into mysql.com:/users/lthalmann/bk/MERGE/mysql-5.0-merge sql/sql_yacc.yy: Manual merge (rpl 4.1 -> rpl 5.0)
-
unknown authored
into mysql.com:/users/lthalmann/bk/MERGE/mysql-5.1-merge BitKeeper/deleted/.del-rpl_heap.test: Auto merged Makefile.am: Auto merged mysql-test/extra/binlog_tests/binlog.test: Auto merged mysql-test/r/binlog_stm_binlog.result: Auto merged mysql-test/r/rpl_switch_stm_row_mixed.result: Auto merged mysql-test/t/date_formats.test: Auto merged mysql-test/t/mysqlbinlog.test: Auto merged mysql-test/t/rpl_trigger.test: Auto merged sql/CMakeLists.txt: Auto merged sql/Makefile.am: Auto merged sql/field.cc: Auto merged sql/field.h: Auto merged sql/log.cc: Auto merged sql/mysql_priv.h: Auto merged sql/mysqld.cc: Auto merged sql/sql_class.cc: Auto merged sql/sql_insert.cc: Auto merged storage/innobase/handler/ha_innodb.cc: Auto merged unittest/README.txt: Auto merged unittest/unit.pl: Auto merged mysql-test/t/disabled.def: Merge (main -> rpl 5.1)
-
unknown authored
into mysql.com:/users/lthalmann/bk/MERGE/mysql-5.0-merge client/mysqldump.c: Auto merged mysql-test/r/mysqldump.result: Manual merge (main -> rpl 5.0) mysql-test/t/mysqldump.test: Manual merge (main -> rpl 5.0)
-
unknown authored
-
unknown authored
into mysql.com:/users/lthalmann/bk/MERGE/mysql-4.1-merge
-
unknown authored
into romeo.(none):/home/bk/w3259-mysql-5.1-new-rpl
-
unknown authored
Adding files to CMakeLists.txt sql/CMakeLists.txt: Adding rpl_utility.cc
-
- 09 Sep, 2006 1 commit
-
-
unknown authored
-