1. 07 Dec, 2005 1 commit
    • unknown's avatar
      Fix for bug #11555 "Stored procedures: current SP tables locking make · 0c8e312c
      unknown authored
      impossible view security".
      
      We should not expose names of tables which are explicitly or implicitly (via
      routine or trigger) used by view even if we find that they are missing.
      So during building of list of prelocked tables for statement we track which
      routines (and therefore tables for these routines) are used from views. We
      mark elements of LEX::routines set which correspond to routines used in views
      by setting Sroutine_hash_entry::belong_to_view member to point to TABLE_LIST
      object for topmost view which uses routine. We propagate this mark to all
      routines which are used by this routine and which we add to this set. We also
      mark tables used by such routine which we add to the list of tables for
      prelocking as belonging to this view.
      
      
      mysql-test/r/sp-error.result:
        Added test for bug #11555 "Stored procedures: current SP tables locking make 
        impossible view security".
      mysql-test/r/view.result:
        We should not expose tables which are expicitly/implicitly used in view in
        check table statement.
      mysql-test/t/sp-error.test:
        Added test for bug #11555 "Stored procedures: current SP tables locking make 
        impossible view security".
      mysql-test/t/view.test:
        Removed comment obsoleted by bugfix.
      sql/sp.cc:
        We should not expose names of tables which are explicitly or implicitly
        (via routine or trigger) used by view even if we find that they are missing.
        So during building of list of prelocked tables for statement we track which
        routines (and therefore tables for these routines) are used from views. We
        mark elements of LEX::routines set which correspond to routines used in views
        by setting Sroutine_hash_entry::belong_to_view member to point to TABLE_LIST
        object for topmost view which uses routine. We propagate this mark to all
        routines which are used by this routine and which we add to this set. We also
        mark tables used by such routine which we add to the list of tables for
        prelocking as belonging to this view.
      sql/sp.h:
        sp_cache_routines_and_add_tables_for_view()/for_triggers():
          To be able to determine correctly uppermost view which uses this view/table
          with trigger we have to pass pointer to TABLE_LIST object instead of pointer
          to view's LEX or to Table_triggers_list object.
      sql/sp_head.cc:
        sp_head::add_used_tables_to_table_list():
          Added new argument which allows to mark tables which are added to table
          list for prelocking as belonging to view (this allows properly hide names
          of tables which are used in routines used by views).
      sql/sp_head.h:
        sp_head::add_used_tables_to_table_list():
          Added new argument which allows to mark tables which are added to table
          list for prelocking as belonging to view (this allows properly hide names
          of tables which are used in routines used by views).
      sql/sql_base.cc:
        open_tables():
          sp_cache_routines_and_add_tables_for_view()/for_triggers() now accept
          pointer to table list element as last argument, this allows them to determine
          correctly uppermost view which uses this view/table with trigger.
      sql/sql_trigger.h:
        Table_triggers_list:
          sp_cache_routines_and_add_tables_for_triggers() now accept pointer to table
          list element as last argument, this allows to determine correctly uppermost
          view which uses this table with trigger.
      0c8e312c
  2. 25 Nov, 2005 7 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · c1775bdc
      unknown authored
      into  mysql.com:/opt/local/work/mysql-5.0-root
      
      c1775bdc
    • unknown's avatar
      Post-merge fixes. · 81a083e7
      unknown authored
      81a083e7
    • unknown's avatar
      Merge mysql.com:/opt/local/work/mysql-4.1-root · 9f58318c
      unknown authored
      into  mysql.com:/opt/local/work/mysql-5.0-root
      
      
      mysql-test/r/ndb_alter_table.result:
        Auto merged
      mysql-test/r/ndb_basic.result:
        Auto merged
      mysql-test/t/select.test:
        Auto merged
      sql/handler.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/table.cc:
        Auto merged
      vio/vio.c:
        Auto merged
      vio/viossl.c:
        Auto merged
      include/my_base.h:
        Manual merge.
      mysql-test/r/ps.result:
        Manual merge.
      mysql-test/r/select.result:
        Manual merge.
      mysql-test/t/ndb_alter_table.test:
        Manual merge.
      mysql-test/t/ndb_basic.test:
        Manual merge.
      mysql-test/t/ps.test:
        Manual merge.
      sql-common/client.c:
        k	
      sql/ha_ndbcluster.cc:
        Manual merge.
      sql/item.cc:
        Manual merge.
      sql/sql_table.cc:
        Manual merge.
      9f58318c
    • unknown's avatar
      A fix and a test case for Bug#14410 "Crash in Enum or Set type in · fe1f7430
      unknown authored
      CREATE TABLE and PS/SP": make sure that 'typelib' object for
      ENUM values and 'Item_string' object for DEFAULT clause are 
      created in the statement memory root.
      
      
      mysql-test/r/ps.result:
        Test results has been fixed (Bug#14410)
      mysql-test/t/ps.test:
        A test case for Bug#14410 "Crash in Enum or Set type in CREATE 
        TABLE and PS/SP"
      sql/mysql_priv.h:
        typelib() function declaration has been changed.
      sql/sql_table.cc:
        Supply the statement memory root to use in typelib() and
        safe_charset_converter() functions to ensure that objects 
        created during the first execution of CREATE TABLE statement
        are allocated in persistent memory of the statement.
      sql/table.cc:
        Change typelib() function to require MEM_ROOT.
      fe1f7430
    • unknown's avatar
      Merge mskold@bk-internal.mysql.com:/home/bk/mysql-4.1 · 370ec7c3
      unknown authored
      into  mysql.com:/usr/local/home/marty/MySQL/mysql-4.1
      
      370ec7c3
    • unknown's avatar
      Updated expected error · 920e6617
      unknown authored
      920e6617
    • unknown's avatar
      Merge abarkov@bk-internal.mysql.com:/home/bk/mysql-5.0 · eeed339b
      unknown authored
      into  mysql.com:/usr/home/bar/mysql-5.0.b14146
      
      
      sql/item_strfunc.cc:
        Auto merged
      sql/item_strfunc.h:
        Auto merged
      eeed339b
  3. 24 Nov, 2005 24 commits
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0 · d5ca5572
      unknown authored
      into moonbone.local:/work/13293-bug-5.0-mysql
      
      d5ca5572
    • unknown's avatar
      Remove t3 in join_nested.test · 56450769
      unknown authored
      
      mysql-test/r/join_nested.result:
        Remove t3 too.
      mysql-test/t/join_nested.test:
        Remove t3 too.
      56450769
    • unknown's avatar
      Merge mysql.com:/usr/local/bk/mysql-5.0 · 7450e7af
      unknown authored
      into  mysql.com:/usr/home/pem/bug13729/mysql-5.0
      
      7450e7af
    • unknown's avatar
      Merge mysql.com:/usr/local/bk/mysql-5.0 · 8557b98f
      unknown authored
      into  mysql.com:/usr/home/pem/bug13729/mysql-5.0
      
      8557b98f
    • unknown's avatar
      Some post-merge cleaning, and made assert THD::store_globals() work at all times. · 9a6a557b
      unknown authored
      
      mysql-test/t/sp.test:
        Tidying up after merge.
      sql/mysqld.cc:
        Make sure we have thd->thread_stack set before calling store_globals().
        (And fixed compiler warning.)
      sql/sql_class.cc:
        Init THD::tread_stack in constructor.
      9a6a557b
    • unknown's avatar
      don't call handler::info() in SHOW CREATE TABLE · 4185f2b9
      unknown authored
      4185f2b9
    • unknown's avatar
      Fix bug#13293 Wrongly used index results in endless loop. · 5f120f6b
      unknown authored
      Loose index scan using only second part of multipart index was choosen, which
      results in creating wrong keys and endless loop.
      
      get_best_group_min_max() now allows loose index scan for distinct only if used
      keyparts forms a prefix of the index.
      
      
      mysql-test/t/group_min_max.test:
        Test case for bug #13293 Wrongly used index results in endless loop.
      mysql-test/r/group_min_max.result:
        Test case for bug #13293 Wrongly used index results in endless loop.
      sql/opt_range.cc:
        Fix bug #13293 Wrongly used index results in endless loop.
        get_best_group_min_max() now allows loose index scan for distinct only if used keyparts forms a prefix of the index.
      5f120f6b
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-4.1 · 0541f87d
      unknown authored
      into moonbone.local:/work/14482-bug-4.1-mysql
      
      0541f87d
    • unknown's avatar
      Fix bug #14482 Wrongly applied optimization in resolve_const_item() caused · 76fb5711
      unknown authored
      crash
      
      resolve_const_item() substitutes item which will evaluate to constant with
      equvalent constant item, basing on the item's result type. In this case
      subselect was resolved as constant, and resolve_const_item() was substituting
      it's result's Item_caches to Item_null. Later Item_cache's function was called
      for Item_null object, which caused server crash.
      
      resolve_const_item() now substitutes constants for items with 
      result_type == ROW_RESULT only for Item_rows.
      
      
      sql/item.cc:
        Fix bug #14482 Wrongly applied optimization in resolve_const_item() caused
        crash
        
        resolve_const_item() now applies optimization for items with
        result_type == ROW_RESULT only to Item_rows.
      mysql-test/t/select.test:
        Test case for bug #14482 Wrongly applied optimization in resolve_const_item() caused crash
      mysql-test/r/select.result:
        Test case for bug #14482 Wrongly applied optimization in resolve_const_item() caused crash
      76fb5711
    • unknown's avatar
      Make it buildable with -ansi flag on some platforms. · 9c287ff6
      unknown authored
      
      extra/innochecksum.c:
        Define _XOPEN_SOURCE in order to include getopt.h when needed.
        
        The problem is that some platforms (for instance,
        SuSE 9.1/gcc-3.3.3) do not include getopt.h unless _XOPEN_SOURCE
        is defined, so optarg is undefined and the compiler complains.
      9c287ff6
    • unknown's avatar
      Polishing: get rid of C++-style comments. · 410c1e3a
      unknown authored
      
      mysys/my_open.c:
        Get rid of C++-style comments.
      410c1e3a
    • unknown's avatar
      Merge mskold@bk-internal.mysql.com:/home/bk/mysql-4.1 · 1724f2fa
      unknown authored
      into  mysql.com:/usr/local/home/marty/MySQL/mysql-4.1
      
      
      sql/ha_ndbcluster.cc:
        Auto merged
      1724f2fa
    • unknown's avatar
      Moved check of wrong schema version earlier · 314d9a06
      unknown authored
      314d9a06
    • unknown's avatar
      Merge rkalimullin@bk-internal.mysql.com:/home/bk/mysql-5.0 · 40524854
      unknown authored
      into  mysql.com:/usr/home/ram/work/5.0.b15047
      
      40524854
    • unknown's avatar
      table t7 was not dropped at the end · 0d41550e
      unknown authored
      
      mysql-test/r/join_nested.result:
        drop t7
      mysql-test/t/join_nested.test:
        drop t7
      0d41550e
    • unknown's avatar
      Merge mysql.com:/usr/local/bk/mysql-5.0 · 48c75428
      unknown authored
      into  mysql.com:/usr/home/pem/bug13729/mysql-5.0
      
      48c75428
    • unknown's avatar
      Merge rkalimullin@bk-internal.mysql.com:/home/bk/mysql-5.0 · 23775d21
      unknown authored
      into  mysql.com:/usr/home/ram/work/5.0.b15047
      
      23775d21
    • unknown's avatar
      small build fix for some compilers · 0ab15c6e
      unknown authored
      
      ndb/src/common/mgmcommon/ConfigRetriever.cpp:
        build fix for some compilers
      0ab15c6e
    • unknown's avatar
      Merge rkalimullin@bk-internal.mysql.com:/home/bk/mysql-5.0 · dfb5017e
      unknown authored
      into  mysql.com:/usr/home/ram/work/5.0.b15047
      
      dfb5017e
    • unknown's avatar
      Merge mysql.com:/usr/local/bk/mysql-5.0 · 63881585
      unknown authored
      into  mysql.com:/usr/home/pem/bug13729/mysql-5.0
      
      
      mysql-test/r/sp.result:
        Manual merge fix.
      mysql-test/t/sp.test:
        Manual merge fix.
      63881585
    • unknown's avatar
      Merge mysql.com:/home/stewart/Documents/MySQL/5.0/main · 613f74fa
      unknown authored
      into  mysql.com:/home/stewart/Documents/MySQL/5.0/bug15215
      
      613f74fa
    • unknown's avatar
      Merge rkalimullin@bk-internal.mysql.com:/home/bk/mysql-5.0 · 2f4e896d
      unknown authored
      into  mysql.com:/usr/home/ram/work/5.0.b15047
      
      
      sql/sql_class.h:
        Auto merged
      2f4e896d
    • unknown's avatar
      BUG#15215 mysqld fails at start-up because of illegal reply from mgmd · 93e5ac20
      unknown authored
      In the rare circumstance where a mysqld connects to a mgm server, then the
      mgm server goes away before a node id can be allocated, it was possible to get
      an Error in mgm protocol parser error message.
      
      
      ndb/src/common/mgmcommon/ConfigRetriever.cpp:
        When allocating node id, retry connecting to a management server if it goes away.
      ndb/src/mgmapi/mgmapi.cpp:
        Treat Eof and NoLine results from the parser as a sign that we should disconnect
        from this management server. It's up to the caller to work out if they want
        to try again.
      93e5ac20
    • unknown's avatar
      Don't use PATH_MAX for FN_REFLEN as this uses too much stack space · 6eed9d51
      unknown authored
      Larger stack size neaded for open table on x86 64 bit
      Fix failing test cases
      Deleted symlink from bk
      
      
      BitKeeper/etc/ignore:
        added libmysqld/ha_blackhole.cc
      BitKeeper/deleted/.del-ha_blackhole.cc~727c69ef7846623a:
        Delete: libmysqld/ha_blackhole.cc
      include/my_global.h:
        Don't use PATH_MAX for FN_REFLEN as this uses too much stack space.
        (With a PATH_MAX of 4096, we use 80K for opening a table as there is several objects of size FN_REFLEN on stack)
      mysql-test/r/federated.result:
        Update results after error message changes
      mysql-test/r/grant.result:
        Update results after error message changes
      mysql-test/r/grant2.result:
        Update results after error message changes
      sql/ha_federated.cc:
        Fix error messages to be more consistent
      sql/mysql_priv.h:
        Stack size to have when opening a table
        (This was needed on x86 64 bit Linux)
      sql/share/errmsg.txt:
        Remove quotes around error string for federated as two quotes in the output looks strange
      sql/sql_base.cc:
        More correct stack size
      sql/sql_parse.cc:
        Set thread_stack before store_globals()
      sql/unireg.h:
        More correct MAX_DBKEY_LENGTH
      6eed9d51
  4. 23 Nov, 2005 8 commits