1. 27 Oct, 2006 4 commits
  2. 26 Oct, 2006 1 commit
  3. 25 Oct, 2006 5 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0-engines · b3e1dd37
      unknown authored
      into  chilla.local:/home/mydev/mysql-5.0-bug22119
      
      b3e1dd37
    • unknown's avatar
      Merge chilla.local:/home/mydev/mysql-4.1-bug22119 · ad3390a7
      unknown authored
      into  chilla.local:/home/mydev/mysql-5.0-bug22119
      
      
      myisam/mi_check.c:
        Auto merged
      ad3390a7
    • unknown's avatar
      Bug#22119 - Changing MI_KEY_BLOCK_LENGTH makes a wrong myisamchk · b5d19148
      unknown authored
      When compiling with a default key block size greater than the
      smallest key block size used in a table, checking that table
      failed with bogus errors. The table was marked corrupt. This
      affected myisamchk and the server.
      
      The problem was that the default key block size was used at
      some places where sizes less or equal to the block size of the
      index in check was required.
      
      We do now use the key block size of the particular index
      when checking.
      
      A test case is available for later versions only.
      
      
      myisam/mi_check.c:
        Bug#22119 - Changing MI_KEY_BLOCK_LENGTH makes a wrong myisamchk
        Changed check_k_link() and chk_index_down() to use the block
        size of the index in check or MI_MIN_KEY_BLOCK_LENGTH where
        required. Formerly myisam_block_size or MYISAM_SHARE::blocksize
        was used wrongly.
      b5d19148
    • unknown's avatar
      Merge mysql.com:/home/svoj/devel/mysql/BUG22053/mysql-4.1-engines · 3e548a3c
      unknown authored
      into  mysql.com:/home/svoj/devel/mysql/BUG22053/mysql-5.0-engines
      
      
      myisam/mi_dynrec.c:
        Auto merged
      3e548a3c
    • unknown's avatar
      BUG#22053 - REPAIR table can crash server for some · 115fe018
      unknown authored
                  really damaged MyISAM tables
      
      When unpacking a blob column from broken row server crash
      could happen. This could rather happen when trying to repair
      a table using either REPAIR TABLE or myisamchk, though it
      also could happend when trying to access broken row using
      other SQL statements like SELECT if table is not marked as
      crashed.
      
      Fixed ulong overflow when trying to extract blob from
      broken row.
      
      Affects MyISAM only.
      
      
      myisam/mi_dynrec.c:
        Fixed ulong overflow when trying to extract blob from
        broken row. It happens when there are not enough bytes
        to store blob length in `from' buffer. In this case
        (ulong) (from_end - from) - size_length value is huge,
        close to ULONG_MAX.
      115fe018
  4. 24 Oct, 2006 1 commit
  5. 21 Oct, 2006 1 commit
  6. 20 Oct, 2006 7 commits
    • unknown's avatar
      configure.in: · 7632cf5b
      unknown authored
        Raised version number to 5.0.28
      
      
      configure.in:
        Raised version number to 5.0.28
      7632cf5b
    • unknown's avatar
      Merge mysql.com:/Users/kent/mysql/bk/mysql-5.0.27-release · 82ae9e46
      unknown authored
      into  mysql.com:/Users/kent/mysql/bk/mysql-5.0
      
      
      configure.in:
        Auto merged
      82ae9e46
    • unknown's avatar
      make_win_bin_dist: · 7ac5d475
      unknown authored
        Copy udf examples and raid.h
        Create target "include" directory before copying files to it
      CMakeLists.txt:
        Only compile in bdb if configured
      configure.in:
        Raised version number to 5.0.27
      
      
      scripts/make_win_bin_dist:
        Copy udf examples and raid.h
        Create target "include" directory before copying files to it
      CMakeLists.txt:
        Only compile in bdb if configured
      configure.in:
        Raised version number to 5.0.27
      7ac5d475
    • unknown's avatar
      Bug #23427: incompatible ABI change in 5.0.26? · aaf7228f
      unknown authored
      Revert 1 June change enough to restore ABI compatibility with previous
      versions.
      
      
      include/mysql.h:
        Revert patch that breaks ABI compatibility
      libmysqld/lib_sql.cc:
        Remove useless assignment.
      aaf7228f
    • unknown's avatar
      Merge dl145s.mysql.com:/data/bk/team_tree_merge/MERGE/mysql-4.1-opt · a5a18a77
      unknown authored
      into  dl145s.mysql.com:/data/bk/team_tree_merge/MERGE/mysql-5.0-opt
      
      
      sql/sql_base.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      a5a18a77
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.0 · 6e7da3ee
      unknown authored
      into  dl145s.mysql.com:/data/bk/team_tree_merge/MERGE/mysql-5.0-opt
      
      
      mysql-test/r/myisam.result:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      6e7da3ee
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-4.1 · a2a77ea2
      unknown authored
      into  dl145s.mysql.com:/data/bk/team_tree_merge/MERGE/mysql-4.1-opt
      
      
      sql/sql_base.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      a2a77ea2
  7. 19 Oct, 2006 12 commits
  8. 18 Oct, 2006 2 commits
    • unknown's avatar
      Merge mysql.com:/data0/bk/mysql-5.0 · df594b54
      unknown authored
      into  mysql.com:/data0/bk/mysql-5.0-kt
      
      df594b54
    • unknown's avatar
      BUG#23175 - MYISAM crash/repair failed during repair · 48e84fb9
      unknown authored
      Repair table could crash a server if there is not sufficient
      memory (myisam_sort_buffer_size) to operate. Affects not only
      repair, but also all statements that use create index by sort:
      repair by sort, parallel repair, bulk insert.
      
      Return an error if there is not sufficient memory to store at
      least one key per BUFFPEK.
      
      Also fixed memory leak if thr_find_all_keys returns an error.
      
      
      myisam/sort.c:
        maxbuffer is number of BUFFPEK-s for repair. It is calculated
        as records / keys. keys is number of keys that can be stored
        in memory (myisam_sort_buffer_size). There must be sufficient
        memory to store both BUFFPEK-s and keys. It was checked
        correctly before this patch. However there is another
        requirement that wasn't checked: there must be sufficient
        memory for at least one key per BUFFPEK, otherwise repair
        by sort/parallel repair cannot operate.
        
        Return an error if there is not sufficient memory to store at
        least one key per BUFFPEK.
        
        Also fixed memory leak if thr_find_all_keys returns an error.
      mysql-test/r/repair.result:
        A test case for BUG#23175.
      mysql-test/t/repair.test:
        A test case for BUG#23175.
      48e84fb9
  9. 17 Oct, 2006 7 commits
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 2a951698
      unknown authored
      into  sunlight.local:/local_work/14959-bug-5.0-opt-mysql
      
      2a951698
    • unknown's avatar
      sql_rename.cc: · fc075268
      unknown authored
        Cleanup of fix for bug#14959.
      
      
      sql/sql_rename.cc:
        Cleanup of fix for bug#14959.
      fc075268
    • unknown's avatar
      Merge ibabaev@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · d85dfe59
      unknown authored
      into  rurik.mysql.com:/home/igor/mysql-5.0-opt
      
      
      sql/sql_select.cc:
        Auto merged
      d85dfe59
    • unknown's avatar
      Merge rurik.mysql.com:/home/igor/mysql-5.0-opt · 88df828b
      unknown authored
      into  rurik.mysql.com:/home/igor/dev-opt/mysql-5.0-opt-bug19579
      
      
      mysql-test/t/select.test:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      mysql-test/r/select.result:
        SCCS merged
      88df828b
    • unknown's avatar
      ba127a9e
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.0-opt · 964a52b4
      unknown authored
      into  macbook.gmz:/Users/kgeorge/mysql/work/B21798-5.0-opt-merge
      
      
      sql/mysql_priv.h:
        Auto merged
      sql/sql_delete.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      sql/sql_update.cc:
        Auto merged
      mysql-test/r/subselect.result:
        merge fixes for bug 21798
      mysql-test/t/subselect.test:
        merge fixes for bug 21798
      964a52b4
    • unknown's avatar
      Bug#21798: memory leak during query execution with subquery in column · ce5b38bd
      unknown authored
                  list using a function
      When executing dependent subqueries they are re-inited and re-exec() for 
      each row of the outer context.
      The cause for the bug is that during subquery reinitialization/re-execution,
      the optimizer reallocates JOIN::join_tab, JOIN::table in make_simple_join()
      and the local variable in 'sortorder' in create_sort_index(), which is
      allocated by make_unireg_sortorder().
      Care must be taken not to allocate anything into the thread's memory pool
      while re-initializing query plan structures between subquery re-executions.
      All such items mush be cached and reused because the thread's memory pool
      is freed at the end of the whole query.
      Note that they must be cached and reused even for queries that are not 
      otherwise cacheable because otherwise it will grow the thread's memory 
      pool every time a cacheable query is re-executed. 
      We provide additional members to the JOIN structure to store references 
      to the items that need to be cached.
      
      
      mysql-test/r/subselect.result:
        Bug#21798: memory leak during query execution with subquery in column
                    list using a function
         - test case
      mysql-test/t/subselect.test:
        Bug#21798: memory leak during query execution with subquery in column
                    list using a function
         - test case
      sql/mysql_priv.h:
        Bug#21798: memory leak during query execution with subquery in column
                    list using a function
         - cache the entities allocated in the threads memory pool by
           JOIN::exec ().
      sql/sql_delete.cc:
        Bug#21798: memory leak during query execution with subquery in column
                    list using a function
         - cache the SORT_ORDER, TABLE * and JOIN_TAB allocated in the thread's 
           memory pool by JOIN::exec ().
      sql/sql_select.cc:
        Bug#21798: memory leak during query execution with subquery in column
                    list using a function
         - cache the SORT_ORDER, TABLE * and JOIN_TAB allocated in the thread's 
           memory pool by JOIN::exec ().
      sql/sql_select.h:
        Bug#21798: memory leak during query execution with subquery in column
                    list using a function
         - cache the SORT_ORDER, TABLE * and JOIN_TAB allocated in the thread's 
           memory pool by JOIN::exec ().
      sql/sql_table.cc:
        Bug#21798: memory leak during query execution with subquery in column
                    list using a function
         - cache the SORT_ORDER, TABLE * and JOIN_TAB allocated in the thread's 
           memory pool by JOIN::exec ().
      sql/sql_update.cc:
        Bug#21798: memory leak during query execution with subquery in column
                    list using a function
         - cache the SORT_ORDER, TABLE * and JOIN_TAB allocated in the thread's 
           memory pool by JOIN::exec ().
      ce5b38bd