1. 22 Jan, 2019 1 commit
    • Julius Goryavsky's avatar
      MDEV-17835: Remove wsrep-sst-method=xtrabackup · 0e89e90f
      Julius Goryavsky authored
      The second line of changes related to replacing xtrabackup with
      mariabackup:
      
      1) All unnecessary references to xtrabackup are removed from
      the documentation, from some comments, from the control files
      that are used to prepare the packages.
      
      2) Made corrections of the tests from the galera_3nodes suite
      that mentioned xtrabackup or the old (associated with xtrabackup)
      version of innobackupex.
      
      3) Fixed flaws in the galera_3nodes mtr suite control scripts,
      because of which they could not work with mariabackup.
      
      4) Fixed numerous bugs in the SST scripts and in the mtr test
      files (galera_3nodes mtr suite) that prevented the use of Galera
      with IPv6 addresses.
      
      5) Fixed flaws in tests for rsync and mysqldump (for galera_3nodes
      mtr tests suite). These tests were not performed successfully without
      these fixes.
      
      https://jira.mariadb.org/browse/MDEV-17835
      0e89e90f
  2. 27 Dec, 2018 2 commits
    • Marko Mäkelä's avatar
      Follow-up to MDEV-14585: Remove dict_temp_file_num · ab4bc844
      Marko Mäkelä authored
      Now that InnoDB startup drops tables whose name starts with #sql,
      the table ID alone should be enough to create a unique table name.
      
      dict_temp_file_num, dict_mem_init(): Remove.
      
      dict_mem_create_temporary_tablename(): Use a combination of
      "#sql-ib" and the ID of the table that is being rebuilt
      in TRUNCATE TABLE, or discarded in the commit of table-rebuilding
      ALTER TABLE...ALGORITHM=INPLACE, or deferred to the DROP queue.
      
      Thanks to Sergey Vojtovich for pointing this out.
      ab4bc844
    • Teodor Mircea Ionita's avatar
      e2939795
  3. 26 Dec, 2018 1 commit
  4. 24 Dec, 2018 1 commit
  5. 23 Dec, 2018 2 commits
  6. 21 Dec, 2018 1 commit
  7. 20 Dec, 2018 1 commit
  8. 18 Dec, 2018 6 commits
  9. 17 Dec, 2018 11 commits
    • Marko Mäkelä's avatar
      MDEV-12112: Support WITH_INNODB_BUG_ENDIAN_CRC32 · ed13a0d2
      Marko Mäkelä authored
      fil_space_verify_crypt_checksum(): Compute the bug-compatible variant
      of the CRC-32C checksum if the correct one does not match.
      ed13a0d2
    • Marko Mäkelä's avatar
      Merge 10.1 into 10.2 · fae7e350
      Marko Mäkelä authored
      fae7e350
    • Marko Mäkelä's avatar
      Fix a compiler warning · 51a1fc73
      Marko Mäkelä authored
      fil_space_verify_crypt_checksum(): Add a dummy return statement
      in case memory is corrupted and innodb_checksum_algorithm has
      an invalid value.
      51a1fc73
    • Marko Mäkelä's avatar
      Merge 10.1 into 10.2 · 7d245083
      Marko Mäkelä authored
      7d245083
    • Marko Mäkelä's avatar
      Follow-up to MDEV-12112: corruption in encrypted table may be overlooked · 8c43f963
      Marko Mäkelä authored
      The initial fix only covered a part of Mariabackup.
      This fix hardens InnoDB and XtraDB in a similar way, in order
      to reduce the probability of mistaking a corrupted encrypted page
      for a valid unencrypted one.
      
      This is based on work by Thirunarayanan Balathandayuthapani.
      
      fil_space_verify_crypt_checksum(): Assert that key_version!=0.
      Let the callers guarantee that. Now that we have this assertion,
      we also know that buf_page_is_zeroes() cannot hold.
      Also, remove all diagnostic output and related parameters,
      and let the relevant callers emit such messages.
      Last but not least, validate the post-encryption checksum
      according to the innodb_checksum_algorithm (only accepting
      one checksum for the strict variants), and no longer
      try to validate the page as if it was unencrypted.
      
      buf_page_is_zeroes(): Move to the compilation unit of the only callers,
      and declare static.
      
      xb_fil_cur_read(), buf_page_check_corrupt(): Add a condition before
      calling fil_space_verify_crypt_checksum(). This is a non-functional
      change.
      
      buf_dblwr_process(): Validate the page only as encrypted or unencrypted,
      but not both.
      8c43f963
    • Jan Lindström's avatar
      Merge pull request #1030 from tempesta-tech/sysprg/MDEV-17848 · 36b7f8f4
      Jan Lindström authored
      MDEV-17848: Galera test failure on galera_sst_xtrabackup-v2[_data_dir]
      36b7f8f4
    • Marko Mäkelä's avatar
      Fix USE_AFTER_FREE (CWE-416) · 10e01b56
      Marko Mäkelä authored
      A static analysis tool suggested that in the function
      row_merge_read_clustered_index(), ut_free(nonnull) could
      be invoked twice for nonnull!=NULL. While a manual review
      of the code disproved this, it should not hurt to clean up
      the code so that the static analysis tool will not complain.
      
      index_tuple_info_t::insert(), row_mtuple_cmp(): Remove the
      parameter mtr_committed, which duplicated !mtr->is_active().
      
      row_merge_read_clustered_index(): Initialize row_heap = NULL.
      Remove a duplicated call mem_heap_empty(row_heap) that was
      inadvertently added in commit cb1e76e4.
      
      Replace a "goto func_exit" with "break", to get consistent error
      handling for both failures to create or write a temporary file.
      
      end_of_index: Assign row_heap=NULL and nonnull=NULL to prevent
      double freeing.
      
      func_exit: Check for row_heap!=NULL before invoking mem_heap_free().
      
      Closes #959
      10e01b56
    • Julius Goryavsky's avatar
      DEV-17835: Remove wsrep-sst-method=xtrabackup · cadb6ac7
      Julius Goryavsky authored
      The use of the xtrabackup and xtrabackup-v2 methods for SST
      has been declared obsolete since version 10.2, now it cannot
      be used because of the different redo log format. Accordingly,
      we need to remove the xtrabackup-related scripts and dynamically
      replace the call to xtrabackup[-v2] to the mariabackup (with a
      corresponding warning in the log) when the server performs SST.
      
      https://jira.mariadb.org/browse/MDEV-17835
      cadb6ac7
    • Jan Lindström's avatar
      Merge pull request #1026 from codership/10.1-galera-defaults · 517c59c5
      Jan Lindström authored
      Remove provider defaults check from 'galera_defaults' MTR test
      517c59c5
    • Jan Lindström's avatar
      MDEV-18021: Galera test galera_sst_mariabackup_table_options fails if AES_CTR is not available · ee543bea
      Jan Lindström authored
      Problem is that if you use bundled yassl AES_CTR is not supported. There is a way to detect that but as we really want to keep this test enabled did not add
      skip for missing support. Changed method to AES_CBC as there is no need to
      use AES_CTR.
      ee543bea
    • Jan Lindström's avatar
      MDEV-17771: Add Galera ist and sst tests using mariabackup · 8a46b9fe
      Jan Lindström authored
      Add check that file key management plugin is found.
      8a46b9fe
  10. 16 Dec, 2018 3 commits
  11. 15 Dec, 2018 1 commit
  12. 14 Dec, 2018 10 commits
    • Vladislav Vaintroub's avatar
      MDEV-14975 : fix last commit's typo. · 0a2edddb
      Vladislav Vaintroub authored
      0a2edddb
    • Vladislav Vaintroub's avatar
      MDEV-14975 mariabackup starts with unprivileged user. · 5716c71c
      Vladislav Vaintroub authored
      ported privilege checking from xtrabackup.
      Now, mariabackup would terminate early if either RELOAD or PROCESS privilege
      is not held, not at the very end of backup
      
      The behavior can be disabled with nre setting --check-privileges=0.
      Also , --no-lock does not need all of these privileges, since it skips
      FTWRL and SHOW ENGINE STATUS INNODB.
      5716c71c
    • Alexey Yurchenko's avatar
      Remove provider defaults check from 'galera_defaults' MTR test · 6b818831
      Alexey Yurchenko authored
      From time to time Galera adds new parameters or changes defaults to
      existing ones. Every time this happens galera_defaults test needs a
      fix (and a commit) because it insists on checking these defaults.
      This is making life hard because any Galera update may require a fix
      to MariaDB code even though it is totally unrelated and defeats the
      whole idea of a provider living its own life.
      This commit removes checking for provider defaults to avoid false
      positive failures on MariaDB side.
      6b818831
    • Marko Mäkelä's avatar
      Merge 10.2 into 10.3 · 5fefcb0a
      Marko Mäkelä authored
      5fefcb0a
    • Marko Mäkelä's avatar
      Merge 10.1 into 10.2 · 94fa02f4
      Marko Mäkelä authored
      94fa02f4
    • Marko Mäkelä's avatar
      Work around the crash in MDEV-17814 · a2f2f686
      Marko Mäkelä authored
      Internal transactions may not have trx->mysql_thd.
      But at the same time, trx->duplicates should only hold if
      REPLACE or INSERT...ON DUPLICATE KEY UPDATE was executed from SQL.
      
      The flag feels misplaced. A more appropriate place for it would
      be row_prebuilt_t or similar.
      a2f2f686
    • Marko Mäkelä's avatar
      MDEV-12112 corruption in encrypted table may be overlooked · fb252f70
      Marko Mäkelä authored
      After validating the post-encryption checksum on an encrypted page,
      Mariabackup should decrypt the page and validate the pre-encryption
      checksum as well. This should reduce the probability of accepting
      invalid pages as valid ones.
      
      This is a backport and refactoring of a patch that was
      originally written by Thirunarayanan Balathandayuthapani
      for the 10.2 branch.
      fb252f70
    • Marko Mäkelä's avatar
      Merge 10.2 into 10.3 · cfe83862
      Marko Mäkelä authored
      cfe83862
    • Marko Mäkelä's avatar
      MDEV-17958: Make innochecksum follow the build option · dbb39a77
      Marko Mäkelä authored
      Innochecksum was being built as if WITH_INNODB_BUG_ENDIAN_CRC32:BOOL=OFF
      had been specified.
      
      Also, clean up tests:
      
      innodb.innochecksum: Useless; superceded by innodb_zip.innochecksum.
      innodb.innodb_zip_innochecksum: Remove; duplicated innodb_zip.innochecksum.
      innodb.innodb_zip_innochecksum2: Remove; duplicated innodb_zip.innochecksum_2.
      innodb.innodb_zip_innochecksum3: Remove; duplicated innodb_zip.innochecksum_3.
      
      No test case was added. I tested manually by adding debug instrumentation
      to both innochecksum and buf_page_is_checksum_valid_crc32() to make
      innochecksum write the buggy crc32, and to get warnings for falling back
      to the buggy checksum. Automating this would require that tests be
      adjusted depending on the build options.
      dbb39a77
    • Oleksandr Byelkin's avatar
      MDEV-16278: Missing DELETE operation in COM_STMT_BULK_STMT · c1caada8
      Oleksandr Byelkin authored
      Allow array binding for DELETE, test it.
      c1caada8