An error occurred fetching the project authors.
  1. 05 Sep, 2010 1 commit
    • Michael Widenius's avatar
      Fixed bug that 'maria_read_log -a' didn't set max_trid when reparing tables. · 0f3d4b2f
      Michael Widenius authored
      Fixed bug in Aria when replacing short keys with long keys and a key tree both overflow and underflow at same time.
      Fixed several bugs when generating recovery logs when using RGQ with replacing long keys with short keys and vice versa.
      Lots of new DBUG_ASSERT()'s
      Added more information to recovery log to make it easier to know from where log entry orginated.
      Introduced MARIA_PAGE->org_size that tells what the size of the page was in last log entry. This allows us to find out if all key changes for index page was logged.
      Small code cleanups:
      - Introduced _ma_log_key_changes() to log crc of key page changes
      - Added share->max_index_block_size as max size of data one can put in key block (block_size - KEYPAGE_CHECKSUM_SIZE)
        This will later simplify adding a directory to index pages.
      - Write page number instead of page postition to DBUG log
      
      
      
      mysql-test/lib/v1/mysql-test-run.pl:
        Use --general-log instead of --log to disable warning when using RQG
      sql/mysqld.cc:
        If we have already sent ok to client when we get an error, log this to stderr
        Don't disable option --log-output if CSV engine is not supported.
      storage/maria/ha_maria.cc:
        Log queries to recovery log also in LOCK TABLES
      storage/maria/ma_check.c:
        If param->max_trid is set, use this value instead of max_trid_in_system().
        This is used by recovery to set max_trid to max seen trid so far.
        keyinfo->block_length - KEYPAGE_CHECKSUM_SIZE -> max_index_block_size (Style optimization)
      storage/maria/ma_delete.c:
        Mark tables crashed early
        Write page number instead of page position to debug log.
        Added parameter to ma_log_delete() and ma_log_prefix() that is logged so that we can find where wrong log entries where generated.
        Fixed bug where a page was not proplerly written when same key tree had both an overflow and underflow when deleting a key.
        keyinfo->block_length - KEYPAGE_CHECKSUM_SIZE => max_index_block_size (Style optimization)
        ma_log_delete() now has extra parameter of how many bytes from end of page should be appended to log for page (for page overflows)
      storage/maria/ma_key_recover.c:
        Added extra parameter to ma_log_prefix() to indicate what caused log entry.
        Update MARIA_PAGE->org_size when logging info about page.
        Much more DBUG_ASSERT()'s.
        Fix some bugs in maria_log_add() to handle page overflows.
        Added _ma_log_key_changes() to log crc of key page changes.
        If EXTRA_STORE_FULL_PAGE_IN_KEY_CHANGES is defines, log the resulting pages to log so one can trivally
        see how the resulting page should have looked like (for errors in CRC values)
      storage/maria/ma_key_recover.h:
        Added _ma_log_key_changes() which is only called if EXTRA_DEBUG_KEY_CHANGES is defined.
        Updated function prototypes.
      storage/maria/ma_loghandler.h:
        Added more values to en_key_debug, to get more exact location where things went wrong when logging to recovery log.
      storage/maria/ma_open.c:
        Initialize share->max_index_block_size
      storage/maria/ma_page.c:
        Added updating and testing of MARIA_PAGE->org_size
        Write page number instead of page postition to DBUG log
        Generate error if we read page with wrong data.
        Removed wrong assert: key_del_current != share->state.key_del.
        Simplify _ma_log_compact_keypage()
      storage/maria/ma_recovery.c:
        Set param.max_trid to max seen trid before running repair table (used for alter table to create index)
      storage/maria/ma_rt_key.c:
        Update call to _ma_log_delete()
      storage/maria/ma_rt_split.c:
        Use _ma_log_key_changes()
        Update MARIA_PAGE->org_size
      storage/maria/ma_unique.c:
        Remove casts
      storage/maria/ma_write.c:
        keyinfo->block_length - KEYPAGE_CHECKSUM_SIZE => share->max_index_block_length.
        Updated calls to _ma_log_prefix()
        Changed code to use _ma_log_key_changes()
        Update ma_page->org_size
        Fixed bug in _ma_log_split() for pages that overflow
        Added KEY_OP_DEBUG logging to functions
        Log KEYPAGE_FLAG in all log entries
      storage/maria/maria_def.h:
        Added SHARE->max_index_block_size
        Added MARIA_PAGE->org_size
      storage/maria/trnman.c:
        Reset flags for new transaction.
      0f3d4b2f
  2. 30 Jul, 2010 1 commit
    • Michael Widenius's avatar
      Fix for LP#602604: RQG: ma_blockrec.c:6187:... · d2f8b7d0
      Michael Widenius authored
      Fix for LP#602604: RQG: ma_blockrec.c:6187: _ma_apply_redo_insert_row_head_or_tail: Assertion `0' failed on Maria engine recovery
      More DBUG_PRINT (to simplify future debugging)
      Aria: Added STATE_IN_REPAIR, which is set on start of repair. This allows us to see if 'crashed' flag was set intentionally.
      Aria: Some trivial speedup optimization
      Aria: Better warning if table was marked crashed by unfinnished repair
      
      
      mysql-test/lib/v1/mysql-test-run.pl:
        Fix so one can run RQG
      mysql-test/suite/maria/r/maria-recovery2.result:
        Update for new error message.
      mysys/stacktrace.c:
        Fixed compiler warning
      storage/maria/ha_maria.cc:
        More DBUG_PRINT
        Added STATE_IN_REPAIR flag, which is set on start of repair. This allows us to see if 'crashed' flag was set intentionally.
        Don't log query for dropping temporary table.
      storage/maria/ha_maria.h:
        Added prototype for drop_table()
      storage/maria/ma_blockrec.c:
        More DBUG_PRINT
        Make read_long_data() inline for most cases. (Trivial speedup optimization)
      storage/maria/ma_check.c:
        Better warning if table was marked crashed by unfinnished repair
      storage/maria/ma_open.c:
        More DBUG_PRINT
      storage/maria/ma_recovery.c:
        Give warning if found crashed table.
        Changed warning for tables that can't be opened.
      storage/maria/ma_recovery_util.c:
        Write warnings to DBUG file
      storage/maria/maria_chk.c:
        Added STATE_IN_REPAIR flag, which is set on start of repair. This allows us to see if 'crashed' flag was set intentionally.
      storage/maria/maria_def.h:
        Added maria_mark_in_repair(x)
      storage/maria/maria_read_log.c:
        Added option: --character-sets-dir
      storage/maria/trnman.c:
        By default set min_read_from to max value.
        This allows us to remove TRN:s from rows during recovery to get more space.
        This fixes bug LP#602604: RQG: ma_blockrec.c:6187: _ma_apply_redo_insert_row_head_or_tail: Assertion `0' failed on Maria engine recovery
      d2f8b7d0
  3. 28 Mar, 2010 1 commit
    • Michael Widenius's avatar
      Fixed compiler warnings and sporadic failures in test cases · 1fec5af7
      Michael Widenius authored
      mysql-test/extra/rpl_tests/rpl_tmp_table_and_DDL.test:
        Added missing sync_slave_with_master; Fixes random failures
      mysql-test/include/default_mysqld.cnf:
        default-character-set -> character-set-server (removes warning in error files for usage of deprecated options)
      mysql-test/lib/My/SafeProcess/safe_process.cc:
        Fixed compiler warning
      mysql-test/lib/v1/mysql-test-run.pl:
        default-character-set -> character-set-server (removes warning in error files for usage of deprecated options)
      mysql-test/suite/rpl/r/rpl_do_grant.result:
        Updated test results
      mysql-test/suite/rpl/t/rpl_do_grant.test:
        Added missing sync_slave_with_master; Fixes random failures
        Had to explictely do stop slave before DROP USER to avoid failure on slave as the user is already dropped on slave.
      mysql-test/suite/rpl/t/rpl_name_const.test:
        Added missing sync_slave_with_master; Fixes random failures
      mysql-test/suite/rpl/t/rpl_row_basic_11bugs.test:
        Added missing sync_slave_with_master; Fixes random failures
      mysql-test/t/bug47671-master.opt:
        default-character-set -> character-set-server (removes warning in error files for usage of deprecated options)
      mysql-test/t/ctype_latin1_de-master.opt:
        default-character-set -> character-set-server (removes warning in error files for usage of deprecated options)
      mysql-test/t/ctype_ucs2_def-master.opt:
        default-character-set -> character-set-server (removes warning in error files for usage of deprecated options)
      sql-common/client.c:
        Fixed compiler warning
      sql/item.cc:
        Renamed function to remove compiler warnings (with gcc)
      sql/item.h:
        Renamed function to remove compiler warnings (with gcc)
      sql/item_cmpfunc.cc:
        Renamed function to remove compiler warnings (with gcc)
      sql/item_create.cc:
        Renamed function to remove compiler warnings (with gcc)
      sql/item_create.h:
        Renamed function to remove compiler warnings (with gcc)
      sql/item_sum.cc:
        Renamed function to remove compiler warnings (with gcc)
      sql/item_sum.h:
        Renamed function to remove compiler warnings (with gcc)
      sql/set_var.cc:
        Don't use bit_do_set() / bot_is_set() / bit_do_clear() as this generates compiler warnings
        (They are also of no use as we know the value can hold the bits)
      sql/sql_yacc.yy:
        Renamed function to remove compiler warnings (with gcc)
      storage/example/ha_example.h:
        Fixed old read_time() prototype
      storage/maria/ma_search.c:
        Added extra variables to remove compiler warnings
      storage/maria/maria_def.h:
        Added extra variables to remove compiler warnings
      storage/myisam/ft_stopwords.c:
        Added cast to get rid of compiler warning
      storage/xtradb/fil/fil0fil.c:
        Added cast to get rid of compiler warning
      storage/xtradb/include/page0page.h:
        Added const to get rid of compiler warning
      storage/xtradb/include/page0page.ic:
        Added const to get rid of compiler warning
      support-files/compiler_warnings.supp:
        Added suppression of strict-aliasing
      1fec5af7
  4. 28 Jan, 2010 1 commit
  5. 09 Dec, 2009 1 commit
    • Hakan Kuecuekyilmaz's avatar
      Fix for · da65906b
      Hakan Kuecuekyilmaz authored
          Bug #494255
          Cannot run RQG due to errors in mysql-test-run.pl v1
      
      Problem was missing variable declaration. Most likely due to a merge issue.
      da65906b
  6. 26 Nov, 2009 1 commit
  7. 14 Nov, 2008 1 commit