1. 16 Jul, 2019 1 commit
  2. 15 Jul, 2019 4 commits
    • Sergei Petrunia's avatar
      Disable rocksdb.shutdown test · d2f094d9
      Sergei Petrunia authored
      It was introduced by this patch in fb/mysql-5.6:
      Author: Yoshinori Matsunobu <yoshinori@fb.com>
      Date:   Mon Jun 10 14:09:28 2019 -0700
      
          Extending SHUTDOWN query to support read_only/aborting
      
          Summary:
          This diff extends SHUTDOWN query to support the following
          features.
          - Aborting with any specified exit code (range is 0..255).
          If nothing is specified or 0 is given, it does default clean
          shutdown. If 1+ is given, exits with the given error code
          immediately. This is helpful to shutting down instance
          even if it is stuck somewhere.
      
      MariaDB doesn't support SHUTDOWN statement or have any other way
      to exit the server process.
      d2f094d9
    • Julius Goryavsky's avatar
    • Sergei Petrunia's avatar
      1da84412
    • Jan Lindström's avatar
      MDEV-19746: Galera test failures because of wsrep_slave_threads identification · ec49976e
      Jan Lindström authored
      Problem was that tests select INFORMATION_SCHEMA.PROCESSLIST processes
      from user system user and empty state. Thus, there is not clear
      state for slave threads.
      
      Changes:
      - Added new status variables that store current amount of applier threads
      (wsrep_applier_thread_count) and rollbacker threads
      (wsrep_rollbacker_thread_count). This will make clear how many slave threads
      of certain type there is.
      - Added THD state "wsrep applier idle" when applier slave thread is
      waiting for work. This makes finding slave/applier threads easier.
      - Added force-restart option for mtr to always restart servers between tests
      to avoid race on start of the test
      - Added wait_condition_with_debug to wait until the passed statement returns
      true, or the operation times out. If operation times out, the additional error
      statement will be executed
      
      Changes to be committed:
      	new file:   mysql-test/include/force_restart.inc
      	new file:   mysql-test/include/wait_condition_with_debug.inc
      	modified:   mysql-test/mysql-test-run.pl
      	modified:   mysql-test/suite/galera/disabled.def
      	modified:   mysql-test/suite/galera/r/MW-336.result
      	modified:   mysql-test/suite/galera/r/galera_kill_applier.result
      	modified:   mysql-test/suite/galera/r/galera_var_slave_threads.result
      	new file:   mysql-test/suite/galera/t/MW-336.cnf
      	modified:   mysql-test/suite/galera/t/MW-336.test
      	modified:   mysql-test/suite/galera/t/galera_kill_applier.test
      	modified:   mysql-test/suite/galera/t/galera_parallel_autoinc_largetrx.test
      	modified:   mysql-test/suite/galera/t/galera_parallel_autoinc_manytrx.test
      	modified:   mysql-test/suite/galera/t/galera_var_slave_threads.test
      	modified:   mysql-test/suite/wsrep/disabled.def
      	modified:   mysql-test/suite/wsrep/r/variables.result
      	modified:   mysql-test/suite/wsrep/t/variables.test
      	modified:   sql/mysqld.cc
      	modified:   sql/wsrep_mysqld.cc
      	modified:   sql/wsrep_mysqld.h
      	modified:   sql/wsrep_thd.cc
      	modified:   sql/wsrep_var.cc
      ec49976e
  3. 14 Jul, 2019 2 commits
  4. 12 Jul, 2019 4 commits
  5. 10 Jul, 2019 7 commits
    • Thirunarayanan Balathandayuthapani's avatar
      MDEV-19630 ALTER TABLE ... ADD COLUMN damages foreign keys · 07b1a26c
      Thirunarayanan Balathandayuthapani authored
      		which are pointed to the table being altered
      Problem:
      ========
      	InnoDB failed to change the column name present in foreign key cache
      for instant add column. So it leads to column mismatch for the consecutive
      rename of column.
      
      Solution:
      =========
      	Evict the foreign key information from cache and load the foreign
      key information again for instant operation.
      07b1a26c
    • Thirunarayanan Balathandayuthapani's avatar
      MDEV-19974 InnoDB: Cannot load compressed BLOB · 7df17ca8
      Thirunarayanan Balathandayuthapani authored
      Problem:
      =======
      	During online alter, fts tokenization thread uses new table page size
      to read the externally stored page from old table. If the alter changes
      the page size then it leads to failure of alter table.
      
      Solution:
      =========
      	fts tokenization thread should use old table page size to read the
      externally stored page from old table.
      7df17ca8
    • Thirunarayanan Balathandayuthapani's avatar
      MDEV-15641 InnoDB crash while committing table-rebuilding ALTER TABLE · 64900e3d
      Thirunarayanan Balathandayuthapani authored
      Problem:
      ========
       There is a possibility that there can be more concurrent DMLs While the
      alter table thread is waiting for upgrading to MDL_EXCLUSIVE before commit phase.
      In commit phase, InnoDB acquires dict_operation_lock and it already holds MDL_EXCLUSIVE
      on the table. After that, InnoDB applies the concurrent DML logs in commit phase.
      This could lead to blocking of the following things:
      
        1) DML on the particular table (due to MDL_EXCLUSIVE on the table)
        2) InnoDB DDLs (due to dict_operation_lock)
        3) Purge thread, stats thread, the master thread (due to dict_operation_lock)
      
      Fix:
      ====
      Apply the concurrent DML logs in commit phase but before acquiring
      dict_operation_lock in commit phase. It makes sure that (2), (3) can't be
      blocked for longer time.
      64900e3d
    • Sergei Golubchik's avatar
      bugfix: RPM installation complains about policy files, mariadb.service is not installed · 578e8229
      Sergei Golubchik authored
      add a versioned libsepol dependency to the server rpm
      578e8229
    • Sergei Golubchik's avatar
      cleanup: CPACK_RPM_* package description · ab3a6ca6
      Sergei Golubchik authored
      add cmake helper macro SET_IF_UNSET()
      and use it for CPACK_* variables
      ab3a6ca6
    • Sergei Golubchik's avatar
      package ed25519 in debs · e47a143f
      Sergei Golubchik authored
      partial backport from 10.3
      e47a143f
    • Jan Lindström's avatar
      Galera test fixes. · 01d3e392
      Jan Lindström authored
      Changes to be committed:
      	modified:   suite/galera/r/galera_kill_ddl.result
      	modified:   suite/galera/r/galera_sync_wait_show.result
      	modified:   suite/galera/t/galera_kill_ddl.test
      01d3e392
  6. 09 Jul, 2019 10 commits
    • Eugene Kosov's avatar
      post-merge fixes · 46c9268b
      Eugene Kosov authored
      rebuild galera.galera_as_slave_gtid and multi_source.mdev-8874
      46c9268b
    • Eugene Kosov's avatar
      fix clang warnings · 4f1e4aa2
      Eugene Kosov authored
      4f1e4aa2
    • Eugene Kosov's avatar
      Merge 10.1 into 10.2 · 26c389b7
      Eugene Kosov authored
      26c389b7
    • Aleksey Midenkov's avatar
      MDEV-16222 Assertion `0' failed in row_purge_remove_sec_if_poss_leaf on table... · cf7a8b9e
      Aleksey Midenkov authored
      MDEV-16222 Assertion `0' failed in row_purge_remove_sec_if_poss_leaf on table with virtual columns and indexes
      
      Cause
      Stale thd->m_stmt_da->m_sql_errno which is from different invocation.
      
      Fix
      Reset error state before attempt to open table.
      cf7a8b9e
    • Aleksey Midenkov's avatar
      MDEV-19175 Server crashes in ha_partition::vers_can_native upon INSERT DELAYED... · b0dd048e
      Aleksey Midenkov authored
      MDEV-19175 Server crashes in ha_partition::vers_can_native upon INSERT DELAYED into versioned partitioned table
      
      Uninitialized LEX::part_info on ha_partition::vers_can_native().
      b0dd048e
    • Aleksey Midenkov's avatar
    • Aleksey Midenkov's avatar
      MDEV-19785 Storage CONNECT compilation error: unknown type name 'UNZFAM' · e91fb70f
      Aleksey Midenkov authored
      Another fail fix:
      
      undefined reference to `ZipLoadFile`
      e91fb70f
    • sysprg's avatar
      MDEV-18565: Galera mtr-suite fails if galera library is not installed (#1243) · 41f4f6be
      sysprg authored
      * MDEV-18565: Galera mtr-suite fails if galera library is not installed
      
      Currently, running mtr with an incorrect (for example, new or
      obsolete) version of wsrep_provider (for example, with the 26
      version of libgalera_smm.so) leads to the failure of tests in
      several suites with vague error diagnostics.
      
      As for the galera_3nodes suite, the mtr also does not effectively
      check all the prerequisites after merge with MDEV-18426 fixes.
      For example, tests that using mariabackup do not check for presence
      of ss and socat/nc. This is due to improper handling of relative
      paths in mtr scripts.
      
      In addition, some tests in different suites can be run without
      setting the environment variables such as MTR_GALERA_TFMT, XBSTREAM,
      and so on.
      
      To eliminate all these issues, this patch makes the following changes:
      
      1. Added auxiliary wsrep_mtr_check utility (which located in the
      mysql-test/lib/My/SafeProcess subdirectory), which compares the
      versions of the wsrep API that used by the server and by the wsrep
      provider library, and it does this comparison safely, without
      accessing the API if the versions do not match.
      
      2. All checks related to the presence of mariabackup and utilities
      that necessary for its operation transferred from the local directories
      of different mtr suites (from the suite.pm files) to the main suite.pm
      file. This not only reduces the amount of code and eliminates duplication
      of identical code fragments, but also avoids problems due to the inability
      of mtr to consider relative paths to include files when checking skip
      combinations.
      
      3. Setting the values of auxiliary environment variables that
      are necessary for Galera, SST scripts and mariabackup (to work
      properly) is moved to the main mysql-test-run.pl script, so as
      not to duplicate this code in different suites, and to avoid
      partial corrections of the same errors for different suites
      (while other suites remain uncorrected).
      
      4. Fixed duplication of the have_file_key_management.inc and
      have_filekeymanagement.inc files between different suites,
      these checks are also transferred to the top level.
      
      https://jira.mariadb.org/browse/MDEV-18565
      
      * Build without additional utility in configurations without wsrep support
      41f4f6be
    • Jan Lindström's avatar
      Galera test adjustments. · b9557418
      Jan Lindström authored
      Changes to be committed:
      	modified:   ../galera/disabled.def
      	modified:   ../galera/r/GAL-419.result
      	modified:   ../galera/t/GAL-419.test
      	modified:   ../galera/t/galera_ist_innodb_flush_logs.test
      	modified:   ../galera/t/galera_ist_mariabackup_innodb_flush_logs.test
      b9557418
    • Varun Gupta's avatar
      MDEV-17963: Assertion `field_pos < field_count' failed in... · fd08f953
      Varun Gupta authored
      MDEV-17963: Assertion `field_pos < field_count' failed in Protocol_text::store, Assertion `field_handlers == 0 || field_pos < field_count'
      
      The problem was that sp_head::MULTI_RESULTS was not set correctly for ANALYZE statement
      with SELECT ... INTO variable.
      This is a follow up fix for MDEV-7023
      fd08f953
  7. 08 Jul, 2019 4 commits
  8. 07 Jul, 2019 1 commit
  9. 06 Jul, 2019 1 commit
  10. 05 Jul, 2019 6 commits
    • Eugene Kosov's avatar
      MDEV-19292 "Row size too large" error when creating table with lots columns... · 5ebef422
      Eugene Kosov authored
      MDEV-19292 "Row size too large" error when creating table with lots columns when row format is DYNAMIC or COMPRESSED
      
      Basic idea of the patch: disallow creating tables which allow to create
      rows which are too big to insert. In other words, if user created a table user
      should never see an errors like 'can not insert row as it is too big for current
      page size'.
      
      SET innodb_strict_mode=OFF; will allow to create very long tables and only a
      warning will be issued.
      
      dict_table_t::get_overflow_field_local_len(): this function lets know a maximum
      local field len for overflow fields for every file and row format.
      
      innobase_check_column_length(): improve name to too_big_key_part_length()
      and reuse in a different part of code.
      
      create_table_info_t::prepare_create_table(): add check for maximum allowed
      key part length to keep ALGORITHM=COPY behavior similar to ALGORITHM=INPLACE
      behavior. Affected test is innodb.strict_mode
      
      Rename dict_index_too_big_for_tree() to
      dict_index_t::rec_potentially_too_big(): copy overflow-related size computation
      from dtuple_convert_big_rec(). A lot of tests was changed because of that.
      I wonder whether users will complain about it?
      
      Test innodb.max_record_size tests dict_index_t::rec_potentially_too_big()
      for different row formats and page sizes.
      5ebef422
    • HF's avatar
      Make Win compiler happy. · d04961cd
      HF authored
      d04961cd
    • Alexander Barkov's avatar
      Adding tests for MDEV-17857 Assertion `tmp != ((long long)... · be22d1ff
      Alexander Barkov authored
      Adding tests for MDEV-17857 Assertion `tmp != ((long long) 0x8000000000000000LL)' failed in TIME_from_longlong_datetime_packed upon SELECT with GROUP BY
      
      (they were forgotten in the previous commit)
      be22d1ff
    • Jan Lindström's avatar
      Disable MW-329 (badly written test case). · 044d0ffc
      Jan Lindström authored
      044d0ffc
    • Sergei Golubchik's avatar
      MDEV-19942 Default installation of mariadb-server doesn't allow clients to use client plugins · d3c21484
      Sergei Golubchik authored
      while client tools technically don't need or depend on libmariadb3.so,
      they need client plugins, that come with it.
      d3c21484
    • Alexander Barkov's avatar
      MDEV-17857 Assertion `tmp != ((long long) 0x8000000000000000LL)' failed in... · 11f13bff
      Alexander Barkov authored
      MDEV-17857 Assertion `tmp != ((long long) 0x8000000000000000LL)' failed in TIME_from_longlong_datetime_packed upon SELECT with GROUP BY
      11f13bff