An error occurred fetching the project authors.
- 30 Jul, 2007 1 commit
-
-
evgen@moonbone.local authored
When innodb detects a deadlock it calls ha_rollback_trans() to rollback the main transaction. But such action isn't allowed from inside of triggers and functions. When it happen the 'Explicit or implicit commit' error is thrown even if there is no commit/rollback statements in the trigger/function. This leads to the user confusion. Now the convert_error_code_to_mysql() function doesn't call the ha_rollback_trans() function directly but rather calls the mark_transaction_to_rollback function and returns an error. The sp_rcontext::find_handler() now doesn't allow errors to be caught by the trigger/function error handlers when the thd->is_fatal_sub_stmt_error flag is set. Procedures are still allowed to catch such errors. The sp_rcontext::find_handler function now accepts a THD handle as a parameter. The transaction_rollback_request and the is_fatal_sub_stmt_error flags are added to the THD class. The are initialized by the THD class constructor. Now the ha_autocommit_or_rollback function rolls back main transaction when not in a sub statement and the thd->transaction_rollback_request is set. The THD::restore_sub_statement_state function now resets the thd->is_fatal_sub_stmt_error flag on exit from a sub-statement.
-
- 23 Dec, 2006 1 commit
-
-
kent@mysql.com/kent-amd64.(none) authored
Changed header to GPL version 2 only
-
- 03 Aug, 2006 1 commit
-
-
malff/marcsql@weblab.(none) authored
Before this fix, - a runtime error in a statement in a stored procedure with no error handlers was properly detected (as expected) - a runtime error in a statement with an error handler inherited from a non local runtime context (i.e., proc a with a handler, calling proc b) was properly detected (as expected) - a runtime error in a statement with a *local* error handler was executed as follows : a) the statement would succeed, regardless of the error condition, (bug) b) the error handler would be called (as expected). The root cause is that functions like my_messqge_sql would "forget" to set the thread flag thd->net.report_error to 1, because of the check involving sp_rcontext::found_handler_here(). Failure to set this flag would cause, later in the call stack, in Item_func::fix_fields() at line 190, the code to return FALSE and consider that executing the statement was successful. With this fix : - error handling code, that was duplicated in different places in the code, is now implemented in sp_rcontext::handle_error(), - handle_error() correctly sets thd->net.report_error when a handler is present, regardless of the handler location (local, or in the call stack). A test case, bug8153_subselect, has been written to demonstrate the change of behavior before and after the fix. Another test case, bug8153_function_a, as also been writen. This test has the same behavior before and after the fix. This test has been written to demonstrate that the previous expected result of procedure bug18787, was incorrect, since select no_such_function() should fail and therefore not produce a result. The incorrect result for bug18787 has the same root cause as Bug#8153, and the expected result has been adjusted.
-
- 15 May, 2006 1 commit
-
-
knielsen@mysql.com authored
Stored procedure execution sometimes placed the address of auto variables in the list of Item changes to undo in THD::rollback_item_tree_changes(). This could cause stack corruption.
-
- 07 Apr, 2006 1 commit
-
-
pem@mysql.com authored
Also added comments, and fixing some coding style (mostly in comments too). There are no functional changes, so no tests or documentation needed. (This was originally part of a bugfix, but it was decided to not include this in that patch; instead it's done separately.)
-
- 01 Feb, 2006 1 commit
-
-
pem@mysql.com authored
Added comments.
-
- 25 Jan, 2006 1 commit
-
-
pem@mysql.com authored
For nested sql errno handlers (unlike sqlexception and other), we didn't stop searching when the innermost handler was found - now make sure we do.
-
- 17 Jan, 2006 1 commit
-
-
pem@mysql.com authored
-
- 13 Dec, 2005 1 commit
-
-
pem@mysql.com authored
Make the distinction between "exception conditions" and "completion conditions" (warning and "no data") as defined by the standard. The latter should not terminate a routine if no handler is found in the lexical scope.
-
- 07 Dec, 2005 1 commit
-
-
anozdrin@mysql.com authored
according to the standard. The idea is to use Field-classes to implement stored routines variables. Also, we should provide facade to Item-hierarchy by Item_field class (it is necessary, since SRVs take part in expressions). The patch fixes the following bugs: - BUG#8702: Stored Procedures: No Error/Warning shown for inappropriate data type matching; - BUG#8768: Functions: For any unsigned data type, -ve values can be passed and returned; - BUG#8769: Functions: For Int datatypes, out of range values can be passed and returned; - BUG#9078: STORED PROCDURE: Decimal digits are not displayed when we use DECIMAL datatype; - BUG#9572: Stored procedures: variable type declarations ignored; - BUG#12903: upper function does not work inside a function; - BUG#13705: parameters to stored procedures are not verified; - BUG#13808: ENUM type stored procedure parameter accepts non-enumerated data; - BUG#13909: Varchar Stored Procedure Parameter always BINARY string (ignores CHARACTER SET); - BUG#14161: Stored procedure cannot retrieve bigint unsigned; - BUG#14188: BINARY variables have no 0x00 padding; - BUG#15148: Stored procedure variables accept non-scalar values;
-
- 26 Sep, 2005 2 commits
-
-
pem@mysql.com authored
Search the chain of sp_rcontexts recursively for handlers. If one is found, it will be detected in the sp_head::execute() method at the corresponding level.
-
pem@mysql.com authored
Replaced the dumb in-handler/not-in-handler check with a proper recursion check of handlers being executed. (Re-commit in a different tree, to make push possible.)
-
- 21 Sep, 2005 1 commit
-
-
konstantin@mysql.com authored
cursor is interpreted latin1 character and Bug#9819 "Cursors: Mysql Server Crash while fetching from table with 5 million records." A fix for a possible memory leak when fetching into an SP cursor in a long loop. The patch uses a common implementation of cursors in the binary protocol and in stored procedures and implements materialized cursors. For implementation details, see comments in sql_cursor.cc
-
- 18 Aug, 2005 1 commit
-
-
petr@mysql.com authored
and Bug#12297 SP crashes the server if data inserted inside a lon loop Third commit attempt. With fixes to the issues, showed up after full rebuild and tests on other hosts.
-
- 30 Jun, 2005 1 commit
-
-
pem@mysql.comhem.se authored
Make sure to cleanup the items for a cursor query after each open, otherwise it's done too late, after the run-time mem_root is freed.
-
- 14 Jun, 2005 1 commit
-
-
bell@sanja.is.com.ua authored
-
- 10 Jun, 2005 1 commit
-
-
pem@mysql.comhem.se authored
Fixed valgrind complaints. This fixes the memory leak problems for procedured, and partially for functions. There's still a leak involving results from functions that turned out to be too involved, so it will be fixed separately.
-
- 05 Jun, 2005 2 commits
-
-
kent@mysql.com authored
Include "mysql_priv.h" before testing USE_PRAGMA_IMPLEMENTATION
-
monty@mysql.com authored
Simple optimization for 2 argument usage to function of variable arguments Fix stack overrun when using 1+1+1+1+1+1+1+.... Update crash-me results for 5.0 Don't call post_open if pre_open() fails (optimization)
-
- 27 May, 2005 1 commit
-
-
msvensson@neptunus.(none) authored
-
- 23 May, 2005 1 commit
-
-
pem@mysql.comhem.se authored
Memory leak in locally evalutated expressions during SP execution fixed by reusing allocated item slots when possible. Note: No test case added, since the test is a stress test that tries to make the machine to run out of memory. Second attempt, now tested with debug build, valgrind build, max (optimized) build, with and without --debug, --vagrind and --ps-protocol. Errors in trigger and view test with --debug in debug build where present before this patch, and likewise for valgrind warnings for view test in valgrind build with --ps-protocol.
-
- 19 May, 2005 1 commit
-
-
jimw@mysql.com authored
-
- 18 May, 2005 1 commit
-
-
pem@mysql.comhem.se authored
Memory leak in locally evalutated expressions during SP execution fixed by reusing allocated item slots when possible. Note: No test case added, since the test is a stress test that tries to make the machine to run out of memory.
-
- 08 May, 2005 1 commit
-
-
bell@book.sanja.is.com.ua authored
Item::fix_field need correct pointer on item reference to chnge it if itis need, so support of correct item address added to SP commands (BUG#5963) some optimisation of IF/NOT IF ptomised to Pem
-
- 14 Apr, 2005 1 commit
-
-
pem@mysql.comhem.se authored
overwrites IN variable and added error checking of variables for [IN]OUT parameters while rewriting the out parameter handling.
-
- 08 Apr, 2005 2 commits
-
-
pem@mysql.comhem.se authored
and BUG#9074: STORED PROC: The scope of every handler declared is not properly applied
-
pem@mysql.comhem.se authored
-
- 04 Mar, 2005 1 commit
-
-
dlenev@brandersnatch.localdomain authored
and some SP-related cleanups. - We don't have separate stage for calculation of list of tables to be prelocked and doing implicit LOCK/UNLOCK any more. Instead we calculate this list at open_tables() and do implicit LOCK in lock_tables() (and UNLOCK in close_thread_tables()). Also now we support cases when same table (with same alias) is used several times in the same query in SP. - Cleaned up execution of SP. Moved all common code which handles LEX and does preparations before statement execution or complex expression evaluation to auxilary sp_lex_keeper class. Now all statements in SP (and corresponding instructions) that evaluate expression which can contain subquery have their own LEX.
-
- 19 Feb, 2005 1 commit
-
-
monty@mysql.com authored
Lots of small fixes to multi-precision-math path Give Note for '123.4e' Added helper functions type 'val_string_from_real() Don't give warnings for end space for string2decimal() Changed storage of values for SP so that we can detect length of argument without strlen() Changed interface for str2dec() so that we must supple the pointer to the last character in the buffer
-
- 08 Feb, 2005 1 commit
-
-
hf@deer.(none) authored
-
- 12 Nov, 2004 1 commit
-
-
bell@sanja.is.com.ua authored
-
- 23 Oct, 2004 1 commit
-
-
pem@mysql.comhem.se authored
-
- 20 Oct, 2004 1 commit
-
-
bell@sanja.is.com.ua authored
net_printf/send_error calls replaced by my_error family functions -1/1 (sent/unsent) error reporting removed (WL#2133)
-
- 28 Sep, 2004 1 commit
-
-
monty@mishka.local authored
Under strict mode MySQL will generate an error message if there was any conversion when assigning data to a field. Added checking of date/datetime fields. If strict mode, give error if we have not given value to field without a default value (for INSERT)
-
- 10 Sep, 2004 2 commits
-
-
pem@mysql.comhem.se authored
-
pem@mysql.comhem.se authored
Dropping the table was not the real problem, the problem was with errors occuring within error handlers.
-
- 21 Jul, 2004 1 commit
-
-
pem@mysql.comhem.se authored
We now get an run-time error instead of a crash (although a slightly misleading error message, but it's an improvement).
-
- 09 Jan, 2004 1 commit
-
-
pem@mysql.comhem.se authored
(And some minor correction of cursor open)
-
- 08 Jan, 2004 2 commits
-
-
pem@mysql.comhem.se authored
-
pem@mysql.comhem.se authored
Initialize and test properly when cleaning up, to avoid crash in some error cases.
-