1. 31 Jul, 2013 3 commits
    • Sergey Vojtovich's avatar
      Merged fix for uninitialized variables. · 159866b6
      Sergey Vojtovich authored
      159866b6
    • Sergey Vojtovich's avatar
      MDEV-4786 - merge 10.0-monty - 10.0 · e9f6c47f
      Sergey Vojtovich authored
      Fixed "check of testcases" failure.
      
      Value of INFORMATION_SCHEMA.PLUGINS.PLUGIN_TYPE_VERSION was
      pointing to incorrect address and could change after server
      restart.
      
      storage/innobase/handler/i_s.cc:
        Use proper plugin info pointer (struct st_mysql_information_schema
        instead of ST_FIELD_INFO[]).
      e9f6c47f
    • Sergey Vojtovich's avatar
      MDEV-4786 - merge 10.0-monty - 10.0 · 9dd68da1
      Sergey Vojtovich authored
      Fixed archive.archive non-debug failure.
      
      Applied revision:
      sergey.vojtovich@oracle.com-20111008171828-vje5pumzvl04rdbb
      
      Archive didn't read blobs from original table while
      performing REPAIR TABLE with non-debug builds.
      
      storage/archive/ha_archive.cc:
        Mark all columns for read independently of DBUG state.
        It instructs ::get_row_version2() to read all blobs.
      9dd68da1
  2. 30 Jul, 2013 4 commits
    • Sergey Vojtovich's avatar
      MDEV-4786 - merge 10.0-monty - 10.0 · b183cda3
      Sergey Vojtovich authored
      Fixed sys_vars.log_error_func, sys_vars.log_error_func2,
      maria.small_blocksize, sys_vars.autocommit_func3, sys_vars.autocommit_func2,
      sys_vars.autocommit_func4, sys_vars.autocommit_func5,
      sys_vars.tx_isolation_func, main.pool_of_threads, innodb.innodb,
      archive.archive-big, parts.part_supported_sql_func_innodb,
      parts.partition_decimal_myisam, parts.partition_decimal_innodb,
      main.sum_distinct-big, percona.innodb_sys_index,
      percona.percona_flush_contiguous_neighbors failures.
      
      libmysqld/lib_sql.cc:
        Restore proper method to retrieve warnings number.
      b183cda3
    • Sergey Vojtovich's avatar
      MDEV-4786 - merge 10.0-monty - 10.0 · bdb7af8d
      Sergey Vojtovich authored
      Fixed parts.partition_alter1_1_2_innodb, parts.partition_alter1_2_innodb,
      parts.partition_alter2_1_1_innodb, parts.partition_alter2_1_2_innodb,
      parts.partition_alter2_2_1_innodb, parts.partition_alter2_2_2_innodb,
      parts.partition_alter4_innodb failures.
      
      mysql-test/suite/parts/r/partition_alter1_1_2_innodb.result:
        Reverted some changes to test case as InnoDB doesn't support
        REPAIR TABLE and we didn't merge the following revision, which
        implements REPAIR TABLE for partitioning:
        mattias.jonsson@oracle.com-20130130165152-o4tivhs5ty6n6nqa
      mysql-test/suite/parts/r/partition_alter1_2_innodb.result:
        Reverted some changes to test case as InnoDB doesn't support
        REPAIR TABLE and we didn't merge the following revision, which
        implements REPAIR TABLE for partitioning:
        mattias.jonsson@oracle.com-20130130165152-o4tivhs5ty6n6nqa
      mysql-test/suite/parts/r/partition_alter2_1_1_innodb.result:
        Reverted some changes to test case as InnoDB doesn't support
        REPAIR TABLE and we didn't merge the following revision, which
        implements REPAIR TABLE for partitioning:
        mattias.jonsson@oracle.com-20130130165152-o4tivhs5ty6n6nqa
      mysql-test/suite/parts/r/partition_alter2_1_2_innodb.result:
        Reverted some changes to test case as InnoDB doesn't support
        REPAIR TABLE and we didn't merge the following revision, which
        implements REPAIR TABLE for partitioning:
        mattias.jonsson@oracle.com-20130130165152-o4tivhs5ty6n6nqa
      mysql-test/suite/parts/r/partition_alter2_2_1_innodb.result:
        Reverted some changes to test case as InnoDB doesn't support
        REPAIR TABLE and we didn't merge the following revision, which
        implements REPAIR TABLE for partitioning:
        mattias.jonsson@oracle.com-20130130165152-o4tivhs5ty6n6nqa
      mysql-test/suite/parts/r/partition_alter2_2_2_innodb.result:
        Reverted some changes to test case as InnoDB doesn't support
        REPAIR TABLE and we didn't merge the following revision, which
        implements REPAIR TABLE for partitioning:
        mattias.jonsson@oracle.com-20130130165152-o4tivhs5ty6n6nqa
      mysql-test/suite/parts/r/partition_alter4_innodb.result:
        Reverted some changes to test case as InnoDB doesn't support
        REPAIR TABLE and we didn't merge the following revision, which
        implements REPAIR TABLE for partitioning:
        mattias.jonsson@oracle.com-20130130165152-o4tivhs5ty6n6nqa
      bdb7af8d
    • Sergey Vojtovich's avatar
      MDEV-4786 - merge 10.0-monty - 10.0 · bdbdbb82
      Sergey Vojtovich authored
      Fixed parts.partition_alter1_1_innodb failure.
      
      mysql-test/suite/parts/t/partition_alter1_1_innodb.test:
        Applied hunk from 5.6 test: test takes long time, so only run it with
        the --big-test mtr-flag.
      bdbdbb82
    • Sergey Vojtovich's avatar
      MDEV-4786 - merge 10.0-monty - 10.0 · 9fff3f5b
      Sergey Vojtovich authored
      Fixed innodb.innodb_mysql failure.
      
      mysql-test/include/mix1.inc:
        Applied hunk from 5.6 test: error text has changed during merge.
      9fff3f5b
  3. 29 Jul, 2013 1 commit
    • Sergey Vojtovich's avatar
      MDEV-4786 - merge 10.0-monty - 10.0 · 0f985c64
      Sergey Vojtovich authored
      Fixed archive.archive failure.
      
      Applied remnants of two revisions, which were partially merged.
      
      Rev. 3225.1.1 (5.0 compatibility):
      
        BUG#11756687 - 48633: ARCHIVE TABLES ARE NOT UPGRADEABLE
      
        Archive table created by 5.0 were not accessible.
      
        This patch adds various fixes so that 5.0 archive tables
        are readable and writable. Though it is strongly recommended
        to avoid binary upgrade of archive tables whenever it is
        possible.
      
      Rev. 3710 (due to valgrind warnings):
      
        Bug#13907676: HA_ARCHIVE::INFO
        In WL#4305 the refactoring of the archive writer,
        it could flush the writer when it was not yet open.
      
        This was due to if bulk insert was used but no
        rows was actually inserted (write_row was never called),
        the writer was marked dirty even if it was not open.
      
        Fix was to only mark it as dirty if it was opened.
      
      mysql-test/std_data/bug48633.ARM:
        A test case for BUG#11756687: archive table created by 5.0.95.
      mysql-test/std_data/bug48633.ARZ:
        A test case for BUG#11756687: archive table created by 5.0.95.
      mysql-test/std_data/bug48633.frm:
        A test case for BUG#11756687: archive table created by 5.0.95.
      mysql-test/suite/archive/archive.result:
        Modified a test case for BUG#47012 according to fix for
        BUG#11756687.
        Added a test case for BUG#11756687.
      mysql-test/suite/archive/archive.test:
        Modified a test case for BUG#47012 according to fix for
        BUG#11756687.
        Added a test case for BUG#11756687.
        
        No need to remove .ARM files anymore: DROP TABLE will take
        care of them.
      storage/archive/azio.c:
        Do not write AZIO (v.3) header to GZIO file (v.1).
        
        Added initialization of various azio_stream members
        to read_header() so it can proceed with v.1 format.
        
        Update data start position only when reading first
        GZIO header. That is only on azopen(), but never on
        azread().
      storage/archive/ha_archive.cc:
        Removed guardians that were rejecting to open v.1 archive
        tables.
        
        Reload .frm when repairing v.1 tables - they didn't have
        storage for .frm.
        
        Do not flush write stream when it is not open.
        
        Let DROP TABLE remove 5.0 .ARM files.
      0f985c64
  4. 27 Jul, 2013 2 commits
    • Sergey Vojtovich's avatar
      MDEV-4786 - merge 10.0-monty - 10.0 · 5f8effe1
      Sergey Vojtovich authored
      Fixed debian/ubuntu build failure.
      
      cmake/ssl.cmake:
        Do not prefer static SSL libraries for WITH_SSL=system|yes as there is
        no guarantee that they will link well with MariaDB shared objects.
        Specifically on debian/ubuntu static SSL libraries are built without
        -fPIC.
        
        Restore 5.6 behavior. 10.0.3 never prefer static SSL libraries.
      5f8effe1
    • Igor Babaev's avatar
      MDEV-4786 - merge 10.0-monty - 10.0 · b07d0e2a
      Igor Babaev authored
      Fixed failure of one of the test case from innodb_ext_key.test.
      The fact is that the innodb code may return statistical data
      on record per key values that is far off the real numbers. 
      This is exactly what happened in mariadb-5.5 with this test case.
      
      Added an ANALYZE command in this test case to avoid this problem.
      The same change will be done in mariadb-5.5
      b07d0e2a
  5. 26 Jul, 2013 4 commits
    • Sergey Vojtovich's avatar
      MDEV-4786 - merge 10.0-monty - 10.0 · b3a1f420
      Sergey Vojtovich authored
      Fixed connect.grant failure.
      
      sql/create_options.cc:
        Keep "first" list intact, allocate new list for merge result.
        
        Normally "first" is options list on TABLE_SHARE. ALTER TABLE may fail
        after the merge and leave share with corrupt list in the table definition
        cache.
      sql/create_options.h:
        Construct engine_option_value from another engine_option_value.
      b3a1f420
    • Alexey Botchkov's avatar
      main.gis test fixed. · 62feb0c5
      Alexey Botchkov authored
      62feb0c5
    • Sergey Vojtovich's avatar
      MDEV-4786 - merge 10.0-monty - 10.0 · b385fdc6
      Sergey Vojtovich authored
      Fixed maria.maria and funcs_1.is_tables failure.
      
      sql/sql_table.cc:
        C_ALTER_TABLE_FRM_ONLY lost it's meaning after merge of inplace alter:
        now it is used even if table is to be copied.
        Otherwise: how can row format change go without notifying storage engine?
        Removed check for create_table_mode for now, to be discussed.
      b385fdc6
    • Sergey Vojtovich's avatar
      MDEV-4786 - merge 10.0-monty - 10.0 · 5845b83d
      Sergey Vojtovich authored
      Fixed query_response_time build failure.
      
      plugin/query_response_time/query_response_time.cc:
        my_atomic_rwlock_rdlock() may update time_collector_lock structure.
        Remove const modifier from relevant methods.
      5845b83d
  6. 25 Jul, 2013 3 commits
    • Sergey Vojtovich's avatar
      MDEV-4786 - merge 10.0-monty - 10.0 · e084a2b0
      Sergey Vojtovich authored
      Fixed debian/ubuntu packages build failure.
      
      debian/patches/33_scripts__mysql_create_system_tables__no_test.dpatch:
        tmp_user has now extra column, updated patch accordingly.
      e084a2b0
    • Sergey Vojtovich's avatar
      MDEV-4786 - merge 10.0-monty - 10.0 · e33e9825
      Sergey Vojtovich authored
      Fixed main.innodb_mysql_sync failure.
      
      TDC_RT_REMOVE_NOT_OWN_KEEP_SHARE is not same as
      TDC_RT_REMOVE_NOT_OWN_AND_MARK_NOT_USABLE. Comment in sql_table.cc says:
      
            Storage engine has requested exclusive lock only for prepare phase
            and we are not under LOCK TABLES.
            Don't mark TABLE_SHARE as old in this case, as this won't allow opening
            of table by other threads during main phase of in-place ALTER TABLE.
      
      At this moment we hold exclusive metadata lock, all we should do
      is purge unused TABLE objects.
      
      sql/sql_base.cc:
        Restore 5.6 behavior of TDC_RT_REMOVE_NOT_OWN_KEEP_SHARE.
      sql/sql_base.h:
        Restore 5.6 behavior of TDC_RT_REMOVE_NOT_OWN_KEEP_SHARE.
      e33e9825
    • Sergey Vojtovich's avatar
      MDEV-4786 - merge 10.0-monty - 10.0 · 9388822c
      Sergey Vojtovich authored
      Fixed main.mysql--help failure.
      
      mysql-test/r/mysqld--help.result:
        PFS_MAX_RWLOCK_CLASS was raised to 40 during the merge.
      9388822c
  7. 24 Jul, 2013 7 commits
  8. 23 Jul, 2013 4 commits
    • Sergey Vojtovich's avatar
      MDEV-4786 - merge 10.0-monty → 10.0 · b2aea91f
      Sergey Vojtovich authored
      Fixed connect compilation failure.
      
      storage/connect/csort.cpp:
        min/max are not defined by my_global.h anymore, include osutil.h instead.
      storage/connect/filamfix.cpp:
        min/max are not defined by my_global.h anymore, include osutil.h instead.
      storage/connect/ha_connect.cc:
        Renamed MYSQL_ERROR -> Sql_condition.
        Renamed KEY::key_parts -> KEY::user_defined_key_parts.
        Adjusted connect according to:
        WL#4305 - storage-engine private data area per physical table.
      storage/connect/ha_connect.h:
        Adjusted connect according to:
        WL#4305 - storage-engine private data area per physical table.
      storage/connect/inihandl.c:
        min/max are not defined by my_global.h anymore, include osutil.h instead.
      storage/connect/osutil.h:
        min/max are not defined by my_global.h anymore, define them for C as well.
      storage/connect/taboccur.cpp:
        Include server headers before osutil.h to avoid min/max redefinition.
      storage/connect/tabpivot.cpp:
        Include server headers before osutil.h to avoid min/max redefinition.
      storage/connect/tabtbl.cpp:
        Include server headers before osutil.h to avoid min/max redefinition.
      storage/connect/tabxcl.cpp:
        Include server headers before osutil.h to avoid min/max redefinition.
      storage/connect/value.cpp:
        min/max are not defined by my_global.h anymore, include osutil.h instead.
        Include server headers before osutil.h to avoid min/max redefinition.
      b2aea91f
    • Sergey Vojtovich's avatar
      MDEV-4786 - merge 10.0-monty → 10.0 · 84d07384
      Sergey Vojtovich authored
      Fixed test_sql_discovery compilation failure.
      
      storage/test_sql_discovery/mysql-test/archive/discover.rdiff:
        archive.discover result has changed during merge. Adjusted discover.rdiff
        accordingly.
      storage/test_sql_discovery/test_sql_discovery.cc:
        Adjusted test_sql_discovery according to:
        WL#4305 - storage-engine private data area per physical table.
      84d07384
    • Sergey Vojtovich's avatar
      MDEV-4786 - merge 10.0-monty → 10.0 · 6069e780
      Sergey Vojtovich authored
      Fixed sequence compilation failure.
      
      storage/sequence/sequence.cc:
        Adjusted sequence according to:
        WL#4305 - storage-engine private data area per physical table.
      6069e780
    • Sergey Vojtovich's avatar
      MDEV4786 - merge 10.0-monty → 10.0 · 43946c08
      Sergey Vojtovich authored
      sql/sql_table.cc:
        Removed false assertion that HA_NO_COPY_ON_ALTER is merge specific.
        This flag is used at least by Spider and Connect.
      storage/spider/ha_spider.cc:
        Renamed THD::stmt_da -> THD::get_stmt_da().
        Renamed KEY::key_parts -> KEY::user_defined_key_parts.
        Renamed ALTER_* flags -> Alter_info::ALTER_*.
      storage/spider/spd_conn.cc:
        Renamed THD::stmt_da -> THD::get_stmt_da().
      storage/spider/spd_db_conn.cc:
        Renamed MYSQL_ERROR -> Sql_condition.
        Renamed KEY::key_parts -> KEY::user_defined_key_parts.
      storage/spider/spd_db_include.h:
        current_comment_start argument of generate_parition_syntax()
        was removed during merge.
      storage/spider/spd_db_mysql.cc:
        Renamed KEY::key_parts -> KEY::user_defined_key_parts.
      storage/spider/spd_ping_table.cc:
        Renamed THD::stmt_da -> THD::get_stmt_da().
      storage/spider/spd_table.cc:
        Include my_getopt.h so that it exports my_defaults_file and
        my_defaults_extra_file.
        Renamed KEY::key_parts -> KEY::user_defined_key_parts.
      43946c08
  9. 21 Jul, 2013 3 commits
    • Sergei Golubchik's avatar
      more post-merge fixes: · 13dca012
      Sergei Golubchik authored
      * update results
      * don't force HA_CREATE_DELAY_KEY_WRITE on all temp tables,
        (bad for CREATE ... LIKE) instead imply it in myisam/aria
      * restore HA_ERR_TABLE_DEF_CHANGED in archive
      * increase the default number of rwlock classes in P_S to fit all our rwlocks
      13dca012
    • Sergei Golubchik's avatar
      cosmetic fixes · d1fdb17b
      Sergei Golubchik authored
      d1fdb17b
    • Sergei Golubchik's avatar
      10.0-monty merge · b7b5f6f1
      Sergei Golubchik authored
      includes:
      * remove some remnants of "Bug#14521864: MYSQL 5.1 TO 5.5 BUGS PARTITIONING"
      * introduce LOCK_share, now LOCK_ha_data is strictly for engines
      * rea_create_table() always creates .par file (even in "frm-only" mode)
      * fix a 5.6 bug, temp file leak on dummy ALTER TABLE
      b7b5f6f1
  10. 18 Jul, 2013 2 commits
  11. 17 Jul, 2013 2 commits
  12. 18 Jul, 2013 1 commit
  13. 17 Jul, 2013 3 commits
  14. 16 Jul, 2013 1 commit